Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uamLU-009eGC-Dm for pgsql-committers@arkaria.postgresql.org; Sun, 13 Jul 2025 02:21:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uamLR-00ClGA-1U for pgsql-committers@arkaria.postgresql.org; Sun, 13 Jul 2025 02:21:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uamLQ-00ClG2-8G for pgsql-committers@lists.postgresql.org; Sun, 13 Jul 2025 02:21:37 +0000 Received: from fhigh-b5-smtp.messagingengine.com ([202.12.124.156]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uamLN-007HIo-0l for pgsql-committers@lists.postgresql.org; Sun, 13 Jul 2025 02:21:35 +0000 Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfhigh.stl.internal (Postfix) with ESMTP id D168A7A0034; Sat, 12 Jul 2025 22:21:30 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Sat, 12 Jul 2025 22:21:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1752373290; x=1752459690; bh=QxIU2VXLXP FIfkTvz4oZqosyRDq73S4lxhH+8UFgLyY=; b=dY1lSbcVnKaVdwNmZXEyeKMjEc iVEVlFpDG72OnuwJXYuzirY0ACif39ccXkAKw16PRt1z2wLP2p9bM+gs8Mi3VgIF MbMoErakFTZ25ilFgkuwWV5LhxMkczOoYr/1dHMwNJgcMxWZMRHNsWYDOmpp2v1P o+T5W1FlYhvP19Q0jqh3Vt+8E+wbgSoiuMuUc9h69mSeawmu33KzM5JnhDa0sKye SNCfLKFdG3kb4RVdXHSXpD5VGewjNHbIjEDcCZJblVqeftTo6jHHaaseL1xgsJd7 3lrETcM1mfM3ysEKEIFla4DKPlnoS8V2tHf4CtJ4hauCg2t9NJTseuKqht2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1752373290; x=1752459690; bh=QxIU2VXLXPFIfkTvz4oZqosyRDq73S4lxhH +8UFgLyY=; b=mDaTBfD70EK7eBztqROOpO8CymzSJ8WcxCW4Kh1c/4Yc3fDZ68X oj2qS9phY/0TPNCx8sFFEzsIbvo5lffneg1kBPYsT36vAWsOJ+Na99QUpF+BjRPE DZL/FLtg5EEsuz28DfAaOMBfidbJN186vn6KNPgNcyCAzKhIx+OV8cUIgdWKj2ga DNUiv6Ayosjw4WQQ4ZXQ6MvEkwDZuo5cM2dg/jQTnBtiPO4khyePjS/mh2qQkVG9 e8+KomEc1uhAbYOLamCD6idUkqSGjRPrsGSQVYDJCdyc3u91WnZ5nYbH4/UdtskO ZLVnutl0mgNJ0hCnD2afkdWCKDQBE4hzykA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdegjeekiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlh cuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvden ucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquh hivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeggeff hfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiipdhn sggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegrlhgvkh hsrghnuggvrhesthhighgvrhgurghtrgdrtghomhdprhgtphhtthhopehpghhsqhhlqdgt ohhmmhhithhtvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 12 Jul 2025 22:21:28 -0400 (EDT) Date: Sun, 13 Jul 2025 11:21:20 +0900 From: Michael Paquier To: Aleksander Alekseev Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: injection_points: Add injection_points_list() Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="S+A5ZFwo3cGe9gn6" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --S+A5ZFwo3cGe9gn6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 10, 2025 at 01:24:48PM +0300, Aleksander Alekseev wrote: > In injection_points_list() isn't `memset(values, 0, sizeof(values))` > redundant? Yes, I'm just finding this to be a cleaner practice. > Also perhaps we want to pfree inj_points. This is freed with the memory context of the function, so any way is fine IMO. -- Michael --S+A5ZFwo3cGe9gn6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmhzGCAACgkQnvQgOdby QH2j+A//QmjwA4kC/J8KZPzG1zxw1it59HQMOgpGuwx+L5v0gbIaxvs7WDc0fDpl XMyhwngRJBnZdHSQI45A7WEr30ygRjnE9DlCzqv5O4hHKVkpnyAZUwRa39yN9OFn Jb4sRuVDLYaSyzsOsjsFf3p4GlGNrZxGg5KIedhX3Z8Oj3Cj/cDutUv7ItdC1z+0 8lWp2Co7oKHYL+9rKqKoVpAZWe9WLEDiZwIsyiIGQPfdNScd/HvzEV7bbqIaO6rR mQ1IPphIT5UID0k9mVunQx6gX4jO6MecnrnZoni+kAQZUYCfY8pGGKH5LDhokBWK dwBaace42yL53NfRd4WI4Ee/sAJKR5eaJ1Bj2TwqptIdD5GFmdSGnAmc9EdF54qf 81wvaoQY7CUdjqJkZRib0W0pId0827yMrRjcxi7mRvq6KO8Ulbrz6rYqp8sETQHC 2peLiCb9ZD+tnear4CGFcHwE4XfiVbihEfHEhVjR3V0D9uqNwpl0LpR8RtnelCEE ysszIk7BD70wn+Plspaz7utrRpe8/lOt5Y0X93onaqC7mbx3voibMGJkD5repjtT jh+uC7KHGuQxzP41F9wMQiN8PXmgQPrDwLNsqJ96WrTLGgL5D2sGlwZUQzo4D/i/ ob9NtCIpMtzAX42wGwD4n4XexSh+A1oFG2BYqgduOldKCXGSAQ0= =jHg5 -----END PGP SIGNATURE----- --S+A5ZFwo3cGe9gn6--