Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 24 Jul 2025 10:25:21 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <akapila@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Preserve conflict-relevant data during logical
 replication.
Message-ID: <aIGLgfRJIBwExoPj@paquier.xyz>
References: <E1ueQG2-000IEd-0c@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="/QYWpZw3sUSa9zqO"
Content-Disposition: inline
In-Reply-To: <E1ueQG2-000IEd-0c@gemulon.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/aIGLgfRJIBwExoPj%40paquier.xyz>
Precedence: bulk


--/QYWpZw3sUSa9zqO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 23, 2025 at 03:35:06AM +0000, Amit Kapila wrote:
> Preserve conflict-relevant data during logical replication.
>=20
> Logical replication requires reliable conflict detection to maintain data
> consistency across nodes. To achieve this, we must prevent premature
> removal of tuples deleted by other origins and their associated commit_ts
> data by VACUUM, which could otherwise lead to incorrect conflict reporting
> and resolution.

Some of the tests added by this commit are causing blurps in the CI:
https://cfbot.cputube.org/highlights/all.html

Example of one job (triggered it once myself with a separate patch):
https://cirrus-ci.com/task/5397273342902272
[21:15:03.131](0.028s) not ok 7 - altering retain_dead_tuples is
allowed for disabled subscription
[21:18:48.295](225.164s) # poll_query_until timed out executing this
query:
[21:18:48.296](0.000s) not ok 8 - the xmin value of slot
'pg_conflict_detection' is valid on Node A
[21:18:48.306](0.010s) not ok 9 - warn of the possibility of receiving
changes from origins other than the publisher
[21:18:48.412](0.037s) not ok 11 - the deleted column is non-removable
[21:22:29.286](220.874s) # poll_query_until timed out executing this
query:
[21:22:29.287](0.000s) not ok 12 - the xmin value of slot
'pg_conflict_detection' is updated on Node A
[21:22:29.297](0.010s) not ok 13 - the deleted column is removed

The failures happen on FreeBSD as far as I know, that enforces some
rules not used elsewhere:=20
      -c debug_copy_parse_plan_trees=3Don
      -c debug_write_read_parse_plan_trees=3Don
      -c debug_raw_expression_coverage_test=3Don
      -c debug_parallel_query=3Dregress
[...]
    CPPFLAGS: -DRELCACHE_FORCE_RELEASE -DENFORCE_REGRESSION_TEST_NAME_RESTR=
ICTIONS

I suspect that reusing these options would help in reproducing the
problem.  These are not commonly used in buildfarm animals, reducing
the friction to make the instability show up.
--
Michael

--/QYWpZw3sUSa9zqO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmiBi4EACgkQnvQgOdby
QH275Q//R0Ndp5Vm4jcmHZQgoSDZEiGyLwFsq5rVrQt2qgKqKFbzlQFTB2cRS2/8
5tWq2bsO7UkcDFD32daq1GfMxSkiRd8fmgxkyOAkCPLMPnCf0b7uo08/GtX9ww2y
hcW09udgQr4LoEzcno5gMs1Wh5UodwavxlPq3rF+zR57L6BigWaHmD49SUY0Nyhl
Bfha5jTPShrsWJJdROG47dlZ/uCOgLLt7ZejVd3wCgkuhNhmSyBTpAFAo8BxgIFR
681+Iybgadtn/qEKtNt0z3WyW+r6wQV1Ae6soWkzz34YTJv9lvpbM4Jp+yoPov02
OcJNlMwKmaXQ4qb0xlq7bjVNugB4bSCybosqG/j1q5r7OEWd5sdcrV+4zKd2Pvl7
Acz2ALoTBM7MnGm0Nbw71sQrUjLjolXGg61I8u9PyK2NbHVzDEg65b/rL31F9zkX
YTF5eYyVDqoD4fBUODcxNTOPBvHr8UofCiPpJoalau8AfO5NfXoVAp6xt5xlD6l4
h025S5PwjxD4SDg1kRuxWoxYwwVLQ/jiI96pvY+ydnCFbXnTRrSViUmxxuQAX2Ce
fjlkTqddOLnAJXksQJUqzk5WKuaRQBb/dy3RM7sDP4bRH+B7jbTWtev6iZSBisE5
SHHqGxEU8KfdpaxlB5+paIHbCFEB8wXPF73PNYLRyXDKXL7ju0w=
=JP5/
-----END PGP SIGNATURE-----

--/QYWpZw3sUSa9zqO--