Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 19 Aug 2025 08:24:04 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move SQL-callable code related to multixacts into its own
 file
Message-ID: <aKO2FEbirGYRPwk8@paquier.xyz>
References: <E1unt88-000RJi-2l@gemulon.postgresql.org>
 <345438.1755524834@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="w4KvihVyElQWKJWi"
Content-Disposition: inline
In-Reply-To: <345438.1755524834@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/aKO2FEbirGYRPwk8%40paquier.xyz>
Precedence: bulk


--w4KvihVyElQWKJWi
Content-Type: multipart/mixed; boundary="6wCtSk2IUe9PLhxq"
Content-Disposition: inline


--6wCtSk2IUe9PLhxq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Aug 18, 2025 at 09:47:14AM -0400, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
> > Move SQL-callable code related to multixacts into its own file
>=20
> Couldn't this have removed some #include-s from multixact.c?

Right.  funcapi.h and fmgrprotos.h are direct dependencies, but
looking closer it is also possible to remove four more of them.
--
Michael

--6wCtSk2IUe9PLhxq
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="multixact-header.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/src/backend/access/transam/multixact.c b/src/backend/access/tr=
ansam/multixact.c
index 886740d2d553..6a7963ccd03f 100644
--- a/src/backend/access/transam/multixact.c
+++ b/src/backend/access/transam/multixact.c
@@ -70,16 +70,12 @@
=20
 #include "access/multixact.h"
 #include "access/slru.h"
-#include "access/transam.h"
 #include "access/twophase.h"
 #include "access/twophase_rmgr.h"
-#include "access/xact.h"
 #include "access/xlog.h"
 #include "access/xloginsert.h"
 #include "access/xlogutils.h"
 #include "commands/dbcommands.h"
-#include "funcapi.h"
-#include "lib/ilist.h"
 #include "miscadmin.h"
 #include "pg_trace.h"
 #include "pgstat.h"
@@ -87,7 +83,6 @@
 #include "storage/pmsignal.h"
 #include "storage/proc.h"
 #include "storage/procarray.h"
-#include "utils/fmgrprotos.h"
 #include "utils/guc_hooks.h"
 #include "utils/injection_point.h"
 #include "utils/memutils.h"

--6wCtSk2IUe9PLhxq--

--w4KvihVyElQWKJWi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmijthQACgkQnvQgOdby
QH2b1g//fNvEIMzgm8Fi95voK+e+dlH0DIOVgEsbIT6CTmIUXfYveFsD7TpG9/in
iU1KLEljAUNnPIEEp5L4Tb32wjPj5FgG7g1Rixi8qwMXsZ7N8C/0WR+Qoh3y/U1b
fWHewZWdbZN1FFVsOL6mCDu2KFDoRnw2IngxQZLoR0Pw4Y81L58NXGZnx+/iNd2p
i7586Yn12ADFNeH5xOszQQFrTh2Rs8oFN/bKgJjmHIHvTJcrQFUqG8ru1y6Qhot4
yGQW9hfl6SOhlVuZm57/D4UA6nfodutUbDezBPgjFv5xsA7PXI7ntSQdchVJNnEW
bSwhMWWiOL0+v8moNag4mzJfxu3Xy+D8kd9NxCSNS0DSYD6lfwgi2C9Lda73Dag3
1NV95mdMZAHGIurp6I+z5GGu9uBb1LG/5CmFNNPjzqLs4PwnpOi56asSbbtu9vYP
1WmDVdII324U4yBYunbDMK9NPAsLKR1zXJCNRHyziOeWvSlR8/P8fceDnLvFffuW
p+cHXlBwUjwnhrAFt4i+PqgpKQKUWowyWf9yT7YYkVQTOTpdJUQIRTTD4cCuLy8C
S4amQMEyU5uVBQrGc2uyX1eBjyShLVTDtEJa6yZmrMm1HOsm6yhz39N4JQwKnLfo
EcF6Zg0DKLva4kSMYVlQvM1zIrVfoMAPSp/FJmJ/OfaoiD2QKcY=
=5Y+m
-----END PGP SIGNATURE-----

--w4KvihVyElQWKJWi--