Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 20 Aug 2025 17:11:05 +0900
From: Michael Paquier <michael@paquier.xyz>
To: =?iso-8859-1?Q?=C1lvaro?= Herrera <alvherre@kurilemu.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move SQL-callable code related to multixacts into its own
 file
Message-ID: <aKWDGckk3K2ftiPw@paquier.xyz>
References: <476683.1755560289@sss.pgh.pa.us>
 <202508191031.5ipojyuaswzt@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="9jzMqBjOOfq96lwD"
Content-Disposition: inline
In-Reply-To: <202508191031.5ipojyuaswzt@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/aKWDGckk3K2ftiPw%40paquier.xyz>
Precedence: bulk


--9jzMqBjOOfq96lwD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Aug 19, 2025 at 12:31:14PM +0200, Alvaro Herrera wrote:
> Hmm, don't you find strange that dbcommands.h is still included there?
> I wondered about that and found out that we have get_database_name()
> declared there.  It sort-of makes sense, because it was originally done
> by scanning pg_database, but since commit cb98e6fb8fd4 introduced a
> syscache for it, we can have this routine in lsyscache.c/h instead,
> where it feels more at home.  It also seems more sensible to declare
> get_database_oid() in pg_database.h.  After these two changes, a lot of
> files can stop including dbcommands.h.  This seems a nice cleanup to me,
> and passes headerscheck.
>
>  33 files changed, 39 insertions(+), 56 deletions(-)

Indeed, that's a nice located cleanup.
--
Michael

--9jzMqBjOOfq96lwD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmilgxkACgkQnvQgOdby
QH2qrQ/9GoKF08gOmue3dTEbIa6Rt1QbiYDkwiLhrLUYJqyXxJavFYuHEyfoZ7FP
G/GYrvaayjvOAc68ywA1plNTwJscBX+/wnWXzaQU1EriqFchaoLbomDR6Tmxbcbd
vIVuYYp5S5OKkg1hjd1+CCtCL1tdmnctbTDSKxEppvFM8EAA/RX9byfqyKHAjmJN
tb5ePUndVwQ5U1/z7SR9UgR38BJBOUJYSeCGky4MQcl9cv3SNCCF89VNwR6DD47l
yTK0ZV67vZNiO4T5CNcYpLkK6SegdANSJwJ5NXuo4JYIMYt+R0sy18Jpdtiqh74h
yOyAGidrnBcXw4c5mSgQvVTkNRkY6xyXrBadsD7hJSeQxnKgke/CPWkJUytW2lyw
bC87wZeoNnoReaU0WP4MhgDFvEvwPU9O9HSvqvLUUY5aiicyaio4YipI0CXq295h
tyh6Okh79GpoyzfAVXzaTMFSRSYCNn/Tok8RfhqJcn0QgMMci6qtjd1bBrUd9sGu
xJve6K38qV5cx1A+bOGPdEfVPudRMrkdp+tWPtF+2yxZ5iTWcNdjuVM0yjUZvL2B
6eWXadX/hwTKKKRwroVgN70Ytl5KIAfbVGkZLotSoqIGp7KhWa2wsc1/C9RVUezU
IFkYxRc34/IZes27FILGg0WoXchU/voYcn/ZJ6zyeiu8XHvz17E=
=YSg5
-----END PGP SIGNATURE-----

--9jzMqBjOOfq96lwD--