Date: Fri, 14 Nov 2025 09:49:02 -0500
From: Bruce Momjian <bruce@momjian.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: doc:  remove verbiage about "receiving" data from rep.
 slots
Message-ID: <aRdBXmI7lmLkEaDf@momjian.us>
References: <E1vJuHW-006ZaM-2j@gemulon.postgresql.org>
 <gwo2ql4qlydwkmsurbz3gflnom5nq2p4wbbrz4xium7g75nnfp@4yohqyq5ijx5>
 <53n63x724ahx2nwx42bmivjlt67fpbyh44knx7jazodsqcs5av@umzjyyg3clpq>
 <aRc40Suvuda74Hmx@momjian.us>
 <pexmenhqptw5h4ma4qasz3cvjtynivxprqifgghdjtmkxdig2g@djg7bk2p6pts>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="hbCB490QvwoTBhRH"
Content-Disposition: inline
In-Reply-To: <pexmenhqptw5h4ma4qasz3cvjtynivxprqifgghdjtmkxdig2g@djg7bk2p6pts>
Archived-At: 
 <https://www.postgresql.org/message-id/aRdBXmI7lmLkEaDf%40momjian.us>
Precedence: bulk


--hbCB490QvwoTBhRH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Nov 14, 2025 at 09:25:20AM -0500, Andres Freund wrote:
> Hi,
> 
> On 2025-11-14 09:12:33 -0500, Bruce Momjian wrote:
> > On Fri, Nov 14, 2025 at 09:05:07AM -0500, Andres Freund wrote:
> > > Hi,
> > > 
> > > On 2025-11-14 09:02:12 -0500, Andres Freund wrote:
> > > > On 2025-11-14 13:56:06 +0000, Bruce Momjian wrote:
> > > > > doc:  remove verbiage about "receiving" data from rep. slots
> > > > > 
> > > > > The slots are just LSN markers, not something to receive from.
> > > > 
> > > > I think this is wrong. Logical slots also preserve resources other than WAL.
> > > 
> > > I also think that the complaint about slots not being something to receive
> > > from is simply wrong for logical slots.
> > 
> > Uh, can you clarify since I can't find details on what they preserve.
> 
> Slots (physical ones can, logical ones always do), prevent row cleanup on the
> primary.

I see your point.  How is the attached patch?  The link right after the
modified text talks only about WAL retention, so I think we need
something in this sentence to say we do more than WAL retention for
logical replication slots.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.

--hbCB490QvwoTBhRH
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="slot.diff"

diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml
index 8a9674bd6d1..aa013f348d4 100644
--- a/doc/src/sgml/logical-replication.sgml
+++ b/doc/src/sgml/logical-replication.sgml
@@ -225,8 +225,9 @@
   </para>
 
   <para>
-   By default a new subscription creates a logical replication slot on the
-   publisher and then uses this slot to preserve necessary WAL (see <xref
+   By default a new subscription creates a logical replication slot on
+   the publisher and then uses this slot to track relevant transaction
+   activity and preserve necessary WAL (see <xref
    linkend="streaming-replication-slots"/>).  Additional replication
    slots may be required for the initial data synchronization of
    pre-existing table data and those will be dropped at the end of data

--hbCB490QvwoTBhRH--