Date: Tue, 25 Nov 2025 15:16:00 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Teach DSM registry to ERROR if attaching to an
 uninitialized ent
Message-ID: <aSYckI8dlAx23HBe@nathan>
References: <aSIR4Z4U887f_KcQ@nathan>
 <aSSlqWwLVuXMmN-o@nathan>
 <aSSr6j3JzeLcqOWo@nathan>
 <CA+TgmoYq7U0hHgOEOqQgf=6cFXz_7Ab8QTRMFqFpLNfav0G4Ug@mail.gmail.com>
 <aSTNXyXnr9HYsLo6@nathan>
 <CA+Tgmob6knHwEbQv11n_Yy0GyFzPgjhC33LroWso0prt7hCksg@mail.gmail.com>
 <aSXQOAZuA4rX9ooU@nathan>
 <CA+TgmobGYDczmVa-UDGPgcyN=63PJzzyQ9ZCofou4VYH8TVLSQ@mail.gmail.com>
 <aSXrPqV3Bcm2HLV4@nathan>
 <CA+Tgmob=uQymuQuWfsnk3ixe6BEURK1Fjm-0WUy7E5YVsWoNHA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="kUugHEtL9xji53W5"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+Tgmob=uQymuQuWfsnk3ixe6BEURK1Fjm-0WUy7E5YVsWoNHA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aSYckI8dlAx23HBe%40nathan>
Precedence: bulk


--kUugHEtL9xji53W5
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Tue, Nov 25, 2025 at 03:58:47PM -0500, Robert Haas wrote:
> On Tue, Nov 25, 2025 at 12:45 PM Nathan Bossart
> <nathandbossart@gmail.com> wrote:
>> I gave your idea a try, and I like the result a lot.  IMHO it makes the
>> code much easier to reason about.
> 
> I looked through this and I agree this looks good. Thanks for working on it.

My tests seem happy, so I will plan on committing these patches tomorrow.
The only difference in v4 is that pg_get_dsm_registry_allocations() will no
longer show partially-initialized entries.  I thought that was the best
option in this case because such entries shouldn't have any allocated
memory, and retrying GetNamed*() would set *found to false.

-- 
nathan

--kUugHEtL9xji53W5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename=v4-0001-Revert-Teach-DSM-registry-to-ERROR-if-attaching-t.patch