Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 8 Dec 2025 17:41:14 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>,
	pgsql-committers@lists.postgresql.org,
	Sami Imseih <samimseih@gmail.com>
Subject: Re: pgsql: injection_points: Remove portions related to custom
 pgstats
Message-ID: <aTaPKpYufxut5Zs1@paquier.xyz>
References: <E1vSSCn-003N0Z-2i@gemulon.postgresql.org>
 <2899652.1765167313@sss.pgh.pa.us>
 <aTZZzFhQTtUKWGLm@paquier.xyz>
 <2904427.1765169854@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="boNPUi4HZOQfCUyK"
Content-Disposition: inline
In-Reply-To: <2904427.1765169854@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/aTaPKpYufxut5Zs1%40paquier.xyz>
Precedence: bulk


--boNPUi4HZOQfCUyK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Dec 07, 2025 at 11:57:34PM -0500, Tom Lane wrote:
> Nah, hold off till we have a discussion about whether the test is
> correct to expect compatibility.  We can afford to have a couple
> of BF animals unhappy for a day or two while we come to a decision.

By the way, while looking at the buildfarm failures, I have noticed
that something is wrong in my patch.  Looking Makefile.global.in,
USE_MODULE_DB is built based on REGRESS for the tests of
src/test/modules/gin/.  However things are inconsistent between meson
and ./configure.

For example, this host uses configure/make:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dskimmer&dt=3D2025=
-12-08%2006%3A08%3A23

The database name is contrib_regression_gin_incomplete_splits, which
points to the test gin_incomplete_split in src/test/modules/gin/,
meaning that my patch would not work.

In the meson case, we got this failure:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dcrake&dt=3D2025-1=
2-08%2006%3A27%3A04
And here, the database name is regression_gin.

When I looked at the buildfarm failures, I saw the regression_gin
first, wrote a patch based on that.  But the second one based on
contrib_regression_gin_incomplete_splits was really puzzling me, until
I've noticed that the difference was configure vs meson for the two
hosts.  So it seems to me that we have a second issue here, where
meson relies on a "name" while configure uses the first value of
"REGRESS".  AdjustUpgrade.pm cannot know that it's dealing with one
build method or the other.  In order to make my previous patch work,=20
we could use a DROP DATABASE IF EXISTS on both database names.  That
would work, but that feels grotty for the purpose of fixing things,
especially as I don't see a point in keeping the test libraries across
major upgrades..
--
Michael

--boNPUi4HZOQfCUyK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmk2jyoACgkQnvQgOdby
QH0H7BAAkllYri/Px2r0thk03gT0XZqiFlxPP2aRwqagbmN2tr8IsnPURNM+JH15
eXsJHAetKX9DA7uauw6/5qGaqMzJGlu7hvH0LKAVCTxsnItqhecRTsgW6N2Ztqgb
S+mhTzUiXrBYVvd774ydRn6deYuL4g9Izhzt/P+H5Ybh0V54sf7Pt6d9BPMGP5g8
4O36wpzX2TwP7dTMvqehlK3edJOK2b2E/nfapPy624/2U1bRS0QDYsLc0CqHaXe5
ckM80gz0vMVBKFb5BO02J/rO4sriqmFHL8B9+PTXwQGt3FflP2/3IHNgOejSFH4X
StDIJZYj7POKXNsNeO46KWKVyOGbuWUyCjN8yCcDKIwRIhSTAoDFlMoPKLHAcvWd
ltUDzl1usVLAcs7axCaq1uanBz6DC+icohi2oiCKuvXqiuTMva+jJniW6656poIT
SeXsFC8d/5XqhW0zt2MmgZi9/ZrYX3TEHyBRDJFatFsH6WhPuda4X3f+tq+DTBYn
ixFM2yXUBc9Our+bvD+JSgaOTonG+/y98m1adAJWDf4e5cBGOODS4/pmfx86Bnnx
oCe7SjDtFB8LmxeQUrbTUW8IHWb2WhFCjPZPZrzafiBPs7i0ivM349lYpXD2COB6
yKZ9xQFiiVl+uJKSQS289SRDJCzHTpPFrCqFwrORBznIilftX9o=
=bVp6
-----END PGP SIGNATURE-----

--boNPUi4HZOQfCUyK--