Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 10 Dec 2025 08:43:10 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>,
	pgsql-committers@lists.postgresql.org,
	Sami Imseih <samimseih@gmail.com>
Subject: Re: pgsql: injection_points: Remove portions related to custom
 pgstats
Message-ID: <aTi0Dn_JgQml57Kh@paquier.xyz>
References: <aTZZzFhQTtUKWGLm@paquier.xyz>
 <2904427.1765169854@sss.pgh.pa.us>
 <aTaPKpYufxut5Zs1@paquier.xyz>
 <d92f0eca-bb14-4b8c-9fb0-3b79635e1a64@iki.fi>
 <251242.1765302019@sss.pgh.pa.us>
 <ebfa8b0a-5858-4167-884c-499e70fce2cd@iki.fi>
 <aTimAYvtXnFojBaY@paquier.xyz>
 <302444.1765320564@sss.pgh.pa.us>
 <aTipJA1Y1zVSmH3H@paquier.xyz>
 <29e38dd3-0c48-4e65-b498-a78c5ce0ca9a@iki.fi>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="NOeWm3Ij7rh0atCk"
Content-Disposition: inline
In-Reply-To: <29e38dd3-0c48-4e65-b498-a78c5ce0ca9a@iki.fi>
Archived-At: 
 <https://www.postgresql.org/message-id/aTi0Dn_JgQml57Kh%40paquier.xyz>
Precedence: bulk


--NOeWm3Ij7rh0atCk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 10, 2025 at 01:04:31AM +0200, Heikki Linnakangas wrote:
> Yes please. I'm also happy to help if you'd like. I'm eagerly waiting to =
see
> if the "Widen MultiXactOffset to 64 bits" commit caused any new
> cross-version pg_ugprade test failures.

Okay, I'll see about doing something.

By the way, there is also a consequence in using the first test name
in the REGRESS list for the database name: we cannot use the same name
for the "setup" phase of all these test modules, or the gin, typcache
and nbtree modules would conflict with each other because they would
use the same database name.

By the way, it seems to me that even under meson the two nbtree tests
do not compete with each other: they are executed in a serialized
fashion.  Parallel mode can be enforced with a schedule, but it's just
to say that a DROP EXTENSION in each SQL file should work as well.

>> By the way, REGRESS in modules/nbtree/Makefile is missing
>> nbtree_half_dead_pages..  meson.build has both tests.
>=20
> That one is on me..

I am not going to touch this line, but I don't mind doing something
about it as I am touching the same area.  Another thing: the nbtree
module is missing a .gitignore.
--
Michael

--NOeWm3Ij7rh0atCk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmk4tA4ACgkQnvQgOdby
QH0Htg/6AxNkc0schH36mX+e0eGblxIin/Ea7iLS/pjJSGRFF3uR0Fm6hVuECJXR
S3sihsDfya/y/Nk+88xjYn18jestiyyj7aA1nxhYqa5dCGpTdN7NpofFmprBn4B5
tjiNc1MVs3odrHTMRdAb6VWfZmpsoyujyXCJFZGfHKrM1ItaiYkBv/MwTC90sOJe
RcIY3JNsgkfWhFS/84QIlCFCZyyH4LgTh+D42NszQOf+NrG8/7gVji1tTOWP7BaW
f1XQn45sCjz9oOCzMfhRuEgQDZlhfZgppU08klDzF/ZldmuY1a15tvXM9LbGUb37
gMo7lxrHpifXvhXViPTVGbVJw6pY+5sDluz41sq5iH38gJu4u7sY7BaE5/DQEj/+
YfQXH+vnicyGzJPahsfAh+OljjY8e3bHj/oYCOoY7x83wScGekJ+jhVGefIV2Jg9
4OOR4lTikWSyB5ya21q11w6XVmQZ4ZrkzgYfrO5pCHkPAftyygTiX5VYwt9f5moI
zflOavCrjl079GgiWljjuw6Mibg+CzryLlWDjDOO9E1/EzMUOu9wEdN02LKnkAa2
hdUqcJfRvOEDr6WiGsPz+pzdHNujJYFPZpe2LKcZldgkJ5KvwArEcVztRJAg+dri
hkAcixm8/X0rOG4z3jqZE1TQkvqZ1Cr1q/4leMlFDjLWSTfN+Us=
=TrJt
-----END PGP SIGNATURE-----

--NOeWm3Ij7rh0atCk--