Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 10 Dec 2025 07:43:13 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>,
	pgsql-committers@lists.postgresql.org,
	Sami Imseih <samimseih@gmail.com>
Subject: Re: pgsql: injection_points: Remove portions related to custom
 pgstats
Message-ID: <aTimAYvtXnFojBaY@paquier.xyz>
References: <E1vSSCn-003N0Z-2i@gemulon.postgresql.org>
 <2899652.1765167313@sss.pgh.pa.us>
 <aTZZzFhQTtUKWGLm@paquier.xyz>
 <2904427.1765169854@sss.pgh.pa.us>
 <aTaPKpYufxut5Zs1@paquier.xyz>
 <d92f0eca-bb14-4b8c-9fb0-3b79635e1a64@iki.fi>
 <251242.1765302019@sss.pgh.pa.us>
 <ebfa8b0a-5858-4167-884c-499e70fce2cd@iki.fi>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="fL2SJEzt8kcOBoCt"
Content-Disposition: inline
In-Reply-To: <ebfa8b0a-5858-4167-884c-499e70fce2cd@iki.fi>
Archived-At: 
 <https://www.postgresql.org/message-id/aTimAYvtXnFojBaY%40paquier.xyz>
Precedence: bulk


--fL2SJEzt8kcOBoCt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 09, 2025 at 10:04:43PM +0200, Heikki Linnakangas wrote:
> It's a little tricky if a module has more than one test that uses the
> extension. Namely src/test/modules/nbtree which I added recently has two
> test scripts, nbtree_incomplete_splits.sql and nbtree_half_dead_pages.sql,
> and both of them do "create extension if not exists injection_points;". T=
hey
> run concurrently, so they race on which one creates the extension first. =
We
> can't do the same for DROP EXTENSION at the end.
>=20
> Maybe that's not a great design in the first place, though. Perhaps that
> module should use a schedule file:
>=20
> # create injection_points extension before the actual tests
> test: test_setup
>=20
> test: nbtree_incomplete_splits nbtree_half_dead_pages
>=20
> # drop injection_points extension because it cannot be pg_upgraded.
> test: test_clean

Are the dumps of the old versions used in the buildfarm runs updated
with each run?  If yes, forcing a DROP EXTENSION in the problematic
test modules has my favors over the dirtier tricks that would be
required in AdjustUpgrade for the various database name patterns that
depend on the build method.  If no, well, AdjustUpgrade it is with
some DROP DATABASE IF EXISTS.
--
Michael

--fL2SJEzt8kcOBoCt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmk4pgEACgkQnvQgOdby
QH1PkBAAm95KB/tiXT7pNEJAhViuiPaEglLC3aBB0KkGXAW6REI+uHb6tIL2wbTt
ZzFyn6y6UkZTdFDOeDZIOTF/OdmKza94pRbssOmuL9UG5Z8MhiQZ0X/t0+ZrQfrN
oYBLwoNkm/aPA5b4Hco/ret+JX9z7niocZRzZVNgxph5JuH3RrO8nfVivuWrrfzq
RHkfl7lPpB7c6In0ZPlYw/XXXeN7ev5BJP8kdZwPJUOGTyJ5vpa6aZjTWD30ptIB
qTZ+cpXMLS9kx9hmNsjXjKybxoAl0Zg8R8+mUp5QLMmWlqzQG96XJJp9J3XKHW0I
yxkW4+w4Y/ECd1p2tTUbcy+c8mSdvE7L6QMe2BBizePNHc8dMQzebjKi0YAQ+SOS
7oFdgQ+c84x1XdjRF+5J4CtGq9tHUwQaQpao7QoAFa7tLoAS3yPj6bCC9m6KoY8+
01GrN2R2l9AiVPYINOHdoCRkzBBlL0JrNKlgjW5LLleBDu1QhWwPuMb4ZmkshMVF
jPLiClRKmTtiGyBIyS6FhbRkq9LOUj+nvV2RLj3kgFeAybca7baL+/WvL3DwkjJw
8A6gOAPUl/HbY0y2cYCePRh69YP4WvBO4P4lupgT2Rfce5B+e/oKn+ODUhS5qZkg
gGANxGKc14JJ2GHUyv2J9Xwrq4M+IUDaN4Cgnp/puymeMt/lwvw=
=g+PY
-----END PGP SIGNATURE-----

--fL2SJEzt8kcOBoCt--