Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 5 Jan 2026 09:49:26 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove unneeded defines from pg_config.h.in
Message-ID: <aVsKluvcsYTIoMG4@paquier.xyz>
References: <E1vcYUU-004XVb-1O@gemulon.postgresql.org>
 <1193764.1767573683@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ED4UCdgngc9fLW4x"
Content-Disposition: inline
In-Reply-To: <1193764.1767573683@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/aVsKluvcsYTIoMG4%40paquier.xyz>
Precedence: bulk


--ED4UCdgngc9fLW4x
Content-Type: multipart/mixed; boundary="QSOmyykla7Ta2aZv"
Content-Disposition: inline


--QSOmyykla7Ta2aZv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 04, 2026 at 07:41:23PM -0500, Tom Lane wrote:
> This patch is not okay.  pg_config.h.in is a generated file and
> hand modifications in it will not do.
>=20
> If we don't need these symbols anymore, the right fix is to remove
> the probes for these headers in the autoconf and meson scripts.

Oops, sorry for the brain fart.  How about the attached?  autoreconf
and autoheader seem to be OK with it.
--
Michael

--QSOmyykla7Ta2aZv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="fix_autoconf.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/configure b/configure
index 78597c6229a2..02e4ec7890f1 100755
--- a/configure
+++ b/configure
@@ -13669,7 +13669,7 @@ fi
 ## Header files
 ##
=20
-for ac_header in atomic.h copyfile.h execinfo.h getopt.h ifaddrs.h mbarrie=
r.h sys/epoll.h sys/event.h sys/personality.h sys/prctl.h sys/procctl.h sys=
/signalfd.h sys/ucred.h termios.h uchar.h ucred.h xlocale.h
+for ac_header in copyfile.h execinfo.h getopt.h ifaddrs.h sys/epoll.h sys/=
event.h sys/personality.h sys/prctl.h sys/procctl.h sys/signalfd.h sys/ucre=
d.h termios.h uchar.h ucred.h xlocale.h
 do :
   as_ac_Header=3D`$as_echo "ac_cv_header_$ac_header" | $as_tr_sh`
 ac_fn_c_check_header_mongrel "$LINENO" "$ac_header" "$as_ac_Header" "$ac_i=
ncludes_default"
diff --git a/configure.ac b/configure.ac
index 2ccf410f94c5..b90a220a6358 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1501,12 +1501,10 @@ AC_SUBST(UUID_LIBS)
 ##
=20
 AC_CHECK_HEADERS(m4_normalize([
-	atomic.h
 	copyfile.h
 	execinfo.h
 	getopt.h
 	ifaddrs.h
-	mbarrier.h
 	sys/epoll.h
 	sys/event.h
 	sys/personality.h
diff --git a/meson.build b/meson.build
index 467f7f005a6a..c3834a9dc8fa 100644
--- a/meson.build
+++ b/meson.build
@@ -2626,13 +2626,11 @@ endif
 # XXX: Might be worth conditioning some checks on the OS, to avoid doing
 # unnecessary checks over and over, particularly on windows.
 header_checks =3D [
-  'atomic.h',
   'copyfile.h',
   'crtdefs.h',
   'execinfo.h',
   'getopt.h',
   'ifaddrs.h',
-  'mbarrier.h',
   'strings.h',
   'sys/epoll.h',
   'sys/event.h',

--QSOmyykla7Ta2aZv--

--ED4UCdgngc9fLW4x
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmlbCpYACgkQnvQgOdby
QH1HmxAAlEbFGCJaVFjklfBRwr/J0Yk1fA45j37Magesn1l1dio8RUPcTLc572Wh
mkTGV6p9KYxr2bnYYDz8x3g/TTzIAdvwmWGjA1UKzoIUF026q2nGFMpvROeqfclY
jOuExJ5TxiG+gUcxEtWUk+rEdvhq5m0BZPa2L+pfKiZALuAmaM9GeJyf4kX+l0Xk
th/lfXzfpyK4RjgLhESZI62Mp5fCAJOefUnOyGZxWY4ggDnhdaP1F3LJS71q5eNg
2ktsesTwpK5hCC2zmNmt4fZwraVA+8pdCph6B8V2Vzxx4Jek8sf35xDQ/KM29rbK
16inG8ZFTVu1p5u0H701qc81UH+2XhdctxJSgyC3y714RyaOamKOx/gM9+rUTBNE
p8s12K7ZrN+bzm3hAZA6+GQhRQv4SGXShp3/BS7q1n/hkFMCsoV2KGclZ3NKhJrS
0i/fbotu0nr5RYdwYSck9VnIIlB/P2WW6Ba8Mr+o/dl+6xw5n4MeN4ZxGhdwMQdR
IMagA3w9kvplYA/aSq4g3+4UJRQL7BakXdRWmkzw1o3VQS+S9ravQ2lIweLgqydY
BYU6rKoxgJRiEqzleU2ywJQOHk4sgCYk+Lll6X/vMhv/DU9pvx4oYH7fKx41ee/w
WcDdizd6l70NQ/4WMj1vE8M0Fv0n077uE3M5VC+O3RXyPQchOmU=
=TAG4
-----END PGP SIGNATURE-----

--ED4UCdgngc9fLW4x--