Date: Thu, 12 Feb 2026 17:23:49 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: =?iso-8859-1?Q?=C1lvaro?= Herrera <alvherre@kurilemu.de>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Tomas Vondra <tomas@vondra.me>,
	Christoph Berg <myon@debian.org>,
	Andres Freund <andres@anarazel.de>,
	Tomas Vondra <tomas.vondra@postgresql.org>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Introduce pg_shmem_allocations_numa view
Message-ID: <aY4MpVrK++9oXvti@ip-10-97-1-34.eu-west-3.compute.internal>
References: <21cc7a48-99d9-4f69-9a3f-2c2de61ac8e5@iki.fi>
 <202602121635.kdy5xdbvxaqi@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202602121635.kdy5xdbvxaqi@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/aY4MpVrK%2B%2B9oXvti%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk

Hi,

On Thu, Feb 12, 2026 at 05:43:47PM +0100, Álvaro Herrera wrote:
> On 2026-Feb-12, Heikki Linnakangas wrote:
> 
> > I just noticed that this (commit bf1119d74a: Add CHECK_FOR_INTERRUPTS into
> > pg_numa_query_pages) made the function unusable in frontend programs,
> > because CHECK_FOR_INTERRUPTS is server only.

Good catch! Out of curiosity how did you find the issue? Were you building a
client tool making used of pg_numa_query_pages()?

> It's not used in frontend
> > programs today, but it was placed in src/port/ with the idea that it could
> > be.
> 
> Your patch LGTM.

+1

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com