pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: PGPROC alignment (was Re: pgsql: Separate RecoveryConflictReasons from procsignals)
Date: Sat, 21 Feb 2026 09:42:13 +0000
Message-ID: <aZl99TEvMeckGcO6@ip-10-97-1-34.eu-west-3.compute.internal> (raw)
In-Reply-To: <60478a2d-915e-411d-9f7d-42917dd8b8c4@iki.fi>
References: <aYtcMg5hMdGdhX4q@alap3.anarazel.de>
	<1cb0d7e9-d6dd-4517-a7cd-0ad98e1207f3@iki.fi>
	<aYtsrQ-kmA8nqeiH@alap3.anarazel.de>
	<aYuDz2kvi7haNORb@ip-10-97-1-34.eu-west-3.compute.internal>
	<aYuIrKbh1kW36xbc@alap3.anarazel.de>
	<3dd6f70c-b94d-4428-8e75-74a7136396be@iki.fi>
	<aYwISFVCAJon5ZxT@ip-10-97-1-34.eu-west-3.compute.internal>
	<787be980-0878-4f4a-be01-d042ab5d370e@iki.fi>
	<aY7auF2/xuT58vRI@ip-10-97-1-34.eu-west-3.compute.internal>
	<60478a2d-915e-411d-9f7d-42917dd8b8c4@iki.fi>

Hi,

On Fri, Feb 20, 2026 at 11:03:09PM +0200, Heikki Linnakangas wrote:
> On 11/02/2026 06:40, Bertrand Drouvot wrote:
> > That looks ok to see PGPROC as an "acceptable" one, if not, should we use the
> > union trick?
> 
> It seems acceptable to just not align it if the compiler doesn't support it.
> This is just a performance optimization, after all.

Agreed.

> Attached is new versions the remaining patches. I think these are ready to
> be committed.

Thanks!

One nit, 0001 is adding the typedef:

"
-struct PGPROC
+typedef struct PGPROC
.
.
.
-};
-
-/* NOTE: "typedef struct PGPROC PGPROC" appears in storage/lock.h. */
+       uint32          wait_event_info;        /* proc's wait information */
+} PGPROC;
"

Would that make more sense to add the typedef when we introduce the explicit
alignment in 0002 (like it was done in your previous
v2-0001-Align-PGPROC-to-cache-line-boundary.patch up-thread)?

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com





view thread (18+ messages)  latest in thread

Message-ID: <aZl99TEvMeckGcO6@ip-10-97-1-34.eu-west-3.compute.internal>
Permalink:  ../aZl99TEvMeckGcO6@ip-10-97-1-34.eu-west-3.compute.internal/
Also on:    postgresql.org/message-id/aZl99TEvMeckGcO6@ip-10-97-1-34.eu-west-3.compute.internal

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: bertranddrouvot.pg@gmail.com, hlinnaka@iki.fi, andres@anarazel.de, pgsql-hackers@postgresql.org
  Subject: Re: PGPROC alignment (was Re: pgsql: Separate RecoveryConflictReasons from procsignals)
  In-Reply-To: <aZl99TEvMeckGcO6@ip-10-97-1-34.eu-west-3.compute.internal>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox