Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 5 Mar 2026 07:47:03 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jacob Champion <jacob.champion@enterprisedb.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
	Mark Wong <markwkm@gmail.com>
Subject: Re: pgsql: Change default value of default_toast_compression to
 "lz4", when
Message-ID: <aai2Z0UQkkHqvSuQ@paquier.xyz>
References: <E1vxdV4-002Hkq-1Y@gemulon.postgresql.org>
 <CAOYmi+meTT0NbLbnVqOJD5OKwCtHL86PQ+RZZTrn6umfmHyWaw@mail.gmail.com>
 <1669305.1772663689@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="eLkZ9E/K1F4AsboD"
Content-Disposition: inline
In-Reply-To: <1669305.1772663689@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/aai2Z0UQkkHqvSuQ%40paquier.xyz>
Precedence: bulk


--eLkZ9E/K1F4AsboD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 04, 2026 at 05:34:49PM -0500, Tom Lane wrote:
> By my count, two-thirds of the buildfarm is broken.  (100 failing
> animals, 56 working ones have reported since this commit.)
>=20
> We would not normally tolerate leaving things that way for any
> great length of time, and I don't think this commit should get
> a pass.  I think it needs to be reverted until a very much
> larger fraction of buildfarm owners have prepared for it.

Hmm.  If you guys feel strongly about it, I'd be OK to revert.  Now
there is a way to split the pie into two halves: we can still
introduce DEFAULT_TOAST_COMPRESSION and use lz4 as default for the GUC
if lz4 is included in the build but, leave the switch of --with-lz4 to
--without-lz4 out of the equation.  This choice would leave the
buildfarm in piece, and it still achieves the goal of enabling LZ4 in
TOAST by default, as long as --without-lz4 is used.  As long as the
latter is achieved, the point of the change would be made.

Opinions?
--
Michael

--eLkZ9E/K1F4AsboD
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmotmcACgkQnvQgOdby
QH2DTg/+KASjqkIw/Jdi5ILzEjzFXHL+NdiBBloc3iaimioifnJNaaXFar/W9I4e
wohIkj9BzELGAniiaHqOKaTDipiIgo83XQi+nHL+qFnkSJu2/eFN08TAzqD8rkus
TozI3cWoDUgCG9TxfvXeuNUeb/oQnYsvevplV+cD+X1CDol6DH2CSwmJK8zSbI6B
fQ8c1cl1fy8zjV3RYs8pBL83yPwTXotG6w7vXiLV/szqhSxl69CmmbWZIgj6Gi1N
9lZ6g5xD1oVDNSArrCRTcJ1EHwZTIfPOKHBbJuFHdabc/d+bGpVXdjM+7fKkcHfR
jiDhy3fkqZwywyaNO3IkVUrwYvvqbun4Iv4VM/tC0BL8bQ6Fvo5LKO34HBFNRSU3
EJ6DEPIOk6uwNthM49hw/byw7kNzr2erHWKjYpjcwAn9v+tgMd1AkHPdAX5GoqC/
TT/MeMbufOspu9ltgVbF4JcJ60X1V44OV7EEzzMalKVvnBJoLwr4nO3iVxV5rExq
RfsfVFgVtUE5XpRHZteBUgiOs6jZTloo+UJqfl5slhnA1+WksaDjV45Jx0iSq5Ek
FANW4OTcQFcQW+GPAlGDJ+gqjy2Dz6UI4Sz5fYDCbfzVA6R9J+ozcu6AMqZpqXkp
NbJ8aHgqnje3dH8kh45IyRQZb1Fits5RYuAh4ayB8uWuheEtWOI=
=0L92
-----END PGP SIGNATURE-----

--eLkZ9E/K1F4AsboD--