Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 5 Mar 2026 07:51:26 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jacob Champion <jacob.champion@enterprisedb.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
	Mark Wong <markwkm@gmail.com>
Subject: Re: pgsql: Change default value of default_toast_compression to
 "lz4", when
Message-ID: <aai3bl7CbkSpjz0H@paquier.xyz>
References: <E1vxdV4-002Hkq-1Y@gemulon.postgresql.org>
 <CAOYmi+meTT0NbLbnVqOJD5OKwCtHL86PQ+RZZTrn6umfmHyWaw@mail.gmail.com>
 <1669305.1772663689@sss.pgh.pa.us>
 <aai2Z0UQkkHqvSuQ@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="64+5Pr4zroGYxSIR"
Content-Disposition: inline
In-Reply-To: <aai2Z0UQkkHqvSuQ@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/aai3bl7CbkSpjz0H%40paquier.xyz>
Precedence: bulk


--64+5Pr4zroGYxSIR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 05, 2026 at 07:47:03AM +0900, Michael Paquier wrote:
> Hmm.  If you guys feel strongly about it, I'd be OK to revert.  Now
> there is a way to split the pie into two halves: we can still
> introduce DEFAULT_TOAST_COMPRESSION and use lz4 as default for the GUC
> if lz4 is included in the build but, leave the switch of --with-lz4 to
> --without-lz4 out of the equation.  This choice would leave the
> buildfarm in piece, and it still achieves the goal of enabling LZ4 in
> TOAST by default, as long as --without-lz4 is used.  As long as the
> latter is achieved, the point of the change would be made.


As I had the idea to press send too quickly, here's a reformulated
version.  ;)

We can still introduce DEFAULT_TOAST_COMPRESSION and use lz4 as
default for the GUC if lz4 is included in the build but leave the
switch of --with-lz4 to --without-lz4 out of the equation.  This
choice would leave the buildfarm in peace, and it still achieves the
goal of enabling LZ4 in TOAST by default, as long as --with-lz4 is
used.  As long as the latter goal is achieved, the point of the change
would be made, at least partially.
--
Michael

--64+5Pr4zroGYxSIR
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmot24ACgkQnvQgOdby
QH0jWQ/9EZa8Qt+A4Nk9IYUSxN/bb1DOP5N0h4F0Xxypxw1EX7maob1yJI63iMPs
XDAmgu7YbWqfmqoFSDqBZeHxQSm9GiSroa+S7URKJzbFFjmu5O1SzwMcQIvcYZDs
ux0WXplOw8VMVcszpSGb5CwWKb8YJUWoAS13Xe97owJTXityJhgTgBHe3L9+DIPv
brwH7PfFKpwjWxGLU64M+jVsF6YW8lYy3qvNF7w/5QwMRASXqJ3nw0z6S4EmHWPR
XJELbaqYBGSbld9OCi4CDpj7NbLPg5bwIPk0EMfi25z73YDk/tbSQgnVXyDXTUnY
dIZRwLMTnjKKthRJEigUxZtlvjp5u75tZQVz9/5VNEr7Q6KSE9BqTa2soQI2ePoS
+wy3WiPK+LGIh3hYK7sz0Q2rl+wc4czBGAt/2g3+3+f2CgC6bvj3JpOpWE1uLZC5
EaL7u05GSmcKt7I8GerOOY6vqZeK5EMF6bPcxgNKrK/KX/V1D7xokKdr6qYu+Fou
gZntR3WdluLHrfSlz9zfi9BDPZPD/lgHVqlJ0v+8HFCS+H5z6mZgE6gwnSWl0Oxj
8MfiB3ATIKhxU3yNN/TZi6Roz25p6Mo3l4n4FkczYqvS0wqQZFIkv3fWXMEsdN7C
AXkJPwTu3sKOw6suWwTugHL83cUzeHCmrEcBDvauoM2yOeKkGHs=
=23NG
-----END PGP SIGNATURE-----

--64+5Pr4zroGYxSIR--