pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Make node output prefix match node structure name
5+ messages / 3 participants
[nested] [flat]
* pgsql: Make node output prefix match node structure name
@ 2021-09-15 15:19 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 1 reply; 5+ messages in thread
From: Peter Eisentraut @ 2021-09-15 15:19 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Make node output prefix match node structure name
In most cases, the prefix string in a node output is the upper case of
the node structure name, e.g., MergeAppend -> MERGEAPPEND. There were
a few exceptions that for either no apparent reason or perhaps minor
aesthetic reasons deviated from this. In order to simplify this and
perhaps allow automatic generation without having to deal with
exception cases, make them all match.
Discussion: https://www.postgresql.org/message-id/c091e5cd-45f8-69ee-6a9b-de86912cc7e7@enterprisedb.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e58136069687b9cf29c27281e227ac397d72141d
Modified Files
--------------
src/backend/nodes/outfuncs.c | 22 +++++++++++-----------
src/backend/nodes/readfuncs.c | 22 +++++++++++-----------
2 files changed, 22 insertions(+), 22 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: Make node output prefix match node structure name
@ 2021-09-15 15:30 Tom Lane <tgl@sss.pgh.pa.us>
parent: Peter Eisentraut <peter@eisentraut.org>
0 siblings, 1 reply; 5+ messages in thread
From: Tom Lane @ 2021-09-15 15:30 UTC (permalink / raw)
To: Peter Eisentraut <peter@eisentraut.org>; +Cc: pgsql-committers@lists.postgresql.org
Peter Eisentraut <peter@eisentraut.org> writes:
> Make node output prefix match node structure name
Just for the record, this should have included a catversion bump,
since it surely broke stored rules.
regards, tom lane
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: Make node output prefix match node structure name
@ 2021-10-05 12:42 Vik Fearing <vik@postgresfriends.org>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 5+ messages in thread
From: Vik Fearing @ 2021-10-05 12:42 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; Peter Eisentraut <peter@eisentraut.org>; +Cc: pgsql-committers@lists.postgresql.org
On 9/15/21 5:30 PM, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> Make node output prefix match node structure name
>
> Just for the record, this should have included a catversion bump,
> since it surely broke stored rules.
It did. I just ran into a problem cause by the lack of catversion bump.
I am hoping something gets committed soon that contains one.
--
Vik Fearing
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Make node output prefix match node structure name
@ 2022-04-12 14:36 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 1 reply; 5+ messages in thread
From: Peter Eisentraut @ 2022-04-12 14:36 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Make node output prefix match node structure name
as done in e58136069687b9cf29c27281e227ac397d72141d
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/51e81794058e78a151368d0b652f3c92602568c0
Modified Files
--------------
src/backend/nodes/outfuncs.c | 2 +-
src/backend/nodes/readfuncs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: Make node output prefix match node structure name
@ 2022-04-12 14:43 Tom Lane <tgl@sss.pgh.pa.us>
parent: Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 5+ messages in thread
From: Tom Lane @ 2022-04-12 14:43 UTC (permalink / raw)
To: Peter Eisentraut <peter@eisentraut.org>; +Cc: pgsql-committers@lists.postgresql.org
Peter Eisentraut <peter@eisentraut.org> writes:
> Make node output prefix match node structure name
Surely this should have included a catversion bump,
because it broke stored rules.
regards, tom lane
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2022-04-12 14:43 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-09-15 15:19 pgsql: Make node output prefix match node structure name Peter Eisentraut <peter@eisentraut.org>
2021-09-15 15:30 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-10-05 12:42 ` Vik Fearing <vik@postgresfriends.org>
2022-04-12 14:36 pgsql: Make node output prefix match node structure name Peter Eisentraut <peter@eisentraut.org>
2022-04-12 14:43 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox