Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s3GyY-00BI8O-EA for pgsql-committers@arkaria.postgresql.org; Sat, 04 May 2024 15:06:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1s3GyV-000SX9-99 for pgsql-committers@arkaria.postgresql.org; Sat, 04 May 2024 15:06:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s3GyU-000SX1-UL for pgsql-committers@lists.postgresql.org; Sat, 04 May 2024 15:06:55 +0000 Received: from meesny.iki.fi ([195.140.195.201]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s3GyQ-001Wqn-H2 for pgsql-committers@lists.postgresql.org; Sat, 04 May 2024 15:06:55 +0000 Received: from [192.168.1.134] (221-243-190-90.dyn.estpak.ee [90.190.243.221]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: hlinnaka) by meesny.iki.fi (Postfix) with ESMTPSA id 4VWrc64JvxzyQL; Sat, 4 May 2024 18:06:46 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1714835208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JVAtyF7rhA7H4UCatU6g9CTEON9gUBqVL+VLKv7PAxI=; b=frdrpTABdfV603zFm5ZeitnJ6W5LiZlu25D+iOhA1Gjiv+k2j2EL3PlvqCGRjMn4GNF+5e T1U6pcwaT+dqVr0S2vJ685SjPb8bRthITW2V03u1jwhU0El701kACqUCvnEeQ8apB6R+jP jnuuWO/CD5wl0KpsXKJ+oPtD1q0OIP4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1714835208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JVAtyF7rhA7H4UCatU6g9CTEON9gUBqVL+VLKv7PAxI=; b=pPMunV8/YusvNH96WHKKBpwx+w1Kjl/xb8WB2j1Ssb4OWDYQzq9ZISaJyXDQUrR5jYpBdX XlokfepVL6q3IMJ3YHtbbLbB2eoL8F2VGa8t9HZkcKQYJKC4eb7WPmm8Lb5deDkdUkvzye Nn+GmATKuwUokn89fQV4mlKUMI6vGlE= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=hlinnaka smtp.mailfrom=hlinnaka@iki.fi ARC-Seal: i=1; s=meesny; d=iki.fi; t=1714835208; a=rsa-sha256; cv=none; b=bRc7gr7LnjGlQf8QNoqGNZLel7jJ0aGmftx4bBIyNS4ho8Wd92/t8hs77QgwF/RXoGh6hC 4/0iiXKt3LTKNde9QkRJdvHN65n3ALsLeeS/DQsofERHRPqKT1AeE4ivWGq6J6gXfqLGM+ IMsVGuirmob94sMb73EPsLj9DkXj1Wo= Message-ID: Date: Sat, 4 May 2024 18:06:45 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pgsql: Fix compilation on OpenSSL 1.0.2 and LibreSSL To: Daniel Gustafsson Cc: Heikki Linnakangas , pgsql-committers@lists.postgresql.org References: <1C71E5C4-46BE-46B7-9884-310B25280B49@yesql.se> <5f162ff7-02f0-42f4-9473-53cfb7393bc3@iki.fi> <5EACEB09-BCBC-432A-A5B0-E8FD73808276@yesql.se> <6f62a93d-3ebb-476f-8ff2-1187c790cd99@iki.fi> <331BA556-4AAD-4B09-B86B-A5947F248E3F@yesql.se> Content-Language: en-US From: Heikki Linnakangas In-Reply-To: <331BA556-4AAD-4B09-B86B-A5947F248E3F@yesql.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 03/05/2024 11:44, Daniel Gustafsson wrote: >> On 2 May 2024, at 12:30, Heikki Linnakangas wrote: >> On 02/05/2024 13:24, Daniel Gustafsson wrote: > >>> This makes targeting 7.0 as the lowest LibreSSL version appealing in my >>> patchset for removing support for old OpenSSL and LibreSSL versions. >> >> Works for me. Although there's little harm in keeping the "#ifdef SSL_AD_NO_APPLICATION_PROTOCOL" either, if that's the only thing missing from 6.9. > > In the meantime I'll apply the below to keep the comment correct and to help > future-me when revisiting SSL library support =) > > - * OpenSSL 1.1.0 and later, but as of this writing not in LibreSSL. > + * OpenSSL 1.1.0 and later, as well as in LibreSSL 3.4.3 (OpenBSD 7.0) and > + * later. > > Any objections to that? Sounds good -- Heikki Linnakangas Neon (https://neon.tech)