Message-ID: <adc3ebc2-0e3a-4983-bec1-637182b60aae@iki.fi>
Date: Tue, 30 Apr 2024 08:19:53 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Reject SSL connection if ALPN is used but there's no
 common prot
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
References: <E1s1Si1-000dPK-6j@gemulon.postgresql.org>
 <1452995.1714433552@sss.pgh.pa.us>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <1452995.1714433552@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/adc3ebc2-0e3a-4983-bec1-637182b60aae%40iki.fi>
Precedence: bulk

On 30/04/2024 02:32, Tom Lane wrote:
> Heikki Linnakangas <heikki.linnakangas@iki.fi> writes:
>> Reject SSL connection if ALPN is used but there's no common protocol
> 
> A moderately large fraction of the buildfarm doesn't seem to
> recognize SSL_AD_NO_APPLICATION_PROTOCOL.

*sigh*. I checked that it exists on OpenSSL 1.1.1, but according to 
buildfarm it's not present on OpenSSL 1.0.2 or LibreSSL. I'll add an 
#ifdef guard. OpenSSL 1.0.2 support is about to be removed from master, 
and, and we can live with a a poor error message on LibreSSL. It's not 
something that users should normally hit.

-- 
Heikki Linnakangas
Neon (https://neon.tech)