Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 21 Apr 2026 08:02:55 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Clean up all relid fields of RestrictInfos during join
 removal.
Message-ID: <aeawnyFl5lwsG2dC@paquier.xyz>
References: <E1wEtfe-001tkg-1d@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="jp/wYgCe/4X/etuk"
Content-Disposition: inline
In-Reply-To: <E1wEtfe-001tkg-1d@gemulon.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/aeawnyFl5lwsG2dC%40paquier.xyz>
Precedence: bulk


--jp/wYgCe/4X/etuk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Tom,

On Mon, Apr 20, 2026 at 06:48:35PM +0000, Tom Lane wrote:
> Clean up all relid fields of RestrictInfos during join removal.
>=20
> The original implementation of remove_rel_from_restrictinfo()
> thought it could skate by with removing no-longer-valid relid
> bits from only the clause_relids and required_relids fields.
> This is quite bogus, although somehow we had not run across a
> counterexample before now.  At minimum, the left_relids and
> right_relids fields need to be fixed because they will be
> examined later by clause_sides_match_join().  But it seems
> pretty foolish not to fix all the relid fields, so do that.

prion looks unhappy on this one:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dprion&dt=3D2026-0=
4-20%2022%3A50%3A01

This uses -DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE.
--
Michael

--jp/wYgCe/4X/etuk
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnmsJ8ACgkQnvQgOdby
QH0vfhAAmaRyfl3I+ARHw1rtkz3NDI4zeLRJZRF3RwxlsGiXWAWD8W5vUXKVeUkD
Zm4VFr7uq+Q4gku4QjGbzFhFeSVxXz/F+aMEhOAJBCsBddKFwgsEy879X4f0ECgn
8AbWlhBBODmzjp7IBpK6tPtE0ZbXN7pHsdPqtujRLTvIzJfhcWG8L+PNzKbq8xPp
rErdM+htSZHgUj90AqL0jMD20oyqbRno+JFXcZXuEUwfwwtbZoafJQ7ruEoFj7fo
Dwo5BQazcE3mqUayFtS8I92fw7qBBRVSVwioxUCsx488dVAE17oo8G+cqBHFBHBy
dRioeJZ4TKchTht+UiQzx/4PfvMeMhpIs9Fr4UY39wQCqcE0ccmZzWYtYRPqqt/o
ON28wvYqMhXNOKM5Ut3GK3gl1XAeZrUCTPncQmndOiC66BY8e3cL/abc59p7ogvl
Ay2/P/BKY+20wL8SIn8GfgEX5URQYTzYet/DJrDK4Vxq446FW/tKZxpAqa/5cJry
SO4RpUFKOblgAVXSlGMkWC7lPYbi3xIboWop6BSPKEzQ2EctxvP4MGQHrOsJ4i2+
Q2Dg923otf1XAs7SyyjrVhAsoTF9COPL08coKNySIyvgud6fy0N8lRUSJ2PZ0Jkr
eit0hr8sWZ+Cepga4TliLn7mSU5EBk/rmzjVbz5BiKw5ppTr//U=
=5yzA
-----END PGP SIGNATURE-----

--jp/wYgCe/4X/etuk--