Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dB1Js-00029y-8j for pgsql-hackers@arkaria.postgresql.org; Wed, 17 May 2017 15:57:00 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dB1Jr-0000d7-Rk for pgsql-hackers@arkaria.postgresql.org; Wed, 17 May 2017 15:56:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dB1IC-0006BO-Mi for pgsql-hackers@postgresql.org; Wed, 17 May 2017 15:55:16 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dB1I8-0005Gm-WE for pgsql-hackers@postgresql.org; Wed, 17 May 2017 15:55:16 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id ABF2727049; Wed, 17 May 2017 11:55:11 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute7.internal (MEProxy); Wed, 17 May 2017 11:55:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=wVRhY42RnDqInp1S6HR0/jKYVCHJpVh+vnrJyt+QWR0=; b=SRmhSMek CWvdLzvrO+shzt2aIa0wup6sqCdwV6XQRtbrDKa7EP7h9D9UyJCiPmKs+p3XCR8A 26I1+eBN/jfQvW8pbi4BWw6rX0SJLyV90fZzmZV5x7foq/4CzjQ/51TBuGFNC356 1vdvj2x7O4cYLj0+/itKti1fJqv3z0i3CrY+waIJ1XTtmACTGxiIGm+fvHY572GQ 6L1l+jSrTQ/fg/Pb+HqZMLSFHYWF23eOoCe2vPKdf6qKkLL+OT0PUf8DOz78L9DB iKZAB6rxiQLU+uHxKyYiH7wGHI+NUEw6lWfjA17qNX/PxrrMglaUFLVffUSvaS4p xxMO0PapzGdeKg== X-ME-Sender: X-Sasl-enc: PwpqzzOBO35PwbO9ECyL3HRJkGOGh/fb2mCQOMCaRQR3 1495036511 Received: from april.local (c-73-13-66-39.hsd1.pa.comcast.net [73.13.66.39]) by mail.messagingengine.com (Postfix) with ESMTPA id 70E887E71B; Wed, 17 May 2017 11:55:11 -0400 (EDT) Subject: Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run. To: Tom Lane , Alvaro Herrera References: <20170517140847.lasiafwmsxgzppm6@alvherre.pgsql> <30659.1495030469@sss.pgh.pa.us> Cc: pgsql-hackers@postgresql.org From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: Date: Wed, 17 May 2017 11:55:11 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <30659.1495030469@sss.pgh.pa.us> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 5/17/17 10:14, Tom Lane wrote: > What I was concerned about was that pgindent will reindent the second > line so that it's impossible to tell whether the spacing is correct. pgindent moving string continuations to the left is a completely terrible behavior anyway and we should look into changing that. Just look at the mess it makes out of SELECT queries in pg_dump.c. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers