Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFDGk-0000K8-Hf for pgsql-committers@arkaria.postgresql.org; Thu, 25 Feb 2021 09:49:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lFDGj-0001gC-3b for pgsql-committers@arkaria.postgresql.org; Thu, 25 Feb 2021 09:49:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFDGh-0001g5-6Z for pgsql-committers@lists.postgresql.org; Thu, 25 Feb 2021 09:49:12 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFDGe-00081V-EZ for pgsql-committers@lists.postgresql.org; Thu, 25 Feb 2021 09:49:10 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 25279E21; Thu, 25 Feb 2021 04:49:06 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 25 Feb 2021 04:49:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm2; bh=7 GLiaZ3HRvFT44wwOsXThAMwUxyMrvsYuB1T5ISDJ9o=; b=Gev+kNTS0GOn4fPb3 sGCC3FyaIozjl48942daPDtvP5ybO5GjK+yWlUQg5lh1Usz04hYvvlvsSeNcKnZJ gdOewOApCIXOvu6iUpBpKpv+s8oOSoA9CcfPL81+0hN8DnYR1taNWWS1FE3JZPrV l2GVj2nsotSENG70LUeHRvh0DxqTuBlLprW9NH9vT+f5L7oItMV+gDtMJmWrqVK4 JJaaE1OwT4QU0U39vpG1nB+XwXQfvIRvNRr/zrAbI6CwOjo4fHUEFapxWtVci74T T2pNiJmWg8Humgr4jOOmjhDAv4IheRQO3B7WN0+xFRQb3p/03EoTcUPMjB9Xi6HV WnQtg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=7GLiaZ3HRvFT44wwOsXThAMwUxyMrvsYuB1T5ISDJ 9o=; b=HUSzE+IUNlM/BQdT0isIM6FmM3PXGqlHjmsP2FsowRFGQcxfPBMeXCvf1 XSp5t5EGx3S2oFfTE5c897fhHTLF4MKhhGQzaOrsXodCx6QK8sH8v3VEVRYkOACL dI4FJNWCnuB+4Qu8XD82LuoK3ljvyHWxn/87pUbmyzba8ahORBIfiwW+WSj2HmGT j0+DI/17tFOgFeH0cHHnXUVx/urr3Jrxlp/IUdC7UumHJUccurKLcI0WQOZUGWOf OLUQZpArHmB/nbSQonNlBrjgAJL7bzVS67ck+wSvAzLhjgFBH0qzLyNA/SxbaimP BEh+EQV7d0t1Rmf6QHfTNllA4x8dg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrkeelgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvghtvghr ucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgheqne cuggftrfgrthhtvghrnhepuefhjeeiudfhkeekheejjeekhfdugeehtdeugfevteffjeeh geeggfdtheekledvnecuffhomhgrihhnpehpohhsthhgrhdrvghsnecukfhppeekjedrud ejjedrieelrddugedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhg X-ME-Proxy: Received: from laptop206oxuk.local (p57b1458c.dip0.t-ipconnect.de [87.177.69.140]) by mail.messagingengine.com (Postfix) with ESMTPA id DD1991080063; Thu, 25 Feb 2021 04:49:04 -0500 (EST) Subject: Re: pgsql: pg_collation_actual_version() -> pg_collation_current_version(). To: Thomas Munro Cc: pgsql-committers References: <2e30284c-1440-a98a-43fe-ad6ebc7a10bb@eisentraut.org> From: Peter Eisentraut Message-ID: Date: Thu, 25 Feb 2021 10:49:02 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 23.02.21 08:23, Thomas Munro wrote: > On Tue, Feb 23, 2021 at 7:03 PM Peter Eisentraut wrote: >> On 22.02.21 12:28, Thomas Munro wrote: >>> pg_collation_actual_version() -> pg_collation_current_version(). >>> >>> The new name seems a bit more natural. >>> >>> Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com >> >> I don't find where this change was discussed in that thread. I >> specifically chose that name to indicate, "not the current version in >> the database, but the version the OS thinks it should be". I think the >> rename loses that distinction. > > I understood "actual" to be a way of contrasting with > pg_collation.collversion, which we dropped. Without that, the meaning > of a more typical function name with "current" seemed clearer to me, > and "actual" seemed excessively emphatic. There isn't a concept of a > single "current version in the database" anymore, there's just the set > of relevant versions that were current when each index was built. > Happy to revert the name change if you hate it though, and sorry I > didn't CC you on the thread. Seeing that explanation, I think that's even more of a reason to avoid the name "current" and use something strikingly different. In any case, this function name has been around for some years now and renaming it just for taste reasons seems unnecessary.