Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1x231z-005YjR-39
	for pgsql-hackers@arkaria.postgresql.org;
	Thu, 03 Sep 2026 08:42:48 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1x231y-00Gmx1-2V
	for pgsql-hackers@arkaria.postgresql.org;
	Thu, 03 Sep 2026 08:42:46 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <cb@df7cb.de>)
	id 1x231t-00Gmwj-1X
	for pgsql-hackers@lists.postgresql.org;
	Thu, 03 Sep 2026 08:42:46 +0000
Received: from goedel.df7cb.de ([49.13.90.212])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <cb@df7cb.de>)
	id 1x231q-00000003mDy-3xiU
	for pgsql-hackers@lists.postgresql.org;
	Thu, 03 Sep 2026 08:42:40 +0000
Received: from msg.df7cb.de (unknown [192.168.76.12])
	by goedel.df7cb.de (Postfix) with ESMTPSA id 2C3C5181D5;
	Thu, 03 Sep 2026 08:42:35 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=df7cb.de; s=dkim2025;
	t=1788424955;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=p3b2F2DBibpMJIegQ/g/rN+9mv8JuDK5+yXC3M3umOg=;
	b=EzC5M61eDf24NTB8rz5h7XTbmAvAYXtylNUYDPix7QmdZnbxjQDuUnRQLPFAnfoqeACjuT
	9vdjrpDdLLIzfcNR2ScNwasXcxLbZvO3lgy9tNi4VpBxKS75+KdLEKG6moyz7ztKI/s1Tp
	ri6W+IR3C4ZDTR9yNH4G851zq4AYOqQ=
Date: Thu, 3 Sep 2026 10:42:34 +0200
From: Christoph Berg <cb@df7cb.de>
To: Daniel Gustafsson <dgustafsson@postgresql.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Fix compilation with OpenSSL 4
Message-ID: <apky-gqiLVtFkR-w@msg.df7cb.de>
References: <E1wY0l8-0000hP-2N@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1wY0l8-0000hP-2N@gemulon.postgresql.org>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/apky-gqiLVtFkR-w%40msg.df7cb.de>
Precedence: bulk

Re: Daniel Gustafsson
> There is also an errormessage change in OpenSSL 4.0.0 which needed
> to be covered by our testharness.

The backpatches of the message test are incomplete for 16 and 17:

git show origin/REL_16_STABLE:src/test/ssl/t/001_ssltests.pl | grep 'alert certificate revoked'
	expected_stderr => qr!SSL error: (ssl[a-z0-9/]*|tls) alert certificate revoked!,
	expected_stderr => qr!SSL error: (ssl[a-z0-9/]*|tls) alert certificate revoked!,
	expected_stderr => qr|SSL error: ssl[a-z0-9/]* alert certificate revoked|,

git show origin/REL_17_STABLE:src/test/ssl/t/001_ssltests.pl | grep 'alert certificate revoked'
	expected_stderr => qr!SSL error: (ssl[a-z0-9/]*|tls) alert certificate revoked!,
	expected_stderr => qr!SSL error: (ssl[a-z0-9/]*|tls) alert certificate revoked!,
	expected_stderr => qr|SSL error: ssl[a-z0-9/]* alert certificate revoked|,

18/15/14 are ok:

git show origin/REL_18_STABLE:src/test/ssl/t/001_ssltests.pl | grep 'alert certificate revoked'
	expected_stderr => qr!SSL error: (ssl[a-z0-9/]*|tls) alert certificate revoked!,
	expected_stderr => qr!SSL error: (ssl[a-z0-9/]*|tls) alert certificate revoked!,
	expected_stderr => qr!SSL error: (ssl[a-z0-9/]*|tls) alert certificate revoked!,

Noticed while bootstrapping the new Ubuntu stonking 26.10 for apt.pg.o.

Christoph