Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1x2Mko-005jOa-2M for pgsql-committers@arkaria.postgresql.org; Fri, 04 Sep 2026 05:46:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1x2Mkn-004oOO-1x for pgsql-committers@arkaria.postgresql.org; Fri, 04 Sep 2026 05:46:21 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1x2Mkn-004oOG-1F for pgsql-committers@lists.postgresql.org; Fri, 04 Sep 2026 05:46:21 +0000 Received: from fout-b4-smtp.messagingengine.com ([202.12.124.147]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1x2Mkk-00000003vav-3tUT for pgsql-committers@lists.postgresql.org; Fri, 04 Sep 2026 05:46:20 +0000 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.stl.internal (Postfix) with ESMTP id 4D18E1D00184; Fri, 4 Sep 2026 01:46:18 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Fri, 04 Sep 2026 01:46:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1788500778; x=1788587178; bh=4OixmXsVB6 efD413H3ngcWXpuoL2DR5ecdL6afTlWVg=; b=MJ2Dq0kfNfYlPJRlWTRaOsjAm3 kInw1Idrr7kiPeQyc7+BC1JeCjf3hueNGk2PYRtPi1r5S/AkY5bW+lHbpRwPEoa3 ASKZMpL/dSootK7CAVtqbfjAxPpGB0mJ/a+7lybc9I/ke/uMMCw931ObPJZ+GooV zvB/56Jo9CEZjwMPjOgxX6AtVlPns1eu2TZC+fIqiHBKdHqEnitgerCbOlJf8DxB mk/lHU0hHWXWH58p4s63QcIubX9MhUVuapUpuUwUw2Z+acpquKnMvzkVlws6UepV YsQ9VqnPSi892xFWacMImHyohsjd6Q1aPnX73WQwDeVdhNt5CpYqZtpV5gOA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1788500778; x=1788587178; bh=4OixmXsVB6efD413H3ngcWXpuoL2DR5ecdL 6afTlWVg=; b=Plco7qxZHcIuBSAQexuv/mSVqRJZRiPhoa3JXN5AQIv46jpi8yE E8rHny7Bk2cAWVLcnHsrv4m6cQdcgM3xm0yFHtvdb5/aK2ubntRWMBbxSWl05xFG Opix8PrzYXbncCQuGApJVDSi6VoE1Y3YFQO0jM3VyFosjX18Q8z5bSTvWssTd0EV UUzOBNN9RKbQhv3MD1WGcRf3iEBVWQ5qZmARzcrUfgkyhdwmlK05j9GV4NIhxr9Z TfMngAjTpWXriovE/aK1FHdPR052XypTHrQ9bzml2XknLK3kpcSGKXx5dRq7uKEH s3aRyIU/GV1IKkR6xatE09/h/lYClzjGF4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEKq9HzlMW8xgpLMJPxmoUG9PGQ6PCYZPAFkwT8KPDko+KKon4IH9wVGFETveRJ1y N89xjGzq4ORqFZTtiVvVRp5Z/v8DttcUdh/ESespjIr+NqxLEK3YXb2xAcyurvDFQ/zHpb a4YSgT9T00WXjUz3fyQt0HAsRhkbnC8360VZ0L9Adp3gUwdOzvEt3KzMcgwlAU2WQpKK6Q GYCNz2eDqYrdP4Hbm59E/lRIgI3cE4tkSRlrQ8VrAg/gAdSUhYk+l8HMpLS6ENwKhblohl awK4rFFDNJFs/spJwQipF+hvrSGhKR0UMCkI7EpYHHrEU0G/bhybODtE4tvd/PtF/rHvNd bQTVjwnKx5+9RIJi/vlYoYbggQR6PtbtEZB/WGVKwdSpDjRYxwI8lTduiJEr8yGpJscRpV VBIIUy7WQZ9ILYqj0jGxscbU2C4b25w5bbjtpVHkoOZrZi6uhmVV8xOEdHdMiomlR6hvxr L5hE5DXmrvtGSl9/EJKZ/BtvJxta7krIc+XhojpzZ4x93/YJPQ+L10cCFmokNBH4gmp/w9 ST6u8h33/7zKLi1pl0mIr09a7VwkfsGuSPsHZKzIrDoXJh1oXITmCKKgZLVsISrMwMasFi 5IT9FGubjftCdpNA4sFTM0MMf9W2xmwFTFKwsu7VPFiBk2plgTmGV7/TM1Yg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 4 Sep 2026 01:46:16 -0400 (EDT) Date: Fri, 4 Sep 2026 14:46:12 +0900 From: Michael Paquier To: Daniel Gustafsson Cc: Peter Eisentraut , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix lack of message pluralization Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ynHmGc9Mlam0yL5K" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --ynHmGc9Mlam0yL5K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 03, 2026 at 02:51:31PM +0200, Daniel Gustafsson wrote: > On 3 Sep 2026, at 14:49, Peter Eisentraut wrote: >> This is correct, but we have some precedent to pluralize these >> kinds of things anyway. Several reasons: >>=20 >> - Translators shouldn't have to look into the source code what the >> - actual value is. (Or, in this case, even beyond the actual >> - source code.) >>=20 >> - Maybe tomorrow someone changes this to PG_UINT16_MAX, and then >> - it might have to be translated differently. >>=20 >> - Not in this specific case but in general: You might have the >> - same message in different contexts but with different numbers. >=20 > Makes sense, thanks for explaining! Commenting as the guy who has touched the trigger code and added this message. Thanks for the explanation, will keep that in mind. -- Michael --ynHmGc9Mlam0yL5K Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmqaWyQACgkQnvQgOdby QH2ZXw//TgCY6zNum+RiC12Y+6VGpuGX+UcK3ccPWCdoYnqAGs7gnKtdFYyJRGP9 STrihjhdP6HtEbHi/gQL8bGSgJ4dYllpAT0I8lIF++RR6saZHv0RsWHri/tEJh1r YKYGSzd/wfgX6JeGmqkEdC9gbxmgYAz1VOUVbUWPgn7RJ1uovzfFmFuHr8OwoxYH m6mXCqC5p2ICHo6mYwWM68cn3SNwiPosmv7smYuA7lE4sB0boGnd8Wo+e48FgEE8 8PqkT7q5dUN06PRhWBaZWQk8/MOlOThwofdbv5MHj8pp8yfAa6gaGy3nlK0t6PhC vHE/1FDSsy5lKj0DPvzeOlSEYQSX3fnBdRcjOHdS3MxXBlQWF9BJ3wHoP9qHEIh+ 8dbf+lGXHVLgC8X1WhQuUUArIkpFt5y4ZkzibpC4VdHZHxjCO8GXbF2vHqd9mQV0 hgWpvr2tdO05WudYxSeBLhVzCTB2W7WNrpNVerKwoMD9hRD0FlwiXlFzhxKwMNHl SyQq3PH+rbZ9sOs5/9sesa67T5Xv7zTt6TFLwriXR0Floy2/SxgBgTE7aJhXsvp1 GMgajiHvTv6WRukT52xB9Pr5Kd3+C9bURNpxBnN4YNcdf5dZ71xib2B1TCzp9gZe 8OM3csTWRwHvwUCOsyeqYQ1rG9no9AuMvgh60s3gJfzVrvZdx1o= =Y2eC -----END PGP SIGNATURE----- --ynHmGc9Mlam0yL5K--