Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1stAWy-00E5GS-76 for pgsql-committers@arkaria.postgresql.org; Tue, 24 Sep 2024 18:45:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1stAWx-00CACd-GD for pgsql-committers@arkaria.postgresql.org; Tue, 24 Sep 2024 18:44:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1stAWx-00CA6S-8I for pgsql-committers@lists.postgresql.org; Tue, 24 Sep 2024 18:44:59 +0000 Received: from fhigh-a5-smtp.messagingengine.com ([103.168.172.156]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1stAWq-000r5B-RT for pgsql-committers@lists.postgresql.org; Tue, 24 Sep 2024 18:44:58 +0000 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfhigh.phl.internal (Postfix) with ESMTP id AF7F711400FA; Tue, 24 Sep 2024 14:44:51 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Tue, 24 Sep 2024 14:44:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm1; t=1727203491; x=1727289891; bh=yCaJT8XZ7eA0fk6w5EdpjxBom5S5IBu5 28zG6JjSVGI=; b=EFi5tcaA1lbX9a9QRH3V+JBnfBr0NHYOb9d5vkC/qTqISDaY hjCT7eEdwQCHLMA+j0i9EYbwa+hxJQeud5nMSRYFny47b6vIVBKuQtGZecaNDfRG w/XGW318H3D2firp0469R4vJ+qfYWx+HWuTRd7ZdfcKDBFvqiFTwpLgSP7sRN0gc B/JXpiQYKOoDQq5G36ZiGWA2HsKXWAmP5QnMaWWhfLcvdMuMeh4WKcRXtSywSbLk tHmG9spWIsOKlUeYvXqr8IPkK/UWHMc1Kj+vE6qkLsawNbFcize7LgSEe0l1OVwk nQzT92aXvDSn0RuTbE/QMvb03ibkTbX0k+DEoQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1727203491; x= 1727289891; bh=yCaJT8XZ7eA0fk6w5EdpjxBom5S5IBu528zG6JjSVGI=; b=q YWuhhH7ds3Ev2yJDctggP0wJK9Pou8wO5QmKcSTfgIM7XPV6lwJytcC4oWW1hGty luuXA5ITpqW4h837q4dw2IW3IhlWsHtYFxLXTJIvaEfD/hUJ78N/vLxaVcKA2poz rQO0vQC/i5/RkP6viAIMc9vI/P5e/acTly8taUpC98Fet6cQ0eBxFXI13D3XqSW8 DtGpd5FBPeucuXHCBJCp9id2qGbqmlUtVrgQjeCIKFlJvPh/gyVq4VqeFKh/ptIk t1yHI/oJ2HIWoozq43AVIoSkVm2KlTr6es9o14qF5tYm9qdOiIC0ftm/J8pYKOF+ iWRJwxAX9jLWB5PgzZuwQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddtfedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdej necuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvg hnthhrrghuthdrohhrgheqnecuggftrfgrthhtvghrnhepteffveelfeeltddvjeegtdef jefgleefledvffefjedujeevheeigffgjefggfegnecuffhomhgrihhnpehpohhsthhgrh gvshhqlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehpvghtvghrsegvihhsvghnthhrrghuthdrohhrghdpnhgspghrtghpthhtoh epfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepthhhohhmrghsrdhmuhhnrhho sehgmhgrihhlrdgtohhmpdhrtghpthhtohepthhglhesshhsshdrphhghhdrphgrrdhush dprhgtphhtthhopehpghhsqhhlqdgtohhmmhhithhtvghrsheslhhishhtshdrphhoshht ghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 24 Sep 2024 14:44:50 -0400 (EDT) Message-ID: Date: Tue, 24 Sep 2024 20:44:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pgsql: Convert some extern variables to static To: Thomas Munro , Tom Lane Cc: pgsql-committers@lists.postgresql.org References: <2078838.1726787728@sss.pgh.pa.us> Content-Language: en-US From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 20.09.24 01:48, Thomas Munro wrote: > On Fri, Sep 20, 2024 at 11:15 AM Tom Lane wrote: >> Peter Eisentraut writes: >>> Convert some extern variables to static >> >> I'm surprised it took me so long to notice, but this commit >> makes headerscheck unhappy: > > Also discussed at: > > https://www.postgresql.org/message-id/flat/CA%2BhUKG%2BYVt5MBD-w0HyHpsGb4U8RNge3DvAbDmOFy_epGhZ2Mg%40mail.gmail.com#aba3226c6dd493923bd6ce95d25a2d77 I have committed the fix discussed there.