Message-ID: <b0e53caa-9eaf-2678-6e05-364d4ab55804@dunslane.net>
Date: Tue, 14 Dec 2021 09:14:08 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: pgsql: Check that we have a working tar before trying to use it
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
 pgsql-committers@lists.postgresql.org
References: <20211209021604.bv5tfr23ymh4u7x4@alap3.anarazel.de>
 <3707204.1639016334@sss.pgh.pa.us>
 <20211209024604.dpmudj4ax2hoi7cx@alap3.anarazel.de>
 <20211209030856.ibxewzpc5ph7ckkp@alap3.anarazel.de>
 <YbGYe483803il3X7@paquier.xyz>
 <20211209064928.7f5lp6hxvw2f2j6o@alap3.anarazel.de>
 <YbGr7ylYwE56l91B@paquier.xyz>
 <95787b2b-d483-0b5e-b24b-1986cff93596@dunslane.net>
 <Ybb/itFhY3FrsyzF@paquier.xyz>
 <190aad26-d04b-f2c6-c4a3-e184377f4c8c@dunslane.net>
 <Ybgo5ZWgqeUeW79F@paquier.xyz>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <Ybgo5ZWgqeUeW79F@paquier.xyz>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/b0e53caa-9eaf-2678-6e05-364d4ab55804%40dunslane.net>
Precedence: bulk


On 12/14/21 00:17, Michael Paquier wrote:
> On Mon, Dec 13, 2021 at 11:47:36AM -0500, Andrew Dunstan wrote:
>> No. The code only sets them if they have not been previously set by
>> buildenv.pl or the calling environment. That's what "||=" means.
> Well, using ||= after the fact means that it is not possible to delete
> any of those environment variables either in buildenv.pl, nor is it
> possible to set them to empty string values, as vcregress.pl would
> just reset them to the default value.  And that's the case I am
> arguing for here.  We don't have any need to drop those default values
> at all.  What I am arguing for here is the possibility to have
> something more flexible than what HEAD proposes.
>
> So, if we do something like say the attached, then it is possible to
> handle environments like mine, while keeping the flexibility you are
> looking for to set those defaults.  So that would be the best of both
> worlds, no?.  I also think that we had better document all that
> properly, as we do for any other TAP-related variable that can be used
> in vcregress.pl.  All that leads me to the attached.


Ok, if you think it's important then do it.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com