Message-ID: <b20d6d97-7338-48ea-ba33-837a1c8ef98e@iki.fi>
Date: Fri, 8 Mar 2024 10:24:52 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Unicode case mapping tables and functions.
Content-Language: en-US
To: Jeff Davis <jdavis@postgresql.org>
References: <E1riJFq-002aP8-QF@gemulon.postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <E1riJFq-002aP8-QF@gemulon.postgresql.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/b20d6d97-7338-48ea-ba33-837a1c8ef98e%40iki.fi>
Precedence: bulk

On 07/03/2024 21:18, Jeff Davis wrote:
> Unicode case mapping tables and functions.

With -Wtype-limits, I'm seeing this warning:

unicode_case.c: In function ‘convert_case’:
unicode_case.c:107:47: warning: comparison of unsigned expression in ‘< 
0’ is always false [-Wtype-limits]
   107 |         while (src[srcoff] != '\0' && (srclen < 0 || srcoff < 
srclen))
       |                                               ^

That seems like legit issue. The comment in unicode_strlower/upper() says:

>  * String src must be encoded in UTF-8. If srclen < 0, src must be
>  * NUL-terminated.

But srclen is of type size_t, which is unsigned.

-- 
Heikki Linnakangas
Neon (https://neon.tech)