Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sqYYp-00AjS1-Pu for pgsql-committers@arkaria.postgresql.org; Tue, 17 Sep 2024 13:48:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sqYYo-00BE1d-RJ for pgsql-committers@arkaria.postgresql.org; Tue, 17 Sep 2024 13:48:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sqYYo-00BDyl-EO for pgsql-committers@lists.postgresql.org; Tue, 17 Sep 2024 13:48:06 +0000 Received: from mail-qv1-xf36.google.com ([2607:f8b0:4864:20::f36]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1sqYYj-001ep7-Ge for pgsql-committers@lists.postgresql.org; Tue, 17 Sep 2024 13:48:05 +0000 Received: by mail-qv1-xf36.google.com with SMTP id 6a1803df08f44-6c524b4a3aeso45701046d6.3 for ; Tue, 17 Sep 2024 06:48:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dunslane-net.20230601.gappssmtp.com; s=20230601; t=1726580881; x=1727185681; darn=lists.postgresql.org; h=in-reply-to:autocrypt:content-language:from:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=sQFVSnjZNAVFDLlMad0hlf25yiJqNnCDSNMRQchUyEM=; b=Z5EwtOV2qBmWE/0RoaFfCT1RLIJvTqDBNm7VPg43fNi//CoKRas3DurFhvGq7eIjrb rTU1DNUOGt92BZTqudN7r6SAYjZjnoRqkbwmMVGDE21H1Ki3qWzaVbtiu9/CsUOsmy9U R1+FEzXUtuqfvRwNojHW3zviRdIY4GAdCMeIq1djGoLhN5p4YY0FRb50lcsWJkN7NgLn 1ubuSx6Gdmh7ac6rPZknMtkPJQtZfBY9Pq+JFoO87EjHJmTshJsuaYU2O3V48WKtyEbi 4dBfi8UTJg2XjrE3dCeIKvaiBUQ6+V1dRO31zaiNV+OldZ1vOjeJNpa1uldfwWN/82Hy BN8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726580881; x=1727185681; h=in-reply-to:autocrypt:content-language:from:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sQFVSnjZNAVFDLlMad0hlf25yiJqNnCDSNMRQchUyEM=; b=Rukw7Z6T1gCNM7vMyw7lgRdDbDvQp9N5RawZy6IXQeWedgJ1WzBP84c2CpioE3eppJ ZpBBXQZDl+j2njaK6G6p6rCAOKEJ5RQ7MK7JKcrcWgc1v7zh3JP1xDSScJ3iv6IgOgs5 xBSOPXR41LXIMlxW/7ky/Apv2dnMrWrFNV8Q2wlQvJJo3EYz9VniUnovJlJ48kiOm8l1 q2I57VSPNhY9D4moyPXsgAlfbZ+Tu9D18NozhJWT1dBO7xLWZ6P+QiQER4ZY9N9WbyuA zpnDQ9dmht0LQUUF43USbtQo7fV+On4HyJVqDiCGED93Pf+nSOm3gewEKG88PD2O9zxc 3DOw== X-Forwarded-Encrypted: i=1; AJvYcCV8zmDnRNQTbwlUfnyNKoxjbrRS8Y9TivMhYixVZkGUNAjIt6dRwfy3ORCnpgb3EP1zgit6vf0Rdbt3Xq6BdwtK@lists.postgresql.org X-Gm-Message-State: AOJu0YyEtK7/Q3/94IbFqeA//frJWeLOJI4A4RrJr/gwS8nRCwA03y9b OH4t8M019Xh5ejqC35BTHSh4bLPvIkBpL5+RB0fxUGAZyGRIn91HZMa1SZ2sA3s= X-Google-Smtp-Source: AGHT+IGs0gyiLggupno3dUFfwOLedfXTNDoD5BKrMXIHk0FHVqQKfpG0V21Dyq007laMC0muVK5Cvw== X-Received: by 2002:a05:6214:3d98:b0:6bf:6e27:f0fe with SMTP id 6a1803df08f44-6c57352cd44mr306706366d6.23.1726580880822; Tue, 17 Sep 2024 06:48:00 -0700 (PDT) Received: from ?IPV6:2605:a601:9180:9800::2bb? ([2605:a601:9180:9800::2bb]) by smtp.googlemail.com with ESMTPSA id 6a1803df08f44-6c58c634efcsm34909286d6.50.2024.09.17.06.47.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Sep 2024 06:47:59 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------OyE8082GhfI3cYKJkQvQsAPq" Message-ID: Date: Tue, 17 Sep 2024 09:47:57 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pgsql: scripts: add Perl script to add links to release notes To: Bruce Momjian , pgsql-committers@lists.postgresql.org References: From: Andrew Dunstan Content-Language: en-US Autocrypt: addr=andrew@dunslane.net; keydata= xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAmwQTAQgARQIbAwIX gAIZAQULCQgHAgMiAgEGFQoJCAsCBBYCAwECHgcWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUC ZFlxxwUJGVGAbgAKCRCZ+n/LWfw7gXikB/9ZdcUy6CTBFIIuL/bVsc1eLEW/gJBjJBF6HxNY xgEkAgXAp4Lg4A5U+QB9GouFr7+GYxF0BU4hzoGhNPUWltxnHdMWP8nC/38LAqgMi8L/bbsm HW5YPBdWYaAZAPJQVfOAgjTbRUb26KSprpyrrJKW0ZmrZfjhNPcQ72jpWzoPLQqx2X6B0fru 1jq+cBh8lb6r1mJTim1T3JIn+F/v5VpdQS+EL8xqsHkfzKjIPsW3CIXpkypSk6saA55Rkkbl 26AW8ftPVB0Q6Lnn6FLt9CP0MGNixBQ55yq8r1K+nCBvCCjvQjM8RDm0UUum0WNl+ifQgTLO E8TWEnwVtkBf+3QWzsBNBE7KWFkBCADRnOM0FCzsYW6jtncg+dWIagjUZpvaClmqn/sJluLa Q3v1VXMQJzYs3eC1gh386W+XBwLRpDj3jzH81lX+p73Re3d3oJW7X+ffsxuzu5ZVdMUkqBYo nkAbKxr6gyJ12F/+JkUVzLcoTN+d/7YsQvUVi7NaKH8mJgjz112O4fUe3p9wfAaFa0RXHc5S GPzRTYRRlv/XZBIho4J2tkZOnteZJZ+GbxQVlINt6fd8P6al3MWOvpP/ExJPguEfjOsO6Njy xjo3WfpD4lHMOR/Oc3/8mScEF84rF2jXbsFgelWnbPWAvXY+pD0dXOFRkagGmC/viwBDqq5b 5tk76kKmUbZxABEBAAHCwHwEGAEIACYCGwwWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUCZFlx 5wUJGVGAjgAKCRCZ+n/LWfw7gf+iB/4g8CPY5jihf5r/8EsoIGe2H+dpVmpPF8YGBzTIvCz/ fQoOq8AX/pE76QEuFnFZWfjw+wgBXgCVmkox2Eflkk6z4ND3pcwGZ6CfCxTQCDk/dij+2DQ4 6bmDCy/sBgcbz9mTpoLC11HLoPae6YN9nBNQRZDcEFEu54OaVOqlIdbA6m+POIBCXZdHOFc0 WoDTgxHRzC1jgQNidyd6tKqcsVJs0dzF0oKTmFFmUAqTdJO12LBuNA1rlqrR3EtpYk8B/wtS 5dIMD7Q8hwQpL+4C6GNpb6ZKnPkLi47pDOLhz2qBrqN+rqUEsT3YnExYpzj5yOBi+FlmV1Hw 49QYe1sn2ZPs In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------OyE8082GhfI3cYKJkQvQsAPq Content-Type: multipart/alternative; boundary="------------og5AwrHwlmRxPmUo1iDneDTu" --------------og5AwrHwlmRxPmUo1iDneDTu Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024-09-16 Mo 1:27 PM, Bruce Momjian wrote: > scripts: add Perl script to add links to release notes > > Reported-by: jian he > > Discussion:https://postgr.es/m/ZuYsS5XdA7hVcV9l@momjian.us I realize I'm late to the party on this, but here's a review patch for this script. It's mostly stylistic changes (simpler use of print, use of POSIX xdigit class for hex digits), but it does correct one actual error: AFAIK "die" doesn't do printf style substitutions. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com --------------og5AwrHwlmRxPmUo1iDneDTu Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit


On 2024-09-16 Mo 1:27 PM, Bruce Momjian wrote:
scripts:  add Perl script to add links to release notes

Reported-by: jian he

Discussion: https://postgr.es/m/ZuYsS5XdA7hVcV9l@momjian.us


I realize I'm late to the party on this, but here's a review patch for this script. It's mostly stylistic changes (simpler use of print, use of POSIX xdigit class for hex digits), but it does correct one actual error: AFAIK "die" doesn't do printf style substitutions.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com
--------------og5AwrHwlmRxPmUo1iDneDTu-- --------------OyE8082GhfI3cYKJkQvQsAPq Content-Type: text/x-patch; charset=UTF-8; name="add_commit_links.patch" Content-Disposition: attachment; filename="add_commit_links.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy90b29scy9hZGRfY29tbWl0X2xpbmtzLnBsIGIvc3JjL3Rvb2xz L2FkZF9jb21taXRfbGlua3MucGwKaW5kZXggZWJmYzk3ZWEzMi4uNjRhNTc4MzI5NyAxMDA3 NTUKLS0tIGEvc3JjL3Rvb2xzL2FkZF9jb21taXRfbGlua3MucGwKKysrIGIvc3JjL3Rvb2xz L2FkZF9jb21taXRfbGlua3MucGwKQEAgLTUxLDkgKzUxLDggQEAgc3ViIHByb2Nlc3NfZmls ZQogCSRmaWxlID1+IG0vLShcZCspXC4vOwogCW15ICRtYWpvcl92ZXJzaW9uID0gJDE7CiAK LQlvcGVuKG15ICRmaCwgJzwnLCAkZmlsZSkgfHwgZGllICJjb3VsZCBub3Qgb3BlbiBmaWxl ICVzOiAkIVxuIiwgJGZpbGU7Ci0Jb3BlbihteSAkdGZoLCAnPicsICR0bXBmaWxlKSB8fCBk aWUgImNvdWxkIG5vdCBvcGVuIGZpbGUgJXM6ICQhXG4iLAotCSAgJHRtcGZpbGU7CisJb3Bl bihteSAkZmgsICc8JywgJGZpbGUpIHx8IGRpZSAiY291bGQgbm90IG9wZW4gZmlsZSAkZmls ZTogJCFcbiI7CisJb3BlbihteSAkdGZoLCAnPicsICR0bXBmaWxlKSB8fCBkaWUgImNvdWxk IG5vdCBvcGVuIGZpbGUgJHRtcGZpbGU6ICQhXG4iOwogCiAJd2hpbGUgKDwkZmg+KQogCXsK QEAgLTY0LDkgKzYzLDkgQEAgc3ViIHByb2Nlc3NfZmlsZQogCQkjIHNraXAgb3ZlciBjb21t aXQgbGlua3MgYmVjYXVzZSB3ZSB3aWxsIGFkZCB0aGVtIGJlbG93CiAJCW5leHQKIAkJICBp ZiAoISRpbl9jb21tZW50ICYmCi0JCQlte15ccyo8dWxpbmsgdXJsPSImY29tbWl0X2Jhc2V1 cmw7W1xkYS1mXSsiPiZzZWN0OzwvdWxpbms+XHMqJH0pOworCQkJbXteXHMqPHVsaW5rIHVy bD0iJmNvbW1pdF9iYXNldXJsO1tbOnhkaWdpdDpdXSsiPiZzZWN0OzwvdWxpbms+XHMqJH0p OwogCi0JCWlmICgkaW5fY29tbWVudCAmJiBtL1xbKFtcZGEtZl0rKVxdLykKKwkJaWYgKCRp bl9jb21tZW50ICYmIG0vXFsoW1s6eGRpZ2l0Ol1dKylcXS8pCiAJCXsKIAkJCW15ICRoYXNo ID0gJDE7CiAKQEAgLTg4LDIzICs4NywyMSBAQCBzdWIgcHJvY2Vzc19maWxlCiAJCQkJewog CQkJCQlmb3IgbXkgJGhhc2ggKEBoYXNoZXMpCiAJCQkJCXsKLQkJCQkJCXByaW50KHskdGZo fQotCQkJCQkJCSAgIiRwcmV2X2xlYWRpbmdfc3BhY2U8dWxpbmsgdXJsPVwiJmNvbW1pdF9i YXNldXJsOyRoYXNoXCI+JnNlY3Q7PC91bGluaz5cbiIKLQkJCQkJCSk7CisJCQkJCQlwcmlu dCAkdGZoCisJCQkJCQkgICIkcHJldl9sZWFkaW5nX3NwYWNlPHVsaW5rIHVybD1cIiZjb21t aXRfYmFzZXVybDskaGFzaFwiPiZzZWN0OzwvdWxpbms+XG4iOwogCQkJCQl9CiAJCQkJCUBo YXNoZXMgPSAoKTsKIAkJCQl9CiAJCQkJZWxzZQogCQkJCXsKLQkJCQkJcHJpbnRmKAotCQkJ CQkJImhhc2hlcyBmb3VuZCBidXQgbm8gbWF0Y2hpbmcgdGV4dCBmb3VuZCBmb3IgcGxhY2Vt ZW50IG9uIGxpbmUgJXNcbiIsCi0JCQkJCQkkbGluZW5vKTsKKwkJCQkJcHJpbnQKKwkJCQkJ ICAiaGFzaGVzIGZvdW5kIGJ1dCBubyBtYXRjaGluZyB0ZXh0IGZvdW5kIGZvciBwbGFjZW1l bnQgb24gbGluZSAkbGluZW5vXG4iOwogCQkJCQlleGl0KDEpOwogCQkJCX0KIAkJCX0KIAkJ fQogCi0JCXByaW50KHskdGZofSAkXyk7CisJCXByaW50ICR0ZmggJF87CiAKIAkJJHByZXZf bGluZV9lbmRlZF93aXRoX3BhcmVuID0gbS9cKVxzKiQvOwogCg== --------------OyE8082GhfI3cYKJkQvQsAPq--