pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Add tests for libpq gssencmode and sslmode options
3+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2024-04-12 65dfe9d167 Move libpq encryption negotiation tests
* pgsql: Add tests for libpq gssencmode and sslmode options
@ 2024-04-07 23:50 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 1 reply; 3+ messages in thread
From: Heikki Linnakangas @ 2024-04-07 23:50 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Add tests for libpq gssencmode and sslmode options
Test all combinations of gssencmode, sslmode, whether the server
supports SSL and/or GSSAPI encryption, and whether they are accepted
by pg_hba.conf. This is in preparation for refactoring that code in
libpq, and for adding a new option for "direct SSL" connections, which
adds another dimension to the logic.
If we add even more options in the future, testing all combinations
will become unwieldy and we'll need to rethink this, but for now an
exhaustive test is nice.
Author: Heikki Linnakangas, Matthias van de Meent
Reviewed-by: Jacob Champion
Discussion: https://www.postgresql.org/message-id/a3af4070-3556-461d-aec8-a8d794f94894@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1169920ff77025550718b90a5cafc6849875f43f
Modified Files
--------------
.cirrus.tasks.yml | 2 +-
src/test/libpq_encryption/Makefile | 25 +
src/test/libpq_encryption/README | 31 ++
src/test/libpq_encryption/meson.build | 18 +
.../libpq_encryption/t/001_negotiate_encryption.pl | 548 +++++++++++++++++++++
src/test/meson.build | 1 +
6 files changed, 624 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Add tests for libpq gssencmode and sslmode options
@ 2024-04-10 14:48 Peter Eisentraut <peter@eisentraut.org>
parent: Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 1 reply; 3+ messages in thread
From: Peter Eisentraut @ 2024-04-10 14:48 UTC (permalink / raw)
To: Heikki Linnakangas <heikki.linnakangas@iki.fi>; pgsql-committers@lists.postgresql.org
On 08.04.24 01:50, Heikki Linnakangas wrote:
> Add tests for libpq gssencmode and sslmode options
Why aren't these tests at
src/interfaces/libpq/t/nnn_negotiate_encryption.pl ?
> Test all combinations of gssencmode, sslmode, whether the server
> supports SSL and/or GSSAPI encryption, and whether they are accepted
> by pg_hba.conf. This is in preparation for refactoring that code in
> libpq, and for adding a new option for "direct SSL" connections, which
> adds another dimension to the logic.
>
> If we add even more options in the future, testing all combinations
> will become unwieldy and we'll need to rethink this, but for now an
> exhaustive test is nice.
>
> Author: Heikki Linnakangas, Matthias van de Meent
> Reviewed-by: Jacob Champion
> Discussion: https://www.postgresql.org/message-id/a3af4070-3556-461d-aec8-a8d794f94894@iki.fi
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/1169920ff77025550718b90a5cafc6849875f43f
>
> Modified Files
> --------------
> .cirrus.tasks.yml | 2 +-
> src/test/libpq_encryption/Makefile | 25 +
> src/test/libpq_encryption/README | 31 ++
> src/test/libpq_encryption/meson.build | 18 +
> .../libpq_encryption/t/001_negotiate_encryption.pl | 548 +++++++++++++++++++++
> src/test/meson.build | 1 +
> 6 files changed, 624 insertions(+), 1 deletion(-)
>
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Add tests for libpq gssencmode and sslmode options
@ 2024-04-10 15:54 Heikki Linnakangas <hlinnaka@iki.fi>
parent: Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 3+ messages in thread
From: Heikki Linnakangas @ 2024-04-10 15:54 UTC (permalink / raw)
To: Peter Eisentraut <peter@eisentraut.org>; pgsql-committers@lists.postgresql.org
On 10/04/2024 17:48, Peter Eisentraut wrote:
> On 08.04.24 01:50, Heikki Linnakangas wrote:
>> Add tests for libpq gssencmode and sslmode options
>
> Why aren't these tests at
> src/interfaces/libpq/t/nnn_negotiate_encryption.pl ?
To be honest, it never occurred to me. It started out as extra tests
under src/test/ssl/, and when I decided to move them out to its own
module, I didn't think of moving them to src/interfaces/libpq/t/.
I will move it, barring any objections or better ideas.
--
Heikki Linnakangas
Neon (https://neon.tech)
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-04-10 15:54 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-04-07 23:50 pgsql: Add tests for libpq gssencmode and sslmode options Heikki Linnakangas <heikki.linnakangas@iki.fi>
2024-04-10 14:48 ` Peter Eisentraut <peter@eisentraut.org>
2024-04-10 15:54 ` Heikki Linnakangas <hlinnaka@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox