pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Avoid using ambiguous word "positive" in error message.
9+ messages / 4 participants
[nested] [flat]

* pgsql: Avoid using ambiguous word "positive" in error message.
@ 2021-08-25 02:48  Fujii Masao <fujii@postgresql.org>
  0 siblings, 1 reply; 9+ messages in thread

From: Fujii Masao @ 2021-08-25 02:48 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Avoid using ambiguous word "positive" in error message.

There are two identical error messages about valid value of modulus for
hash partition, in PostgreSQL source code. Commit 0e1275fb07 improved
only one of them so that ambiguous word "positive" was avoided there,
and forgot to improve the other. This commit improves the other.
Which would reduce translator burden.

Back-pach to v11 where the error message exists.

Author: Kyotaro Horiguchi
Reviewed-by: Fujii Masao
Discussion: https://postgr.es/m/20210819.170315.1413060634876301811.horikyota.ntt@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/170aec63cd7139b453c52ad52bbeb83993faa31d

Modified Files
--------------
src/backend/parser/parse_utilcmd.c         | 2 +-
src/test/regress/expected/alter_table.out  | 2 +-
src/test/regress/expected/create_table.out | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* pgsql: Avoid using ambiguous word "positive" in error message.
@ 2021-08-25 02:49  Fujii Masao <fujii@postgresql.org>
  0 siblings, 0 replies; 9+ messages in thread

From: Fujii Masao @ 2021-08-25 02:49 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Avoid using ambiguous word "positive" in error message.

There are two identical error messages about valid value of modulus for
hash partition, in PostgreSQL source code. Commit 0e1275fb07 improved
only one of them so that ambiguous word "positive" was avoided there,
and forgot to improve the other. This commit improves the other.
Which would reduce translator burden.

Back-pach to v11 where the error message exists.

Author: Kyotaro Horiguchi
Reviewed-by: Fujii Masao
Discussion: https://postgr.es/m/20210819.170315.1413060634876301811.horikyota.ntt@gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ec619102aa56d3356fb6550a343af01ad477e4a2

Modified Files
--------------
src/backend/parser/parse_utilcmd.c         | 2 +-
src/test/regress/expected/alter_table.out  | 2 +-
src/test/regress/expected/create_table.out | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* pgsql: Avoid using ambiguous word "positive" in error message.
@ 2021-08-25 02:50  Fujii Masao <fujii@postgresql.org>
  0 siblings, 0 replies; 9+ messages in thread

From: Fujii Masao @ 2021-08-25 02:50 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Avoid using ambiguous word "positive" in error message.

There are two identical error messages about valid value of modulus for
hash partition, in PostgreSQL source code. Commit 0e1275fb07 improved
only one of them so that ambiguous word "positive" was avoided there,
and forgot to improve the other. This commit improves the other.
Which would reduce translator burden.

Back-pach to v11 where the error message exists.

Author: Kyotaro Horiguchi
Reviewed-by: Fujii Masao
Discussion: https://postgr.es/m/20210819.170315.1413060634876301811.horikyota.ntt@gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7d9026cbfd340a4de6c96ff7c728e53c3791e1cc

Modified Files
--------------
src/backend/parser/parse_utilcmd.c         | 2 +-
src/test/regress/expected/alter_table.out  | 2 +-
src/test/regress/expected/create_table.out | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* pgsql: Avoid using ambiguous word "positive" in error message.
@ 2021-08-25 02:50  Fujii Masao <fujii@postgresql.org>
  0 siblings, 0 replies; 9+ messages in thread

From: Fujii Masao @ 2021-08-25 02:50 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Avoid using ambiguous word "positive" in error message.

There are two identical error messages about valid value of modulus for
hash partition, in PostgreSQL source code. Commit 0e1275fb07 improved
only one of them so that ambiguous word "positive" was avoided there,
and forgot to improve the other. This commit improves the other.
Which would reduce translator burden.

Back-pach to v11 where the error message exists.

Author: Kyotaro Horiguchi
Reviewed-by: Fujii Masao
Discussion: https://postgr.es/m/20210819.170315.1413060634876301811.horikyota.ntt@gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f53ceaea8a1da638a5c68a09676c67e90b7de870

Modified Files
--------------
src/backend/parser/parse_utilcmd.c         | 2 +-
src/test/regress/expected/alter_table.out  | 2 +-
src/test/regress/expected/create_table.out | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* pgsql: Avoid using ambiguous word "positive" in error message.
@ 2021-08-25 02:50  Fujii Masao <fujii@postgresql.org>
  0 siblings, 0 replies; 9+ messages in thread

From: Fujii Masao @ 2021-08-25 02:50 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Avoid using ambiguous word "positive" in error message.

There are two identical error messages about valid value of modulus for
hash partition, in PostgreSQL source code. Commit 0e1275fb07 improved
only one of them so that ambiguous word "positive" was avoided there,
and forgot to improve the other. This commit improves the other.
Which would reduce translator burden.

Back-pach to v11 where the error message exists.

Author: Kyotaro Horiguchi
Reviewed-by: Fujii Masao
Discussion: https://postgr.es/m/20210819.170315.1413060634876301811.horikyota.ntt@gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f23b2a488b062563fe09fe3552979f18055e8f53

Modified Files
--------------
src/backend/parser/parse_utilcmd.c         | 2 +-
src/test/regress/expected/alter_table.out  | 2 +-
src/test/regress/expected/create_table.out | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* Re: pgsql: Avoid using ambiguous word "positive" in error message.
@ 2021-08-30 14:03  Robert Haas <robertmhaas@gmail.com>
  parent: Fujii Masao <fujii@postgresql.org>
  0 siblings, 1 reply; 9+ messages in thread

From: Robert Haas @ 2021-08-30 14:03 UTC (permalink / raw)
  To: Fujii Masao <fujii@postgresql.org>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

On Tue, Aug 24, 2021 at 10:49 PM Fujii Masao <fujii@postgresql.org> wrote:
> Avoid using ambiguous word "positive" in error message.

The new style seems good, but I don't really agree that "positive" and
"non-negative" are ambiguous. "positive" means >0 and "non-negative"
means >= 0, because 0 is neither positive nor negative.

This is just nitpicking, though. I think the change is an improvement.

-- 
Robert Haas
EDB: http://www.enterprisedb.com





^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* Re: pgsql: Avoid using ambiguous word "positive" in error message.
@ 2021-08-30 14:16  Tom Lane <tgl@sss.pgh.pa.us>
  parent: Robert Haas <robertmhaas@gmail.com>
  0 siblings, 1 reply; 9+ messages in thread

From: Tom Lane @ 2021-08-30 14:16 UTC (permalink / raw)
  To: Robert Haas <robertmhaas@gmail.com>; +Cc: Fujii Masao <fujii@postgresql.org>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Robert Haas <robertmhaas@gmail.com> writes:
> The new style seems good, but I don't really agree that "positive" and
> "non-negative" are ambiguous. "positive" means >0 and "non-negative"
> means >= 0, because 0 is neither positive nor negative.

Well, the point is precisely that not everyone makes that distinction.
I agree that everyone will read "non-negative" as ">= 0"; but there's
a fair percentage of the population that uses "positive" the same way.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* Re: pgsql: Avoid using ambiguous word "positive" in error message.
@ 2021-08-30 14:19  Robert Haas <robertmhaas@gmail.com>
  parent: Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 9+ messages in thread

From: Robert Haas @ 2021-08-30 14:19 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Fujii Masao <fujii@postgresql.org>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

On Mon, Aug 30, 2021 at 10:16 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
> > The new style seems good, but I don't really agree that "positive" and
> > "non-negative" are ambiguous. "positive" means >0 and "non-negative"
> > means >= 0, because 0 is neither positive nor negative.
>
> Well, the point is precisely that not everyone makes that distinction.
> I agree that everyone will read "non-negative" as ">= 0"; but there's
> a fair percentage of the population that uses "positive" the same way.

The mathematician in me recoils.

-- 
Robert Haas
EDB: http://www.enterprisedb.com





^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* Re: pgsql: Avoid using ambiguous word "positive" in error message.
@ 2021-08-31 13:16  Andrew Dunstan <andrew@dunslane.net>
  parent: Robert Haas <robertmhaas@gmail.com>
  0 siblings, 0 replies; 9+ messages in thread

From: Andrew Dunstan @ 2021-08-31 13:16 UTC (permalink / raw)
  To: Robert Haas <robertmhaas@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Fujii Masao <fujii@postgresql.org>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>


On 8/30/21 10:19 AM, Robert Haas wrote:
> On Mon, Aug 30, 2021 at 10:16 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> The new style seems good, but I don't really agree that "positive" and
>>> "non-negative" are ambiguous. "positive" means >0 and "non-negative"
>>> means >= 0, because 0 is neither positive nor negative.
>> Well, the point is precisely that not everyone makes that distinction.
>> I agree that everyone will read "non-negative" as ">= 0"; but there's
>> a fair percentage of the population that uses "positive" the same way.
> The mathematician in me recoils.
>

Yep, me too. IIRC Ada comes with a predefined subtype named "Positive"
which has the range 1..Integer'Max. It also has "Natural" which includes
zero.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com






^ permalink  raw  reply  [nested|flat] 9+ messages in thread


end of thread, other threads:[~2021-08-31 13:16 UTC | newest]

Thread overview: 9+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 02:48 pgsql: Avoid using ambiguous word "positive" in error message. Fujii Masao <fujii@postgresql.org>
2021-08-30 14:03 ` Robert Haas <robertmhaas@gmail.com>
2021-08-30 14:16   ` Tom Lane <tgl@sss.pgh.pa.us>
2021-08-30 14:19     ` Robert Haas <robertmhaas@gmail.com>
2021-08-31 13:16       ` Andrew Dunstan <andrew@dunslane.net>
2021-08-25 02:49 pgsql: Avoid using ambiguous word "positive" in error message. Fujii Masao <fujii@postgresql.org>
2021-08-25 02:50 pgsql: Avoid using ambiguous word "positive" in error message. Fujii Masao <fujii@postgresql.org>
2021-08-25 02:50 pgsql: Avoid using ambiguous word "positive" in error message. Fujii Masao <fujii@postgresql.org>
2021-08-25 02:50 pgsql: Avoid using ambiguous word "positive" in error message. Fujii Masao <fujii@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox