Message-ID: <b6782dc3-a7b0-ed56-175f-f8f54cb08d67@dunslane.net>
Date: Wed, 8 Dec 2021 12:53:29 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: pgsql: Check that we have a working tar before trying to use it
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
References: <E1muynv-0006GS-R4@gemulon.postgresql.org>
 <3655283.1638977975@sss.pgh.pa.us>
 <2e118a11-6936-21ec-6782-e9dbb20972c2@dunslane.net>
 <3657697.1638980149@sss.pgh.pa.us>
 <b179201e-8451-6a5e-e9be-9c755a13be7f@dunslane.net>
 <3660797.1638983124@sss.pgh.pa.us>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <3660797.1638983124@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/b6782dc3-a7b0-ed56-175f-f8f54cb08d67%40dunslane.net>
Precedence: bulk


On 12/8/21 12:05, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> Actually, I think it makes more sense to simply revert this. bowerbird,
>> like all buildfarm animals, has a working tar.
> Right, it doesn't seem like tar is the biggest lift when setting up
> a buildfarm critter.
>
>> It's just that this one
>> is apparently seriously confused by using paths with a drive spec.
> Hm, so how would this test have handled that anyway?
>
> 			


It would have passed the test and failed the invocation as before. It
turns out that the tar being used is from the (old) MsysGit
installation. So I'm rearranging the path so it finds the system tar
instead. That should take care of things. (testing first before I do
anything else). On my initial test the system tar handled paths with
drive specs just fine.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com