Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oOc9U-0007Rz-Jn for pgsql-committers@arkaria.postgresql.org; Thu, 18 Aug 2022 09:49:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oOc9T-0000tS-Fl for pgsql-committers@arkaria.postgresql.org; Thu, 18 Aug 2022 09:49:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oOc9T-0000tI-7s for pgsql-committers@lists.postgresql.org; Thu, 18 Aug 2022 09:49:23 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oOc9Q-0006sW-9f for pgsql-committers@lists.postgresql.org; Thu, 18 Aug 2022 09:49:22 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 258E85C01DE; Thu, 18 Aug 2022 05:49:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 18 Aug 2022 05:49:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1660816159; x=1660902559; bh=q opZe0rt888IgH55qVBNydcnSKyuyW4jtbFsMWlw6Nk=; b=tTqPx1/XIo4rrxkcK fG9BCogznMbkZb5vt74a5aSJdipGS9TguRHHjkl++m+2xXgfkqTwe9OMexIE4fwn iapMqawjQH/exwH1EXBZXaG0paH1PK1d0u+09W38lykxrGZwe3OG3Vf2GUeFN5NS Z3CKrTY9MpqIJJf3MQox46Uzj6t9SpOeWl7DWmVMGRndTwj3yuxQuEwrUPa6wU/3 CjTfKmYC4xVXsuQLJEek/mckiXWQXeocWqVOWzkUJ0+vE5TjipfoH/pilOh1905r MjJZ21j1894LTubMlqD3mPztU//6Z3sxkj70M8EAKKWj0PeHYR1getj94pX6WQUg 7SvEw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehkedgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheprfgvthgv rhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsegvnhhtvg hrphhrihhsvggusgdrtghomheqnecuggftrfgrthhtvghrnhepfeejgeehteeuhfevvedu leeufedtjeetiefftedvudfhtdeifefgueettdevgefgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgruhht segvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 18 Aug 2022 05:49:16 -0400 (EDT) Message-ID: Date: Thu, 18 Aug 2022 11:49:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: pgsql: Refer to replication origin roident as "ID" in user facing messa Content-Language: en-US To: John Naylor , pgsql-committers@lists.postgresql.org References: From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 18.08.22 04:10, John Naylor wrote: > While at it, most format strings already use %u, so for consintency > change the remaining stragglers using %d. This is incorrect. Replication origin IDs are of type uint16, which gets promoted to int in a variable arguments list, so %d is the correct placeholder.