Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sYRP3-00BO7Y-Dg for pgsql-committers@arkaria.postgresql.org; Mon, 29 Jul 2024 14:31:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sYRO3-000MzJ-Sd for pgsql-committers@arkaria.postgresql.org; Mon, 29 Jul 2024 14:30:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sYRO3-000MzB-Hx for pgsql-committers@lists.postgresql.org; Mon, 29 Jul 2024 14:30:07 +0000 Received: from lahtoruutu.iki.fi ([2a0b:5c81:1c1::37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sYRO0-00257s-EV for pgsql-committers@lists.postgresql.org; Mon, 29 Jul 2024 14:30:06 +0000 Received: from [192.168.1.122] (dsl-hkibng22-54f8db-125.dhcp.inet.fi [84.248.219.125]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: hlinnaka) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 4WXgk21vK3z49Q0G; Mon, 29 Jul 2024 17:30:02 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1722263402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bYcPEQwl0MffKzDKTXMhQEIUK4Eo52oMgdX6xVdPZEg=; b=SG2eWPG54xc9uXBYMCUxKqJcD8nLnnMF8fPXtEMf8myDDjZm0OivoMirJEoLCdNt5rMK3X 4G4eQCT1d4CXMkKKdVC9ctjlfY9ngjTklkOdjf/D/hBeAjwQZR0je1hymNI8jhLjPYaPT8 3nM/pK4ohF3YbxGIimiAj8BJuHbiJgRbouXANrU7egDbSkVA9MgDIbYFEzeMq2nseJgKQw OowSW+wgwKl00j/oS4Ddby5sQUe0pmJpjln6xFRLx13phfs4XGVaasplyhHzYqiD1uJmqC UhdVZAdJh8OT6ZE1pkH+Pdsx3oztfcEAdeIaTdifhQ1waQvCTr2j4peCg1xjDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1722263402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bYcPEQwl0MffKzDKTXMhQEIUK4Eo52oMgdX6xVdPZEg=; b=knqtcD5k4u5sJT0EpSu5//cyI8YQe1Jlwy+9uMNsQeUtVLmkbJGPfZHee5FZ1wFhewawjm +UlD9Nncv97/3RW5BlV0h8wrdtMUHuwHyZzDkfwULsWBMCO6GrmAISy+8XYMcI7GXVqJDz 1/cKSc0n+/EPcgILOZKv2M/ZYuJDhupoquYf3tzP1zbXzBjyA7oNavPx7v9h/xeRk/socg fF33l92u+rb/hhxemtxtPxUbg0q6VusWHIOCVW7OLp6Nyc77PWmnE9Q0F8lHlXXOQGkfwb cbpFV6cHx9Z42OChMr/oLJQZBFCd4Hszoeit9mco646biQ32lKEXJgO3lJ2fcg== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=hlinnaka smtp.mailfrom=hlinnaka@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1722263402; a=rsa-sha256; cv=none; b=k3AbcetLqW/eYulgcZdtlE/TdePcQ8ZDTl6+F8csnWcjlqNrfZfGiFmqVMdcRdOVSqVsUJ crn5O2x7l664kkqKqJxXi21paQogoYkZBLIMNUiFQAEG9QrEIRD0eZ187olSXvWOAqkes9 IjbbK/pzQzAc7ueFtdBFuR2AglFFJ+aDQAa6F0wat0O5M2ZCKg8zqZFYLO5rlpkHoi8W2A NNkjCMBLBY0UxXskCYRfrVV/hnecjtCNS0PbuA/JLmXxUOK7CxtWEh2waB6CDIkiBX1JU5 V6IiTG1Na8gzAlrzPHG8fapYAaFjI3pwNecCKOfraYeExrRPhhQsdUtywCWPjg== Message-ID: Date: Mon, 29 Jul 2024 17:30:01 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pgsql: Move cancel key generation to after forking the backend From: Heikki Linnakangas To: Daniel Gustafsson Cc: pgsql-committers@lists.postgresql.org References: <1156B285-B81B-4A5F-A1FE-F1616D216C68@yesql.se> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 29/07/2024 16:25, Heikki Linnakangas wrote: > On 29/07/2024 16:23, Daniel Gustafsson wrote: >>> On 29 Jul 2024, at 15:18, Heikki Linnakangas wrote: >>> >>> Move cancel key generation to after forking the backend >> >> longfin seems a tad sad about this one: >> >> procsignal.c:87:3: error: redefinition of typedef 'ProcSignalHeader' is a C11 feature [-Werror,-Wtypedef-redefinition] >> } ProcSignalHeader; >> ^ >> ../../../../src/include/storage/procsignal.h:77:33: note: previous definition is here >> typedef struct ProcSignalHeader ProcSignalHeader; >> ^ >> 1 error generated. >> make[4]: *** [procsignal.o] Error 1 > > Yep, thanks, just noticed and fixed it myself. I should add that to the > list of compiler options I use... The --disable-spinlocks animals are still failing, however. Weird. I can reproduce it locally, and started to debug but I have no clue what's wrong. I'll keep debugging, but I'm all ears if anyone has ideas. -- Heikki Linnakangas Neon (https://neon.tech)