Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n6EcZ-0003Cd-DB for pgsql-committers@arkaria.postgresql.org; Sat, 08 Jan 2022 16:31:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1n6EcX-0002YT-AC for pgsql-committers@arkaria.postgresql.org; Sat, 08 Jan 2022 16:31:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n6EcX-0002YJ-2i for pgsql-committers@lists.postgresql.org; Sat, 08 Jan 2022 16:31:09 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n6EcR-0000ST-TK for pgsql-committers@lists.postgresql.org; Sat, 08 Jan 2022 16:31:08 +0000 Received: (Authenticated sender: adsend@dunslane.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 6045CFF807; Sat, 8 Jan 2022 16:31:00 +0000 (UTC) Message-ID: Date: Sat, 8 Jan 2022 11:30:57 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: pgsql: Respect permissions within logical replication. Content-Language: en-US To: Michael Paquier , Jeff Davis Cc: pgsql-committers@lists.postgresql.org References: From: Andrew Dunstan In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 1/8/22 04:25, Michael Paquier wrote: > On Sat, Jan 08, 2022 at 02:22:23PM +0900, Michael Paquier wrote: >> 2) crake fails perl-check >> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-01-08%2002%3A47%3A26 >> >> All the failures are the same, because of the shape of the subroutine >> definitions: >> Jan 07 21:53:04 ./src/test/subscription/t/027_nosuperuser.pl: >> Subroutine prototypes used at line 13, column 1. See page 194 of >> PBP. ([Subroutines::ProhibitSubroutinePrototypes] Severity: 5) > This issue is just caused by the way the subroutines are defined, > meaning that the attached cools down pgperlcritic. Any objections if > I apply that to cool down crake? Jeff, if you wish to do so, please > feel free of course. Please do this. Subroutine prototypes should only be used in very restricted circumstances in Perl. I can't recall when I've ever needed them. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com