Message-ID: <b936521f-a79e-4ddd-d9a4-1864212d7bb1@dunslane.net>
Date: Tue, 2 Jan 2024 09:49:37 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
To: Peter Eisentraut <peter@eisentraut.org>,
 pgsql-committers@lists.postgresql.org
References: <E1rJLlz-00CYAB-5m@gemulon.postgresql.org>
Content-Language: en-US
From: Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pgsql: Follow-up fixes for "Make all Perl warnings fatal"
In-Reply-To: <E1rJLlz-00CYAB-5m@gemulon.postgresql.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/b936521f-a79e-4ddd-d9a4-1864212d7bb1%40dunslane.net>
Precedence: bulk


On 2023-12-29 Fr 17:56, Peter Eisentraut wrote:
> Follow-up fixes for "Make all Perl warnings fatal"
>
> Mostly, we need to check whether $ENV{PG_TEST_EXTRA} is set before
> doing regular expression matches against it.


This reads a bit oddly to me.

-elsif ($ENV{PG_TEST_EXTRA} !~ /\bkerberos\b/)
+elsif (!$ENV{PG_TEST_EXTRA} || $ENV{PG_TEST_EXTRA} !~ /\bkerberos\b/)

I think I would have changed it like this

   elsif (($ENV{PG_TEST_EXTRA" || "") !~ /\bkerberos\b/)

which is an idiom we've used elsewhere.

Still, TIMTOWTDI.


cheers


andrew (japh)

-- 

Andrew Dunstan
EDB: https://www.enterprisedb.com