Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pG5LW-0000nn-Ou for pgsql-committers@arkaria.postgresql.org; Thu, 12 Jan 2023 21:42:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pG5KW-0008Dy-Bz for pgsql-committers@arkaria.postgresql.org; Thu, 12 Jan 2023 21:41:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pG5KW-0008Do-4z for pgsql-committers@lists.postgresql.org; Thu, 12 Jan 2023 21:41:48 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pG5KT-0000TD-M1 for pgsql-committers@lists.postgresql.org; Thu, 12 Jan 2023 21:41:47 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id A5AFF20004; Thu, 12 Jan 2023 21:41:42 +0000 (UTC) Message-ID: Date: Thu, 12 Jan 2023 16:41:40 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: pgsql: Improve handling of inherited GENERATED expressions. Content-Language: en-US To: Tom Lane Cc: Amit Langote , pgsql-committers@lists.postgresql.org References: <16b06d39-e36d-afa3-59d1-9c71ddfa59b7@dunslane.net> <950928.1673534760@sss.pgh.pa.us> <1340662.1673556269@sss.pgh.pa.us> From: Andrew Dunstan In-Reply-To: <1340662.1673556269@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2023-01-12 Th 15:44, Tom Lane wrote: > I wrote: >> Yeah. I think best bet may be to drop the problematic table(s), >> as we've done for other de-supported DDL situations. A quick >> experiment suggests that >> DROP TABLE gtest_normal_child; >> DROP TABLE gtest_normal_child2; >> should do it. > Some testing here confirms that the attached patch is enough to > un-break things for HEAD. Since you mentioned you have some other > quasi-urgent BF fixes, maybe the thing to do is to roll up a release > now and then work on the bigger idea at leisure. > > Thanks, that's almost exactly what I did to turn crake green. I'll push out a release tomorrow. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com