Feedback-ID: ie0a040ee:Fastmail
Message-ID: <bb3b94da-afc7-438d-8940-cb946e553d9d@eisentraut.org>
Date: Wed, 24 Apr 2024 14:57:15 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Refactor libpq state machine for negotiating encryption
To: Heikki Linnakangas <heikki.linnakangas@iki.fi>,
 pgsql-committers@lists.postgresql.org
References: <E1rtdlT-001383-HT@gemulon.postgresql.org>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <E1rtdlT-001383-HT@gemulon.postgresql.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/bb3b94da-afc7-438d-8940-cb946e553d9d%40eisentraut.org>
Precedence: bulk

On 08.04.24 03:25, Heikki Linnakangas wrote:
> Refactor libpq state machine for negotiating encryption
> 
> This fixes the few corner cases noted in commit 705843d294, as shown
> by the changes in the test.

Either this or something nearby appears to have broken the error 
reporting from psql or libpq when failing to get an SSL connection:

PG16:

psql 'sslmode=require host=localhost'
psql: error: connection to server at "localhost" (::1), port 65432 
failed: server does not support SSL, but SSL was required

master:

psql 'sslmode=require host=localhost'
psql: error: connection to server at "localhost" (::1), port 65432 failed:

(sic, the output ends after the colon).

This commit removed that detail error message string from the code, but 
I don't see any similar message that would take its place.