Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sYQNE-00BFa6-0o for pgsql-committers@arkaria.postgresql.org; Mon, 29 Jul 2024 13:25:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sYQNC-0005Wi-HM for pgsql-committers@arkaria.postgresql.org; Mon, 29 Jul 2024 13:25:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sYQNC-0005Wa-AV for pgsql-committers@lists.postgresql.org; Mon, 29 Jul 2024 13:25:10 +0000 Received: from lahtoruutu.iki.fi ([2a0b:5c81:1c1::37]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sYQN9-0022Me-3j for pgsql-committers@lists.postgresql.org; Mon, 29 Jul 2024 13:25:09 +0000 Received: from [192.168.1.122] (dsl-hkibng22-54f8db-125.dhcp.inet.fi [84.248.219.125]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: hlinnaka) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 4WXfH36KDzz49Pxq; Mon, 29 Jul 2024 16:25:03 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1722259503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x8TcZhW01ROK20/39dpyXP2n35ZVaY8oh9QeYP11Xo4=; b=j5bQ8GmEaUmktH5jL9u8vor7bToFl0M7r/13LGZOPX2qlS5wD2HBD0bpZWdgbai40AcCcK luoUa6luLXErkYc5jHkPDvH8duJFlGTzkp6HNW5Xjij1zOXU058Hc5CgjMV8WjamjS5nan +7/f/HsqGJiL+vKDI92gGx9i8TOblqKQxFpxbB4YPKY2LxIikd1vwWXfdr4Z/JA5bjABuf ylXnmhktR0opKVusGF/btSefRn/T5ZJJA+afAh4hwEuWOd85nUPzvoUZtdrwwwzTNWn82j Zn1xPiwn08zcKg7ga7UKU4Cl0IxbwPicuDFlHUzrYEAbKb1TXwOa+5N1NHfa4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1722259503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x8TcZhW01ROK20/39dpyXP2n35ZVaY8oh9QeYP11Xo4=; b=DjVAw4tgZ0WboHF887kKcNGIqFZ1Ey6qWUnsVcW4c3wX7VQXZQ1PyMOZ/D735+o15+6D+c E5Bq/3jFH+NJZzszhIGDIODq2184RRKz1Ie2rlCAJAmkQTqYdYxqz7v0Ua4aItjn86NU32 TrU7G3ivW1ikKLQY2qKeWiLYA0Md/Mqe8NOzauoZ/cto7RAZSieo4GWjM2ymWOpDnQBEwF 9VUutijyoJEYj+MCjYYl/r48r13ycMfm9oGuM8P+hl3BIT8sD8aVNclMmjn1BidwyHzxGR f4TB06pbiNgo7vmarJvtTnWffxOch1sIaAFEF7LxIZFNN5ljeDyr8cPA9zgfEQ== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=hlinnaka smtp.mailfrom=hlinnaka@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1722259503; a=rsa-sha256; cv=none; b=M05wK5luQcyikX1OBfwW5VLhM+HhwH32ZvAJqjLjTXp1xAOu8BVRf8xmjxVEgLuJmAieJa 49GZd7K2XelVP+AAHxiDLUjVLKuggwXxjjIO/ZiP2mvOBL+c5Hl9UlpNOd/Bl9fwotNL8o fN3lKBXshT+HmFmKyGUp5Tac+/kmBdaM7Hbqvn4JzPGBvAy+j+/1BMYydrz0x/LRy5WeML ZiOX8rau1lwBJu6oQYM/HqKOCPmvyqJ16XQFiX6SJbaL1N0PM2xnkpPm2ZQoszTjVRoH48 MyKi6sapL16XQPj4i9L/ol9qAM/y63HZ8FY/pIFsPLVpaRL66VawhGieG5xohQ== Message-ID: Date: Mon, 29 Jul 2024 16:25:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pgsql: Move cancel key generation to after forking the backend To: Daniel Gustafsson , Heikki Linnakangas Cc: pgsql-committers@lists.postgresql.org References: <1156B285-B81B-4A5F-A1FE-F1616D216C68@yesql.se> Content-Language: en-US From: Heikki Linnakangas In-Reply-To: <1156B285-B81B-4A5F-A1FE-F1616D216C68@yesql.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 29/07/2024 16:23, Daniel Gustafsson wrote: >> On 29 Jul 2024, at 15:18, Heikki Linnakangas wrote: >> >> Move cancel key generation to after forking the backend > > longfin seems a tad sad about this one: > > procsignal.c:87:3: error: redefinition of typedef 'ProcSignalHeader' is a C11 feature [-Werror,-Wtypedef-redefinition] > } ProcSignalHeader; > ^ > ../../../../src/include/storage/procsignal.h:77:33: note: previous definition is here > typedef struct ProcSignalHeader ProcSignalHeader; > ^ > 1 error generated. > make[4]: *** [procsignal.o] Error 1 Yep, thanks, just noticed and fixed it myself. I should add that to the list of compiler options I use... -- Heikki Linnakangas Neon (https://neon.tech)