Feedback-ID: ie0a040ee:Fastmail
Message-ID: <bc8d647f-15fa-4a0a-a325-1444495be952@eisentraut.org>
Date: Mon, 5 Feb 2024 15:50:02 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Generate syscache info from catalog files
Content-Language: en-US
To: Aleksander Alekseev <aleksander@timescale.com>,
 pgsql-committers@lists.postgresql.org
Cc: Tom Lane <tgl@sss.pgh.pa.us>
References: <E1rSAY2-002hIk-4y@gemulon.postgresql.org>
 <4020891.1706018887@sss.pgh.pa.us>
 <d428972e-cb82-4dd8-ba2e-5f695c020752@eisentraut.org>
 <4049175.1706027790@sss.pgh.pa.us>
 <CAJ7c6TMDGmAiozDjJQ3=P3cd-1BidC_GpitcAuU0aqq-r1eSoQ@mail.gmail.com>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAJ7c6TMDGmAiozDjJQ3=P3cd-1BidC_GpitcAuU0aqq-r1eSoQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/bc8d647f-15fa-4a0a-a325-1444495be952%40eisentraut.org>
Precedence: bulk

On 05.02.24 13:48, Aleksander Alekseev wrote:
> Hi,
> 
>>> I have found that the files are not listed in the clean target in
>>> src/include/Makefile.  That might explain it, but it's gotta be fixed
>>> anyway.  I'll go ahead with that.
>>
>> Looks like that made guaibasaurus happy, but I'm still mystified
>> as to what was wrong and why it didn't repro elsewhere.
> 
> I noticed that catalog/syscache_ids.h is not installed when using
> Meson. This breaks 3rd party extensions like this:
> 
> ```
> In file included from
> /Users/eax/projects/c/timescaledb/tsl/test/src/compression_unit_test.c:19:
> /Users/eax/pginstall/include/postgresql/server/utils/syscache.h:23:10:
> fatal error: 'catalog/syscache_ids.h' file not found
> #include "catalog/syscache_ids.h"
>           ^~~~~~~~~~~~~~~~~~~~~~~~
> ```
> 
> It seems to me that include/catalog/meson.build should be modified,
> however syscache_info.h *is* installed and I don't see why it would be
> processed differently from syscache_ids.h.

The code had this backward accidentally: syscache_ids.h should be 
installed, but syscache_info.h not.  I have fixed this.  Thanks.