From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Subject: Re: pgsql: Add test for postmaster crash restarts.
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
 pgsql-committers <pgsql-committers@postgresql.org>,
 Craig Ringer <craig@2ndquadrant.com>
References: <18695.1505840008@sss.pgh.pa.us>
 <D2FBABBF-F0E3-43FE-8EA4-E2431DD6EEBA@anarazel.de>
 <20170919174232.soc2skrqxxdtnh22@alap3.anarazel.de>
 <21486.1506601297@sss.pgh.pa.us>
 <5ce9b1f4-dff8-6fe9-74ab-d8e1b993b1d5@2ndQuadrant.com>
 <20170930221043.iay4s7rmwm5l7wiw@alap3.anarazel.de>
 <56b65da3-f7cc-494c-7952-ba5f6c804d7e@2ndQuadrant.com>
 <20170930222712.xgdgxnt4sjvig5mn@alap3.anarazel.de>
 <20170930224424.ud5ilchmclbl5y5n@alap3.anarazel.de>
 <75777957-d16f-f799-d0ec-bc3d5b7c72de@2ndQuadrant.com>
 <20171001023214.zgw3gs7mxjmlkqcd@alap3.anarazel.de>
Message-ID: <c5341caf-4b75-dfb2-8bf8-449cf1859d65@2ndQuadrant.com>
Date: Sun, 1 Oct 2017 16:32:24 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20171001023214.zgw3gs7mxjmlkqcd@alap3.anarazel.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-MW
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org


On 09/30/2017 10:32 PM, Andres Freund wrote:
>> Haven't tested on MSVC but with this patch it passes on jacana (mingw).
> Yay!  Thanks for testing.
>


I have now tested on bowerbird (MSVC) and it passes. This suggests that
we can run tests there in cases where we can use IPC::Run's finish()
instead of kill_kill(). Perhaps someone would like to look at the the
two other cases where we do that (recovery/t/011_crash_recovery.pl and
recovery/t/006_logical_decoding.pl) and see if they are amenable to this
treatment. It woould be nice to be able to run all the tests on all
platforms.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers