Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHp0m-00031u-UR for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Feb 2022 15:36:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nHp0l-0000xc-7E for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Feb 2022 15:36:03 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHosq-0004gS-A6 for pgsql-hackers@lists.postgresql.org; Wed, 09 Feb 2022 15:27:52 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nHosj-0000lG-5F for pgsql-hackers@postgresql.org; Wed, 09 Feb 2022 15:27:51 +0000 Received: by mail-ej1-x632.google.com with SMTP id ka4so8285942ejc.11 for ; Wed, 09 Feb 2022 07:27:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=L/CcKHEbnuC9rBZuAcDMPuYCHWmx4Y07zEb3IGc/zOY=; b=i+3D2i8ds8CmWIzvG3tRrZ4OAnuTPACCUBm1nkWBuVhQUcliIcaLu4v7YAoivBgAeG jWCd7IuCmzzaNJOgmLBEmLtbFfa8+GARdT0UXxXX6eQYoTbiNGVSmAiU20SQHBHuenrH d9N2aALKBjsXsi155NuqsOyiu9sXEwnWHcTX/L4xc+qJNfXzqPJ1n5aNNfjPVkv9yA13 9qZFfG5KMBZbM1gX/rUoQzasYj2ZsZ0lOdCE42bE6F5JMH1GwmdXWsCx7w483vZzG5tZ 2a1wuddKPnQeFEy60eQ2nio0xZhVG8h+tEUoyPhPqq00LwlWRttwwG90B3ShSTeGWmei L1Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=L/CcKHEbnuC9rBZuAcDMPuYCHWmx4Y07zEb3IGc/zOY=; b=bqZPMy0FeK/TO9huvys2j0S29kzY30rTOXJE31sZ3lhjlXV4p2vpNO9KhtQzEz1tIL kZ1D5/jqVQ2/MvwzbQ2lM8JxUerMAbH9js9P+oB6hbX+Ar4Dj981r+xJyV9MkeYngNXP VBQ4YNFMjKxz/kU+zqRBkIYQGCfmBQLfevNjYdahSF5TDe4T1NGtpBQuQ5tiPEUDzpp+ 3/RvJi8jrjsEMa3Av5RWvZECnttai5MfSTX1OG/ULpCHkktOQ+Z9DnlVRR9GD/Jc7q9J zMqLwCZL6NaqX+NOzF0SNRqXZo1AFyZtov7ZJOrB1nDwHHfji2Mlcg05G49/IcEVKT8x TOxA== X-Gm-Message-State: AOAM532Fwiw5/zrVY8hQoL7+aW54Zx22WaQbXkDU68csQzV1LClS6p9G LQIsRpN1tHDzterMpk62mxgWJXulxGJm52gsCKcCbYjreJPrXuhrLqNPjiWy9gRr90xKJsilArV hnUHG6TQahkbEQutGr06vkZy6vz54nToOuOSgIKnrwaLhIU9n/hcvsg+/KLDjmUPicR4znxFufW 3XizhtasFfPS4JPwRnjxonyIDGxA6m8o8HxPG8rpTkiGql X-Google-Smtp-Source: ABdhPJyZceNFuB69wDE5AYreCDPM1tMYugkR1XkGUjSGZInu64kK2WSvJ9kndkAYAHaBdawjv88yug== X-Received: by 2002:a17:906:5d14:: with SMTP id g20mr2391549ejt.37.1644420463298; Wed, 09 Feb 2022 07:27:43 -0800 (PST) Received: from [10.137.0.18] (static-84-42-175-93.net.upcbroadband.cz. [84.42.175.93]) by smtp.gmail.com with ESMTPSA id bm4sm6767044edb.21.2022.02.09.07.27.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Feb 2022 07:27:42 -0800 (PST) Message-ID: Date: Wed, 9 Feb 2022 16:27:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR Content-Language: en-US To: Noah Misch Cc: Andres Freund , pgsql-hackers@postgresql.org, pgsql-committers@lists.postgresql.org References: <20220209004347.mnwaoiv5x7dntuvi@alap3.anarazel.de> <20220209020403.GA3002372@rfd.leadboat.com> <20220209054141.GA3058164@rfd.leadboat.com> From: Tomas Vondra In-Reply-To: <20220209054141.GA3058164@rfd.leadboat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2/9/22 06:41, Noah Misch wrote: > > The explanation was more boring than that. v13 and earlier have an additional > InvalidateSystemCaches() call site, which I neglected to update. Here's the > fix I intend to push. I tried this patch on 10 and 13, and it seems to fix the issue. So +1. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company