Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sYSIr-00BVHS-Tq for pgsql-committers@arkaria.postgresql.org; Mon, 29 Jul 2024 15:28:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sYSIq-000gGu-26 for pgsql-committers@arkaria.postgresql.org; Mon, 29 Jul 2024 15:28:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sYSIp-000gGm-Qj for pgsql-committers@lists.postgresql.org; Mon, 29 Jul 2024 15:28:47 +0000 Received: from lahtoruutu.iki.fi ([2a0b:5c81:1c1::37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sYSIn-0025Wg-7N for pgsql-committers@lists.postgresql.org; Mon, 29 Jul 2024 15:28:47 +0000 Received: from [192.168.1.122] (dsl-hkibng22-54f8db-125.dhcp.inet.fi [84.248.219.125]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: hlinnaka) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 4WXj1l4Msfz49Q0G; Mon, 29 Jul 2024 18:28:43 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1722266924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3A6QXrWl+4DMPV500C8ZxnmOb2o7gUStsGpiyXChUP0=; b=dZtiE+0FoEwPE1EadBXM95g1cRGnmbN61pCNQqeWyyI3nk14VfxzpBWCaFvj2SD5Z36hYS tsJOERcnBztqUTsS61FhmAqT54Fx7kyz6aHY/lBRHsHO+SjgZvWwJcwUkwPTteqphQSmI4 hP78e19BDuS61LZT5fMJfr2zM6jGU4V7RfhW8nV2o+BzwFGQpqZCib4LW6XjPVf3bQPe1h 5rVnB8tVEXYSji1wsZBd1ilUvdbOZS1vRGNFJmiYZV6vcjKLGyqMop7GB/Ff5EQkLnDICC 5sN14UXDaq6SmRn1IDEB96qw0FznOMumbfJwY3QbI0IJ4fynKdjhBFCDQQ5esQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1722266924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3A6QXrWl+4DMPV500C8ZxnmOb2o7gUStsGpiyXChUP0=; b=O1aLbMmWGtY3JZLdhi9bgKsbdqUKGitvZjC8+mm5INMACP5M3ep/9PhF3Bmw1ncWfYPGQk e+xr01MZMW2fQbmWq+DzGHqnmOMT9QMZATvyVbmXdzkmtowyVXMVEjIn2vtQmwIGXLmdW2 sTtDiSsezxPaTSmX7QQBv7iiEgzPhp3sjXAwRcJiAialnLM2Z3jC2dOwaKM8HHrPytLkhI m9uShyd2OWEByjXDXgIRIfyEr17f1QWf0jKzsPVGTEEUVuqbloXNVLpaO7YSt+3Hv+iMt6 /CKry9oi+vTto3x4hPFerHCntM2D2VF9htM8yoTJ8V4yhAybyy2O0yFny/5yXg== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=hlinnaka smtp.mailfrom=hlinnaka@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1722266924; a=rsa-sha256; cv=none; b=ob69gXh5mnf5TeSt61GOb01NcI/Fifdr04E+svY4K+IRhJP9UwzcL7yW9RASB0jJyMsZx0 sYVcHMqpNsRkYo2OisEIs3NIVbsrS1afZ++sdBLmYKUaJOcPItheFdMB5osnfPaFt9GDfy BKneg1XGoeWf3vBRuRP/eA/TKkb35erK5H8v49sYMwYAy55xjTzjU7G8TovHDNErJrbX+F 2+1T1uMTQRsmLr1a1FYCnH87Q+ijDB+axCR9HMkqWM3AK9Vt8et2W0TEIHWRXwNZUBGPkK NwDyk8n/x6HFCy/g/gK64tsdGsE+ha2u4uxN6W8PEALW/TaOoPG2qMrDZMevkg== Message-ID: Date: Mon, 29 Jul 2024 18:28:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pgsql: Move cancel key generation to after forking the backend From: Heikki Linnakangas To: Daniel Gustafsson Cc: pgsql-committers@lists.postgresql.org References: <1156B285-B81B-4A5F-A1FE-F1616D216C68@yesql.se> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 29/07/2024 17:30, Heikki Linnakangas wrote: > On 29/07/2024 16:25, Heikki Linnakangas wrote: >> On 29/07/2024 16:23, Daniel Gustafsson wrote: >>>> On 29 Jul 2024, at 15:18, Heikki Linnakangas wrote: >>>> >>>> Move cancel key generation to after forking the backend >>> >>> longfin seems a tad sad about this one: >>> >>> procsignal.c:87:3: error: redefinition of typedef 'ProcSignalHeader' is a C11 feature [-Werror,-Wtypedef-redefinition] >>> } ProcSignalHeader; >>> ^ >>> ../../../../src/include/storage/procsignal.h:77:33: note: previous definition is here >>> typedef struct ProcSignalHeader ProcSignalHeader; >>> ^ >>> 1 error generated. >>> make[4]: *** [procsignal.o] Error 1 >> >> Yep, thanks, just noticed and fixed it myself. I should add that to the >> list of compiler options I use... > > The --disable-spinlocks animals are still failing, however. Weird. I can > reproduce it locally, and started to debug but I have no clue what's > wrong. I'll keep debugging, but I'm all ears if anyone has ideas. Found & fixed. I released the spinlock twice in EmitProcSignalBarrier. Oops. I'm a little surprised there isn't an assertion for that. Would be useful. This might have gone unnoticed for a long time if not for the --disable-spinlocks implementation, and we've been talking about removing that. -- Heikki Linnakangas Neon (https://neon.tech)