Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1trlt8-009HfG-QR for pgsql-committers@arkaria.postgresql.org; Mon, 10 Mar 2025 22:46:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1trlt6-001m1A-VQ for pgsql-committers@arkaria.postgresql.org; Mon, 10 Mar 2025 22:46:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1trlt6-001m0L-KD for pgsql-committers@lists.postgresql.org; Mon, 10 Mar 2025 22:46:20 +0000 Received: from mail-qv1-xf2b.google.com ([2607:f8b0:4864:20::f2b]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1trlt1-0027YQ-1Q for pgsql-committers@lists.postgresql.org; Mon, 10 Mar 2025 22:46:18 +0000 Received: by mail-qv1-xf2b.google.com with SMTP id 6a1803df08f44-6e90b8d4686so19164856d6.2 for ; Mon, 10 Mar 2025 15:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dunslane-net.20230601.gappssmtp.com; s=20230601; t=1741646775; x=1742251575; darn=lists.postgresql.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qh8wVBXPdxM+J+xDtBOGB6/rhkoWv1MLSZ49UVwCMpI=; b=pvB++FTW2je/KfrFxtHzwJpuUMXGIDeKchibh3Z19Zxog74wjMaaqlFXx424w1lcU7 UHb4YSmgIEiXEkIukZuvCxdwnOGVOungdTNhUZ4qxiogiTVIxCd2DFxvDVFqxJ+Rpu5X mbv+vKdt1PHHn36lc+bMMrqzkuxfyk1tGiEXmGmo1cL3zWiagRM4QfXDfCTzHhjbh2Ic jQp0g/aoIoEDmMOBOmVzJeXl8iAnLBQCpnm8CEnoP7NlQQ0Hofg6VvJZWSe0V9hoDAyv d0hhV3BPM3kiCBy7XnfnSFt1AcBhbyPBxMhFwccFmm7vupuaq8S4QSQhaqJKn65Z9YXB cm8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741646775; x=1742251575; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qh8wVBXPdxM+J+xDtBOGB6/rhkoWv1MLSZ49UVwCMpI=; b=kR0enBaACmtXVbiFom/rRVsY7ws7zGkSWAuGfAvNHa6oCZhpcvc1jFUJ9Jae12QhMu RfC2Aa+SBvvogC+AIBgupKRGkIkzX41TKl55XTdVareq0JLDmXH1pp+PRdX9NuKMn4Rl Y6k+IjxHXexDTalmKjMYJvMbwl7sqw4pnNr4A2XFoIGGXPMpSymWfrlDkq833eI4ZM95 7Jkke5V9Zyha3z7ySiAOPsQq9p04SWMvdYAX3hfbEWin6dGE2gsuje/oIfzzyDWPJqxo uOPDofrmDylaVC+tCu9xj09lVB5uDZAWeRv/odGLlh0RdW5wj1F/RH/mE/8JF08cPKvh AdPQ== X-Forwarded-Encrypted: i=1; AJvYcCXDtdzm1uPiiK0ffSqmvs3IrBxJnm7QDO5aHW5XOLgRobj75OkNcGTtdzZViY7CxU9q81asRt4m4AGXOSonBj8r@lists.postgresql.org X-Gm-Message-State: AOJu0YyHLxYdFVKv4hKkHzNzIKTlR4ixCafSWavXW0MJC+QI7VnHXSII 4XXWVUtrGe9rJyaGI0zYndVnGoef7idnqNUTpjl0MoS1JAT0M4QLx8+tq6xdWKD0tbkpmFCEXzi + X-Gm-Gg: ASbGncst1uueBZxwjJsdsktknhNmQEtRewSeLEXv1+hB0+H4CGFUc0uTa29uGPhp1yS CFifVLUyG4tOxi5p8hIqYnLKZH+PeDFgpNzL1g/zuIpoXUojEdoLmcr9Mrv0J2cyzPrerYTFs+i fvhfe6+6a4LRDMnKCiq+zPP0zOUwXyxMhtq2FT3aNc2ByDG7MmXWXTTa+NWmy3feY3v40BWwL4v 1MZIYhlaI/kLD8iFcb1hT8et1bjBQDbjcyg7P5Qobzq7TvJB2OhmxHeURevJaUdRG3sAShCJLMj Wxeo9+diy6SFTJGqyFk4t+S2sIYywal8RXiKYFzZyIzX6KiU22hci2M= X-Google-Smtp-Source: AGHT+IFQP0ObA4sn38sMSoFvaY5owSu0bErvjzlfTZpskMKDtsg7ImSUkdLEV1BnHoDe4BaqQzbA9g== X-Received: by 2002:a05:6214:405:b0:6e1:a4ed:4b0c with SMTP id 6a1803df08f44-6ea2dd26c36mr17319596d6.26.1741646774848; Mon, 10 Mar 2025 15:46:14 -0700 (PDT) Received: from ?IPV6:2605:a601:a681:6b00::1cb? ([2605:a601:a681:6b00::1cb]) by smtp.googlemail.com with ESMTPSA id 6a1803df08f44-6e8f707c4cbsm64208766d6.22.2025.03.10.15.46.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Mar 2025 15:46:14 -0700 (PDT) Message-ID: Date: Mon, 10 Mar 2025 18:46:12 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pgsql: tests: Fix race condition in postmaster/002_connection_limits To: Andres Freund , pgsql-committers@lists.postgresql.org References: From: Andrew Dunstan Content-Language: en-US Autocrypt: addr=andrew@dunslane.net; keydata= xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAmwQTAQgARQIbAwIX gAIZAQULCQgHAgMiAgEGFQoJCAsCBBYCAwECHgcWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUC ZFlxxwUJGVGAbgAKCRCZ+n/LWfw7gXikB/9ZdcUy6CTBFIIuL/bVsc1eLEW/gJBjJBF6HxNY xgEkAgXAp4Lg4A5U+QB9GouFr7+GYxF0BU4hzoGhNPUWltxnHdMWP8nC/38LAqgMi8L/bbsm HW5YPBdWYaAZAPJQVfOAgjTbRUb26KSprpyrrJKW0ZmrZfjhNPcQ72jpWzoPLQqx2X6B0fru 1jq+cBh8lb6r1mJTim1T3JIn+F/v5VpdQS+EL8xqsHkfzKjIPsW3CIXpkypSk6saA55Rkkbl 26AW8ftPVB0Q6Lnn6FLt9CP0MGNixBQ55yq8r1K+nCBvCCjvQjM8RDm0UUum0WNl+ifQgTLO E8TWEnwVtkBf+3QWzsBNBE7KWFkBCADRnOM0FCzsYW6jtncg+dWIagjUZpvaClmqn/sJluLa Q3v1VXMQJzYs3eC1gh386W+XBwLRpDj3jzH81lX+p73Re3d3oJW7X+ffsxuzu5ZVdMUkqBYo nkAbKxr6gyJ12F/+JkUVzLcoTN+d/7YsQvUVi7NaKH8mJgjz112O4fUe3p9wfAaFa0RXHc5S GPzRTYRRlv/XZBIho4J2tkZOnteZJZ+GbxQVlINt6fd8P6al3MWOvpP/ExJPguEfjOsO6Njy xjo3WfpD4lHMOR/Oc3/8mScEF84rF2jXbsFgelWnbPWAvXY+pD0dXOFRkagGmC/viwBDqq5b 5tk76kKmUbZxABEBAAHCwHwEGAEIACYCGwwWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUCZFlx 5wUJGVGAjgAKCRCZ+n/LWfw7gf+iB/4g8CPY5jihf5r/8EsoIGe2H+dpVmpPF8YGBzTIvCz/ fQoOq8AX/pE76QEuFnFZWfjw+wgBXgCVmkox2Eflkk6z4ND3pcwGZ6CfCxTQCDk/dij+2DQ4 6bmDCy/sBgcbz9mTpoLC11HLoPae6YN9nBNQRZDcEFEu54OaVOqlIdbA6m+POIBCXZdHOFc0 WoDTgxHRzC1jgQNidyd6tKqcsVJs0dzF0oKTmFFmUAqTdJO12LBuNA1rlqrR3EtpYk8B/wtS 5dIMD7Q8hwQpL+4C6GNpb6ZKnPkLi47pDOLhz2qBrqN+rqUEsT3YnExYpzj5yOBi+FlmV1Hw 49QYe1sn2ZPs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025-03-07 Fr 1:22 PM, Andres Freund wrote: > tests: Fix race condition in postmaster/002_connection_limits > > The test occasionally failed due to unexpected connection limit errors being > encountered after having waited for FATAL errors on another connection. These > spurious failures were caused by the the backend reporting FATAL errors to the > client before detaching from the PGPROC entry. Adding a sleep(1) before > proc_exit() makes it easy to reproduce that problem. > > To fix the issue, add a helper function that waits for postmaster to notice > the process having exited. For now this is implemented by waiting for the > DEBUG2 message that postmaster logs in that case. That's not the prettiest > fix, but simple. If we notice this problem elsewhere, it might be worthwhile > to make this more general, e.g. by adding an injection point. > New test breaks when log_error_verbosity=verbose. It's adding an SQL ERRCODE to the DEBUG string. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com