Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pfls6-000719-VG for pgsql-committers@arkaria.postgresql.org; Fri, 24 Mar 2023 18:10:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pfls5-0005po-3D for pgsql-committers@arkaria.postgresql.org; Fri, 24 Mar 2023 18:10:37 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pfls4-0005nJ-Ns for pgsql-committers@lists.postgresql.org; Fri, 24 Mar 2023 18:10:36 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pflrx-0006Jl-LJ for pgsql-committers@lists.postgresql.org; Fri, 24 Mar 2023 18:10:35 +0000 Received: by mail-pl1-x636.google.com with SMTP id bc12so2616302plb.0 for ; Fri, 24 Mar 2023 11:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20210112.gappssmtp.com; s=20210112; t=1679681428; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=SSufu38lAlDoRC9YTAkkdg3evEKA/UcUh3R2tyOchQo=; b=nJtWsMKSavpZ8su92yvuAG2uMpEQbB2akNwpoiby1tdwtub59rA5K+HIJ6uh9paxMw XN1aexxFKP9O5T2prn3MIrdUlsMrXfoez7jIOjVNFHf77qykg/5lm5K49AHxQKqimrSZ 8VgE1m4spl/nOQXAPO1ESsKx5ZqgtZ9IKw3l1P7eHam2HeEbkjQ5g3bV8nIYSiu0r7o3 VVzseG27V4eT9uZg7ZslpuI0WtExe586N0dU0yrgq3ZSpl/9BnqM0dG0CPvCqX/pHpns GlUbcXc7uu3/Si7xbMLY8P0WAlAwoakAb4WmlAC0utqjvhzb8jKj/w/irIUSYx6cQPFz rJfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679681428; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=SSufu38lAlDoRC9YTAkkdg3evEKA/UcUh3R2tyOchQo=; b=33N1cW3rvQnnD9k3axO2KCZY5gJlB1akxcdsIKEgPaR4QJ2g7h4azxjCla7IpDxHSr QFnH1Gw5XKg3aBVpJrqeaMHv8zbC+ViZCEdiWOa2vwuJUcsaCdSoxQr9hCN+lLoO7X/+ 8Sr7dyTfhQylJmQ+r13NaE9FFM82pLaBdgCfawYYoVRVPeljxDRcemZ4C7snAiL/ez4V dIPzqbNuy3ZSALc9JMvDhiFosPlHj8bft9HyyqUCVJX1s5DboMHKMuJUjLCCaT1OBGq1 11fk0yOljeIpypjIalkwxKqB1nKYrSZsyYtH6zLL4hzaBvSF8gO0zm2bN7XQKgNXy8F6 K+AQ== X-Gm-Message-State: AAQBX9cxde1uN8NgPeYfzSMqXTFoax4lcHreeram3iAMAlbz56cyf6HJ mFlbk+BgowqE6/yvAzchFccFXA== X-Google-Smtp-Source: AKy350bB2OFql8ePIcG2Kr8Jj/Swyo25a/AZnTDqEHWNWqBjFDEOieim70C7b3O04QyC+PKXw3sOCQ== X-Received: by 2002:a17:902:f904:b0:19e:31a3:1a87 with SMTP id kw4-20020a170902f90400b0019e31a31a87mr2325005plb.39.1679681428014; Fri, 24 Mar 2023 11:10:28 -0700 (PDT) Received: from jeff-laptop.lan (c-73-70-96-208.hsd1.ca.comcast.net. [73.70.96.208]) by smtp.gmail.com with ESMTPSA id p8-20020a1709026b8800b001a19bac463fsm14463443plk.42.2023.03.24.11.10.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 11:10:27 -0700 (PDT) Message-ID: Subject: Re: pgsql: Handle the "und" locale in ICU versions 54 and older. From: Jeff Davis To: Tom Lane , Jeff Davis Cc: pgsql-committers@lists.postgresql.org Date: Fri, 24 Mar 2023 11:10:26 -0700 In-Reply-To: <1862096.1679592341@sss.pgh.pa.us> References: <1862096.1679592341@sss.pgh.pa.us> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, 2023-03-23 at 13:25 -0400, Tom Lane wrote: > Hmm, should we back-patch this?=C2=A0 Seems like existing branches would > be even more at risk than v16, because more likely to be built with > old ICU.=C2=A0 OTOH, we do also run the risk of breaking installations > that weren't broken before. I wondered the same thing[1] but ultimately figured the risk outweighed the reward. My reasoning (which I didn't post before) was: If a user currently has a collation with locale 'und', and ICU <=3D 54, they are getting their actual locale from the environment. If we backpatch, it will silently change their locale to be the root locale, which could be different, and break their indexes. That seems too dangerous for a minor release. For a major release it's more tolerable to put something like that in the release notes. Fortunately, I think most users now are probably using the built-in collations, or using the empty string before an "@" to specify the root locale, which works in all ICU versions. Users would only specify it as "und" if they happen to know about language tags. Regards, Jeff Davis [1] https://www.postgresql.org/message-id/9afa6dbe0d31053ad265aeba488fde784fd5b= 7ab.camel@j-davis.com