Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jGUx1-0006Fm-7B for pgsql-committers@arkaria.postgresql.org; Mon, 23 Mar 2020 21:49:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jGUx0-0003Yj-1G for pgsql-committers@arkaria.postgresql.org; Mon, 23 Mar 2020 21:49:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jGUwz-0003Yc-Mg for pgsql-committers@lists.postgresql.org; Mon, 23 Mar 2020 21:49:37 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jGUwx-0004tt-7G for pgsql-committers@lists.postgresql.org; Mon, 23 Mar 2020 21:49:37 +0000 Received: by mail-pf1-x443.google.com with SMTP id i13so8202032pfe.3 for ; Mon, 23 Mar 2020 14:49:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=8jIiA0CuO18Zo6D4dJXGZ0xb3tA31pkvBDo5FZFnRXU=; b=qykBTRcN8wZuFASvMJUetcQbpiZ7p+Kz1+IJd0MTf62TivJ70/y+223SrXvrvzIBY1 8fXuYqAEynnyOP9U3yeaHPwktUOviGP7eEi1+PAdRqO31ehxmlYfXt93fXCJttg4FikR Nb5tuzkEf6AQhzJIo672xIKE93qN565tcT/xjydlwVC9VfkZ+ghlOeDK/WtWVvh+mCRC Odk4EvBJMcKlbufYzdHAJvCcknNdHDXHkv0GjZlhWgc+uRJuWDvUQK8e86+lYaNp8D3S 7Pbu9KfM1BPPg2TEF9KVMpQ8EsavVX9q4SitfPYDLn0OsQG/lrjiL12wJo4S8wBQSN4Y Arsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=8jIiA0CuO18Zo6D4dJXGZ0xb3tA31pkvBDo5FZFnRXU=; b=C4m8FELS58rHGzOi6LXNOhz5Iq8u22JZreMKbrr++p7vUP/Id7Zu67Esa6wmqdMkY7 OU4fGzRTKDpAoU0spb1/4KzL6shrekbkSSgrDAepgaWyoADIrQ56hSxLYlcO7QXaZG5z IP+3jl6nO55SZ3feMeWUMFdRDYHGKAmUsDq2o8ImAeykUorsK1UNl+bt644pw4KfV/ru 3UkGPTxPc1qcElmlTKd3TPBQqq+v1iqY1dFZzimhj/3GAaXdRAIe7CcX9o7IvLUMKbmM CbcuoE1aVKRbunKx2iN4HzyTHsa1IqOc96VzkzHAbHBudVn+VuwCXZ9go7KP4UfT9O/v I5Xw== X-Gm-Message-State: ANhLgQ2AwvdEAtolyo4Iy+jr74YF7z/NEvvkzng1jvIE23+yGBJoFO1V VSEbo8Wv38/6xTSY2sHGAWbUkIMX6Qs= X-Google-Smtp-Source: ADFU+vsufrQXSYg9W+5YPi85wUcHT6WaoKEFMPauVk8pnXO70f/6XcuLswrXMSBs0Ldx8hjpL4JXnQ== X-Received: by 2002:a65:490c:: with SMTP id p12mr23752751pgs.337.1585000172139; Mon, 23 Mar 2020 14:49:32 -0700 (PDT) Received: from jdavis.lan (c-73-231-146-4.hsd1.ca.comcast.net. [73.231.146.4]) by smtp.gmail.com with ESMTPSA id b17sm14422398pff.81.2020.03.23.14.49.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Mar 2020 14:49:31 -0700 (PDT) Message-ID: Subject: Re: pgsql: Disk-based Hash Aggregation. From: Jeff Davis To: Tom Lane , Jeff Davis Cc: pgsql-committers@lists.postgresql.org Date: Mon, 23 Mar 2020 14:49:29 -0700 In-Reply-To: <23196.1584943506@sss.pgh.pa.us> References: <23196.1584943506@sss.pgh.pa.us> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Mon, 2020-03-23 at 02:05 -0400, Tom Lane wrote: > If there's no way to test the feature in some significantly-cheaper > way, > perhaps we should move this test out to a separate script that's not > run > by default. I'll rework the tests. I wanted to be a bit more aggressive about testing right after the checkin to shake out any problems, but I don't think that's necessary any more. Regards, Jeff Davis