Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2RTL-0006Ze-7b for pgsql-hackers@arkaria.postgresql.org; Fri, 26 May 2023 07:02:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q2RTI-00072R-88 for pgsql-hackers@arkaria.postgresql.org; Fri, 26 May 2023 07:02:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2RTG-00072B-Kh for pgsql-hackers@lists.postgresql.org; Fri, 26 May 2023 07:02:43 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q2RTB-002EPx-1L for pgsql-hackers@lists.postgresql.org; Fri, 26 May 2023 07:02:41 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 8928F5C006B; Fri, 26 May 2023 03:02:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 26 May 2023 03:02:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to; s=fm3; t=1685084555; x=1685170955; bh=pFoLzUSswJc+TA/hsdc98utn/ W5yrvaCUFz2CesrPf8=; b=dE3a4RUTPR9rfYXi1fF3bQ5UOZZd/qTU2jzFUw07H 8711E4UDb/FDKTK/2HThg0iR3UXHvjP4ciRRYzAnqyelhIjDr29BnuZdVaXJ4emz FFoNVnPcBzoab61R1bkGAzpQRER7Bp/clH/1yEy27ugIgSRFNFHsaiFsOBPg9weg bxKOhBK8LjC8KyZ2ofb5Y0LYDqg2qrHppZa1kHC3nSw+Q0kDG3bMK2CsUs4/gKb7 2TBa2PHyYbhK7mvvq2Pk4R1gdqIGS4rfJjasI4+6qqmEQxL4pLXT86/fqXM945c1 R/5PFDto108aEhSBCenWETtKBi4fbNiAc7XQ0AEnyis9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1685084555; x=1685170955; bh=pFoLzUSswJc+TA/hsdc98utn/W5yrvaCUFz 2CesrPf8=; b=nBkHM14l2iOS7iqWMtxmq+wKC+GOESkknr6MJaJNLcDj9iBZWZo 5yurDXcooPUHPXlHibGL3bLnUdoSTbPfcedh45Qmbw5u9TcSyaXLJWp82q2GnKKu fbIOJYHH3F/T0j89xKZmR+TRwkH/LVavw6CANj+RA+H/nQve7SnpGqH2HaDCKcBR CNwloFqUUkXO1t7orgI+WazXhyUszlmm9gmVeFYgq8BUf5m0xYZIC5DxDXW5OlI7 varfwnx6y4NEvulmsN2ptJ5mUD7i8cigpg3PxsO1b/wyTnb+PQHjalP1ecq2c76r Bmk5ewoKl1C6WIAwyiESb0n90Z5LAVwHomw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejkedguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomheprfgv thgvrhcugfhishgvnhhtrhgruhhtuceophgvthgvrhesvghishgvnhhtrhgruhhtrdhorh hgqeenucggtffrrghtthgvrhhnpeehieeuhfelleefieekheekgfekgefgveehuedvjeev tedtgeelkeffffeikeeutdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgh X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 26 May 2023 03:02:34 -0400 (EDT) Message-ID: Date: Fri, 26 May 2023 09:02:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: testing dist tarballs Content-Language: en-US To: Andres Freund , Tom Lane Cc: Christoph Berg , PostgreSQL Hackers References: <933499.1684853190@sss.pgh.pa.us> <20230523184157.ao4ytkwqxkgp3glk@awork3.anarazel.de> <974623.1684867863@sss.pgh.pa.us> <20230524212437.jm6e3iiehtehivbh@awork3.anarazel.de> From: Peter Eisentraut In-Reply-To: <20230524212437.jm6e3iiehtehivbh@awork3.anarazel.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 24.05.23 23:24, Andres Freund wrote: > First thing I noticed that 'make dist' doesn't work in a vpath, failing in a > somewhat obscure way (likely because in a vpath build the the copy from the > source dir doesn't include GNUMakefile). Do we expect it to work? I don't think so. > Separately, it's somewhat confusing that we include errcodes.h etc in > src/backend/utils, rather than its final location, in src/include/utils. It > works, even without perl, because copying the file doesn't require perl, it's > just generating it... The "copying" is actually a symlink, right? I don't think we want to ship symlinks in the tarball?