Feedback-ID: ie0a040ee:Fastmail
Message-ID: <cd594df7-e677-4e35-9a28-e9e929110339@eisentraut.org>
Date: Thu, 6 Nov 2025 10:56:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong
 thing
From: Peter Eisentraut <peter@eisentraut.org>
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
 pgsql-committers@lists.postgresql.org
References: <E1vEsbx-004QDO-0o@gemulon.postgresql.org>
 <e6129aad-0085-4bc3-8b5f-63fbee7b488a@eisentraut.org>
Content-Language: de-DE, en-US
In-Reply-To: <e6129aad-0085-4bc3-8b5f-63fbee7b488a@eisentraut.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/cd594df7-e677-4e35-9a28-e9e929110339%40eisentraut.org>
Precedence: bulk

On 04.11.25 11:40, Peter Eisentraut wrote:
> On 31.10.25 18:08, Álvaro Herrera wrote:
>> pg_createsubscriber: Fix error complaining about the wrong thing
>>
>> The code updates the system identifier, then runs pg_walreset; if the
>> latter fails, it complains about the former, which makes no sense.
>> Change the error message to complain about the right thing.
> 
> - pg_log_info("subscriber successfully changed the system identifier");
> + pg_log_info("subscriber successfully reset WAL on the subscriber");
> 
> Maybe that message has one "subscriber" too many?

I have fixed this.