Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYHmN-0005Xv-Li for pgsql-committers@arkaria.postgresql.org; Wed, 14 Sep 2022 02:05:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oYHmL-0002YI-6I for pgsql-committers@arkaria.postgresql.org; Wed, 14 Sep 2022 02:05:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYHmK-0002Y9-VO for pgsql-committers@lists.postgresql.org; Wed, 14 Sep 2022 02:05:28 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYHmI-0001jr-3g for pgsql-committers@lists.postgresql.org; Wed, 14 Sep 2022 02:05:28 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 1908D100003; Wed, 14 Sep 2022 02:05:21 +0000 (UTC) Message-ID: Date: Tue, 13 Sep 2022 22:05:20 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: pgsql: Fix perltidy breaking perlcritic Content-Language: en-US To: John Naylor , =?UTF-8?Q?Dagfinn_Ilmari_Manns=c3=a5ker?= Cc: Alvaro Herrera , pgsql-committers@lists.postgresql.org References: <8735cwncig.fsf@wibble.ilmari.org> From: Andrew Dunstan In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-09-13 Tu 05:25, John Naylor wrote: > On Mon, Sep 12, 2022 at 4:54 PM Dagfinn Ilmari Mannsåker > wrote: > >>> eval "\$hash_ref = $_"; ## no critic (ProhibitStringyEval) >> I didn't see this until it got committed, since I'm not subscribed to >> -committers, but I think it would be even better to rely on the fact >> that eval returns the value of the last expression in the string, which >> also gets rid of the ugly quoting and escaping, per the attached. > Hmm, interesting. I agree it's a slight stylistic improvement. I was trying to keep as close as possible to the original. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com