Message-ID: <cee01d26fe55bc086b3bcf10bfe4e8d450e2f608.camel@cybertec.at>
Subject: Re: pgsql: SQL-standard function body
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Peter Eisentraut <peter@eisentraut.org>,
	pgsql-committers@lists.postgresql.org
Date: Fri, 09 Apr 2021 19:44:47 +0200
In-Reply-To: <E1lUEF5-00027L-N4@gemulon.postgresql.org>
References: <E1lUEF5-00027L-N4@gemulon.postgresql.org>
Content-Type: multipart/mixed; boundary="=-VGwyBMKv5HwKGvtdqMwL"
User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/cee01d26fe55bc086b3bcf10bfe4e8d450e2f608.camel%40cybertec.at>
Precedence: bulk


--=-VGwyBMKv5HwKGvtdqMwL
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On Wed, 2021-04-07 at 19:53 +0000, Peter Eisentraut wrote:
> SQL-standard function body
> 
> This adds support for writing CREATE FUNCTION and CREATE PROCEDURE
> statements for language SQL with a function body that conforms to the
> SQL standard and is portable to other implementations.
> 
> [...]
>
> psql needs some new intelligence to keep track of function body
> boundaries so that it doesn't send off statements when it sees
> semicolons that are inside a function body.

This causes psql to fail to recognize the semicolon in the following
statement as the end of a statement:

  IMPORT FOREIGN SCHEMA x FROM SERVER y INTO z OPTIONS (case 'lower');

The cause is the "case", which is recognized as the start of a function
body.

Now you could argue that "case" is a reserved word, and I should
double quote it if I insist on using it as a FDW option, but it
is a regression.

Would it be an option to recognize BEGIN and CASE as starting a
function body only if they are *not* inside parentheses, like in
the attached?

Yours,
Laurenz Albe

--=-VGwyBMKv5HwKGvtdqMwL
Content-Disposition: attachment;
	filename*0=0001-Improve-psql-s-parsing-of-SQL-standard-function-bodi.pat;
	filename*1=ch
Content-Type: text/x-patch;
	name="0001-Improve-psql-s-parsing-of-SQL-standard-function-bodi.patch";
	charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSA4Yzk1NDQwOTA1YzAxYjhjOWVkOGI0NmVmMDFhMjRiMDFmMjQ1ODBkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h
dD4KRGF0ZTogRnJpLCA5IEFwciAyMDIxIDE5OjQwOjM2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g
SW1wcm92ZSBwc3FsJ3MgcGFyc2luZyBvZiBTUUwgc3RhbmRhcmQgZnVuY3Rpb24gYm9kaWVzCgpU
cmVhdCBCRUdJTiBhbmQgQ0FTRSBhcyB0aGUgc3RhcnQgb2YgYSBmdW5jdGlvbiBib2R5IG9ubHkK
aWYgd2UgYXJlIG5vdCBpbnNpZGUgcGFyZW50aGVzZXMuCgpUaGF0IGFsbG93cyBzdGF0ZW1lbnRz
IGxpa2UgdGhlIGZvbGxvd2luZyB0byBiZSBwYXJzZWQgY29ycmVjdGx5OgoKQUxURVIgRk9SRUlH
TiBUQUJMRSB4IE9QVElPTlMgKEFERCBjYXNlICd1cHBlcicpOwotLS0KIHNyYy9mZV91dGlscy9w
c3Fsc2Nhbi5sIHwgNSArKystLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBk
ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvZmVfdXRpbHMvcHNxbHNjYW4ubCBiL3NyYy9m
ZV91dGlscy9wc3Fsc2Nhbi5sCmluZGV4IDRlYzU3ZTk2YTkuLmRiZmNmYzg0ZTUgMTAwNjQ0Ci0t
LSBhL3NyYy9mZV91dGlscy9wc3Fsc2Nhbi5sCisrKyBiL3NyYy9mZV91dGlscy9wc3Fsc2Nhbi5s
CkBAIC04NzEsOCArODcxLDkgQEAgb3RoZXIJCQkuCiAKIHtpZGVudGlmaWVyfQl7CiAJCQkJCWN1
cl9zdGF0ZS0+aWRlbnRpZmllcl9jb3VudCsrOwotCQkJCQlpZiAocGdfc3RyY2FzZWNtcCh5eXRl
eHQsICJiZWdpbiIpID09IDAKLQkJCQkJCXx8IHBnX3N0cmNhc2VjbXAoeXl0ZXh0LCAiY2FzZSIp
ID09IDApCisJCQkJCWlmIChjdXJfc3RhdGUtPnBhcmVuX2RlcHRoID09IDAKKwkJCQkJCSYmIChw
Z19zdHJjYXNlY21wKHl5dGV4dCwgImJlZ2luIikgPT0gMAorCQkJCQkJCXx8IHBnX3N0cmNhc2Vj
bXAoeXl0ZXh0LCAiY2FzZSIpID09IDApKQogCQkJCQl7CiAJCQkJCQlpZiAoY3VyX3N0YXRlLT5p
ZGVudGlmaWVyX2NvdW50ID4gMSkKIAkJCQkJCQljdXJfc3RhdGUtPmJlZ2luX2RlcHRoKys7Ci0t
IAoyLjI2LjMKCg==


--=-VGwyBMKv5HwKGvtdqMwL--