Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1paSSw-0001gW-9d for pgsql-committers@arkaria.postgresql.org; Fri, 10 Mar 2023 02:26:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1paSSv-00033v-6c for pgsql-committers@arkaria.postgresql.org; Fri, 10 Mar 2023 02:26:41 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1paSSu-00033m-Ni for pgsql-committers@lists.postgresql.org; Fri, 10 Mar 2023 02:26:40 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1paSSr-0004Jj-5f for pgsql-committers@lists.postgresql.org; Fri, 10 Mar 2023 02:26:39 +0000 Received: by mail-pl1-x62e.google.com with SMTP id y11so4156348plg.1 for ; Thu, 09 Mar 2023 18:26:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20210112.gappssmtp.com; s=20210112; t=1678415196; h=mime-version:user-agent:references:in-reply-to:date:cc:to:from :subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=13F4TbnlIkiCjiF16jicJ/7xpjHVxKvEJGpxJLQoh7A=; b=5JdB0XNCuIiNHRpOVL25P9Cg0p2Mhf3YxvpFOLgo4ryoW1h7x1rXzwCVIKHNngiSNt 2svijB/jLtTYdh3plOTtnxYeb1RBTM0z2csR5eazL2iD+Ukb3DM8+ottibYnNfEalgCw tV9RsSxSy0hjJtrXizW3GG05VDWn24vW974pOYEDVluGmHPeyqA5LkX7NvbYuV93QKBs PpGrBmvC0u9+Q85dtktbK24ubHRpdkjoUtRxmWEeywx/VaBBgloR5CiKaXdAMgSsoK+Z k1b3k1cj0VmW0KxcWTwHoa79J2hh1fJKe3Folwrn2yFVAPju3CyvprjT22AEASDkPQAs gPew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678415196; h=mime-version:user-agent:references:in-reply-to:date:cc:to:from :subject:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=13F4TbnlIkiCjiF16jicJ/7xpjHVxKvEJGpxJLQoh7A=; b=dPWms5suTaypeI0Ipxb621h8Xo3JK7EOFmeQElDK4gEf0wx+scAB6aW+Y4t42Uvm3I U92YTm1mNXMuL/cBnmGlwb8C3XlEbDgpI+9S8t6l9cb1UZAPNUlko7WY6xCjI/rZKL3r Dw0mXtNH7QYYV1YU9GsBrwMnaNIQSotONYmbkg2dzyCZ4IbmQ6kIwJc5ZvUat2D1ZjUm pqYBkJRo5J36lOIJDKITAsmuB0z+0WKSXF4m1zV2OFb4yhNa9698BhdJ+dcwAl4W4Ywu WRbJ+yjZUjPgmuZOcU1fbTs3JeFg0dFzzJ2Qs4JuMDdQzdHpVnTVZrCoMba9RLba4LUI u1aw== X-Gm-Message-State: AO0yUKUF8O+CPxR4eviBBWM7In1SsTh5JsGhYkroZFuJAzWAfDvLFxpk mDBMllIA0QKLZpHlYFYr2yvrCw== X-Google-Smtp-Source: AK7set9pt7QezjEQPw1Zf/Ba+nRowHSd9MIKnJbv2WqXNuBsoemYTkBr+IE+DlROtcfwvCK5R5gYvw== X-Received: by 2002:a05:6a20:1e58:b0:ce:7c40:6a98 with SMTP id cy24-20020a056a201e5800b000ce7c406a98mr20034519pzb.28.1678415195656; Thu, 09 Mar 2023 18:26:35 -0800 (PST) Received: from jeff-laptop.lan (c-73-231-146-4.hsd1.ca.comcast.net. [73.231.146.4]) by smtp.gmail.com with ESMTPSA id q17-20020a635051000000b004fc1d91e695sm235965pgl.79.2023.03.09.18.26.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Mar 2023 18:26:35 -0800 (PST) Message-ID: Subject: Re: pgsql: Use ICU by default at initdb time. From: Jeff Davis To: Jeff Davis , pgsql-committers@lists.postgresql.org Cc: Peter Eisentraut Date: Thu, 09 Mar 2023 18:26:34 -0800 In-Reply-To: References: Content-Type: multipart/mixed; boundary="=-tITbHK7G8EMaITogLpfe" User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=-tITbHK7G8EMaITogLpfe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2023-03-09 at 19:11 +0000, Jeff Davis wrote: > Use ICU by default at initdb time. I'm seeing a failure on hoverfly: https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=3Dhoverfly&dt= =3D2023-03-09%2021%3A51%3A45&stg=3Dinitdb-en_US.8859-15 That's because ICU always uses UTF-8 by default. ICU works just fine with many other encodings; is there a reason it doesn't take it from the environment just like for provider=3Dlibc? Of course, we still need to default to UTF-8 when the encoding from the environment isn't supported by ICU. Patch attached. Requires a few test fixups to adapt. --=20 Jeff Davis PostgreSQL Contributor Team - AWS --=-tITbHK7G8EMaITogLpfe Content-Disposition: attachment; filename*0=v1-0001-initdb-obtain-encoding-from-environment-by-defaul.pat; filename*1=ch Content-Type: text/x-patch; name="v1-0001-initdb-obtain-encoding-from-environment-by-defaul.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBkMWUxMDFkZjA5ZTQ0ODU5NzY5NDlkZDQ3Yzk1MDVkYmRhMWRlMDcxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZWZmQGotZGF2aXMuY29tPgpEYXRlOiBU aHUsIDkgTWFyIDIwMjMgMTY6MDA6NDUgLTA4MDAKU3ViamVjdDogW1BBVENIIHYxXSBpbml0ZGI6 IG9idGFpbiBlbmNvZGluZyBmcm9tIGVudmlyb25tZW50IGJ5IGRlZmF1bHQgZm9yCiBJQ1UuCgpU aGUgbGliYyBwcm92aWRlciBhbHJlYWR5IGRpZCBzbywgdGhpcyBqdXN0IG1ha2VzIElDVQpjb25z aXN0ZW50LiBQcmV2aW91c2x5LCBpZiB0aGUgcHJvdmlkZXIgd2FzIElDVSwgaW5pdGRiIGRlZmF1 bHRlZCB0bwpVVEYtOCwgd2hpY2ggbWlnaHQgYmUgaW4gY29uZmxpY3Qgd2l0aCB0aGUgbG9jYWxl IGZyb20gdGhlCmVudmlyb25tZW50LgoKUGVyIGJ1aWxkZmFybSBmYWlsdXJlIG9uIHN5c3RlbSAi aG92ZXJmbHkiIHJlbGF0ZWQgdG8gY29tbWl0CjI3YjYyMzc3YjQuCi0tLQogY29udHJpYi91bmFj Y2VudC9tZXNvbi5idWlsZCAgICAgICAgICAgfCAgMiArLQogc3JjL2Jpbi9pbml0ZGIvaW5pdGRi LmMgICAgICAgICAgICAgICAgfCAxMiArKysrKy0tLS0tLS0KIHNyYy9iaW4vcGdfdXBncmFkZS90 LzAwMl9wZ191cGdyYWRlLnBsIHwgMTUgKysrKystLS0tLS0tLS0tCiBzcmMvYmluL3NjcmlwdHMv dC8wMjBfY3JlYXRlZGIucGwgICAgICB8ICAyICstCiBzcmMvdGVzdC9pY3UvdC8wMTBfZGF0YWJh c2UucGwgICAgICAgICB8ICAyICstCiA1IGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyks IDIwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2NvbnRyaWIvdW5hY2NlbnQvbWVzb24uYnVp bGQgYi9jb250cmliL3VuYWNjZW50L21lc29uLmJ1aWxkCmluZGV4IDYxM2RkMGJlMjIuLjI4NGQz NGVlMjkgMTAwNjQ0Ci0tLSBhL2NvbnRyaWIvdW5hY2NlbnQvbWVzb24uYnVpbGQKKysrIGIvY29u dHJpYi91bmFjY2VudC9tZXNvbi5idWlsZApAQCAtMzcsNiArMzcsNiBAQCB0ZXN0cyArPSB7CiAg ICAgJ3NxbCc6IFsKICAgICAgICd1bmFjY2VudCcsCiAgICAgXSwKLSAgICAncmVncmVzc19hcmdz JzogWyctLWVuY29kaW5nPVVURjgnXSwKKyAgICAncmVncmVzc19hcmdzJzogWyctLWVuY29kaW5n PVVURjgnLCAnLS1uby1sb2NhbGUnXSwKICAgfSwKIH0KZGlmZiAtLWdpdCBhL3NyYy9iaW4vaW5p dGRiL2luaXRkYi5jIGIvc3JjL2Jpbi9pbml0ZGIvaW5pdGRiLmMKaW5kZXggYmY4OGNkMjQzOS4u MDRhNmQ1ODM3NyAxMDA2NDQKLS0tIGEvc3JjL2Jpbi9pbml0ZGIvaW5pdGRiLmMKKysrIGIvc3Jj L2Jpbi9pbml0ZGIvaW5pdGRiLmMKQEAgLTIzNDYsMTggKzIzNDYsMTYgQEAgc2V0dXBfbG9jYWxl X2VuY29kaW5nKHZvaWQpCiAJCQkgICBsY190aW1lKTsKIAl9CiAKLQlpZiAoIWVuY29kaW5nICYm IGxvY2FsZV9wcm92aWRlciA9PSBDT0xMUFJPVklERVJfSUNVKQotCXsKLQkJZW5jb2RpbmdpZCA9 IFBHX1VURjg7Ci0JCXByaW50ZihfKCJUaGUgZGVmYXVsdCBkYXRhYmFzZSBlbmNvZGluZyBoYXMg YmVlbiBzZXQgdG8gXCIlc1wiLlxuIiksCi0JCQkgICBwZ19lbmNvZGluZ190b19jaGFyKGVuY29k aW5naWQpKTsKLQl9Ci0JZWxzZSBpZiAoIWVuY29kaW5nKQorCWlmICghZW5jb2RpbmcpCiAJewog CQlpbnQJCQljdHlwZV9lbmM7CiAKIAkJY3R5cGVfZW5jID0gcGdfZ2V0X2VuY29kaW5nX2Zyb21f bG9jYWxlKGxjX2N0eXBlLCB0cnVlKTsKIAorCQlpZiAobG9jYWxlX3Byb3ZpZGVyID09IENPTExQ Uk9WSURFUl9JQ1UgJiYKKwkJCShjdHlwZV9lbmMgPT0gLTEgfHwgIWlzX2VuY29kaW5nX3N1cHBv cnRlZF9ieV9pY3UoY3R5cGVfZW5jKSkpCisJCQljdHlwZV9lbmMgPSBQR19VVEY4OworCiAJCWlm IChjdHlwZV9lbmMgPT0gLTEpCiAJCXsKIAkJCS8qIENvdWxkbid0IHJlY29nbml6ZSB0aGUgbG9j YWxlJ3MgY29kZXNldCAqLwpkaWZmIC0tZ2l0IGEvc3JjL2Jpbi9wZ191cGdyYWRlL3QvMDAyX3Bn X3VwZ3JhZGUucGwgYi9zcmMvYmluL3BnX3VwZ3JhZGUvdC8wMDJfcGdfdXBncmFkZS5wbAppbmRl eCAxYjVkZjczMGU5Li45MDY2OWYzYzZkIDEwMDY0NAotLS0gYS9zcmMvYmluL3BnX3VwZ3JhZGUv dC8wMDJfcGdfdXBncmFkZS5wbAorKysgYi9zcmMvYmluL3BnX3VwZ3JhZGUvdC8wMDJfcGdfdXBn cmFkZS5wbApAQCAtMTA4LDcgKzEwOCw3IEBAIGlmICgkb2xkbm9kZS0+cGdfdmVyc2lvbiA+PSAx MSkKIAogbXkgJG9yaWdpbmFsX2VuY29kaW5nID0gIjYiOyAjIFVURi04CiBteSAkb3JpZ2luYWxf cHJvdmlkZXIgPSAiYyI7Ci1teSAkb3JpZ2luYWxfY29sbGF0ZSA9ICJDIjsKK215ICRvcmlnaW5h bF9sb2NhbGUgPSAiQyI7CiBteSAkb3JpZ2luYWxfaWN1bG9jYWxlID0gIiI7CiBteSAkcHJvdmlk ZXJfZmllbGQgPSAiJ2MnIEFTIGRhdGxvY3Byb3ZpZGVyIjsKIG15ICRpY3Vsb2NhbGVfZmllbGQg PSAiTlVMTCBBUyBkYXRpY3Vsb2NhbGUiOwpAQCAtMTIzLDcgKzEyMyw3IEBAIGlmICgkb2xkbm9k ZS0+cGdfdmVyc2lvbiA+PSAxNSAmJiAkRU5We3dpdGhfaWN1fSBlcSAneWVzJykKIG15IEBpbml0 ZGJfcGFyYW1zID0gQGN1c3RvbV9vcHRzOwogCiBwdXNoIEBpbml0ZGJfcGFyYW1zLCAoJy0tZW5j b2RpbmcnLCAnVVRGLTgnKTsKLXB1c2ggQGluaXRkYl9wYXJhbXMsICgnLS1sYy1jb2xsYXRlJywg JG9yaWdpbmFsX2NvbGxhdGUpOworcHVzaCBAaW5pdGRiX3BhcmFtcywgKCctLWxvY2FsZScsICRv cmlnaW5hbF9sb2NhbGUpOwogaWYgKCRvcmlnaW5hbF9wcm92aWRlciBlcSAiaSIpCiB7CiAJcHVz aCBAaW5pdGRiX3BhcmFtcywgKCctLWxvY2FsZS1wcm92aWRlcicsICdpY3UnKTsKQEAgLTEzNiwx NiArMTM2LDEyIEBAICRvbGRub2RlLT5zdGFydDsKIAogbXkgJHJlc3VsdDsKICRyZXN1bHQgPSAk b2xkbm9kZS0+c2FmZV9wc3FsKAotCSdwb3N0Z3JlcycsICJTRUxFQ1QgZW5jb2RpbmcsICRwcm92 aWRlcl9maWVsZCwgZGF0Y29sbGF0ZSwgJGljdWxvY2FsZV9maWVsZAorCSdwb3N0Z3JlcycsICJT RUxFQ1QgZW5jb2RpbmcsICRwcm92aWRlcl9maWVsZCwgZGF0Y29sbGF0ZSwgZGF0Y3R5cGUsICRp Y3Vsb2NhbGVfZmllbGQKICAgICAgICAgICAgICAgICAgRlJPTSBwZ19kYXRhYmFzZSBXSEVSRSBk YXRuYW1lPSd0ZW1wbGF0ZTAnIik7Ci1pcygkcmVzdWx0LCAiJG9yaWdpbmFsX2VuY29kaW5nfCRv cmlnaW5hbF9wcm92aWRlcnwkb3JpZ2luYWxfY29sbGF0ZXwkb3JpZ2luYWxfaWN1bG9jYWxlIiwK K2lzKCRyZXN1bHQsICIkb3JpZ2luYWxfZW5jb2Rpbmd8JG9yaWdpbmFsX3Byb3ZpZGVyfCRvcmln aW5hbF9sb2NhbGV8JG9yaWdpbmFsX2xvY2FsZXwkb3JpZ2luYWxfaWN1bG9jYWxlIiwKIAkJImNo ZWNrIGxvY2FsZXMgaW4gb3JpZ2luYWwgY2x1c3RlciIKIAkpOwogCi0jIGNoZWNrIGN0eXBlLCB3 aGljaCB3YXMgYWNxdWlyZWQgZnJvbSBlbnZpcm9ubWVudCBieSBpbml0ZGIKLW15ICRvcmlnaW5h bF9jdHlwZSA9ICRvbGRub2RlLT5zYWZlX3BzcWwoCi0JJ3Bvc3RncmVzJywgcXtTRUxFQ1QgZGF0 Y3R5cGUgRlJPTSBwZ19kYXRhYmFzZSBXSEVSRSBkYXRuYW1lPSd0ZW1wbGF0ZTAnfSk7Ci0KICMg VGhlIGRlZmF1bHQgbG9jYXRpb24gb2YgdGhlIHNvdXJjZSBjb2RlIGlzIHRoZSByb290IG9mIHRo aXMgZGlyZWN0b3J5LgogbXkgJHNyY2RpciA9IGFic19wYXRoKCIuLi8uLi8uLiIpOwogCkBAIC0y MjQsNyArMjIwLDYgQEAgbXkgJG5ld25vZGUgPSBQb3N0Z3JlU1FMOjpUZXN0OjpDbHVzdGVyLT5u ZXcoJ25ld19ub2RlJyk7CiAjIGNsdXN0ZXIuCiBwdXNoIEBpbml0ZGJfcGFyYW1zLCAoJy0tZW5j b2RpbmcnLCAnU1FMX0FTQ0lJJyk7CiBwdXNoIEBpbml0ZGJfcGFyYW1zLCAoJy0tbG9jYWxlLXBy b3ZpZGVyJywgJ2xpYmMnKTsKLXB1c2ggQGluaXRkYl9wYXJhbXMsICgnLS1sYy1jdHlwZScsICdD Jyk7CiAKICRub2RlX3BhcmFtc3tleHRyYX0gPSBcQGluaXRkYl9wYXJhbXM7CiAkbmV3bm9kZS0+ aW5pdCglbm9kZV9wYXJhbXMpOwpAQCAtNDAxLDcgKzM5Niw3IEBAIGlmICgtZCAkbG9nX3BhdGgp CiAkcmVzdWx0ID0gJG5ld25vZGUtPnNhZmVfcHNxbCgKIAkncG9zdGdyZXMnLCAiU0VMRUNUIGVu Y29kaW5nLCAkcHJvdmlkZXJfZmllbGQsIGRhdGNvbGxhdGUsIGRhdGN0eXBlLCAkaWN1bG9jYWxl X2ZpZWxkCiAgICAgICAgICAgICAgICAgIEZST00gcGdfZGF0YWJhc2UgV0hFUkUgZGF0bmFtZT0n dGVtcGxhdGUwJyIpOwotaXMoJHJlc3VsdCwgIiRvcmlnaW5hbF9lbmNvZGluZ3wkb3JpZ2luYWxf cHJvdmlkZXJ8JG9yaWdpbmFsX2NvbGxhdGV8JG9yaWdpbmFsX2N0eXBlfCRvcmlnaW5hbF9pY3Vs b2NhbGUiLAoraXMoJHJlc3VsdCwgIiRvcmlnaW5hbF9lbmNvZGluZ3wkb3JpZ2luYWxfcHJvdmlk ZXJ8JG9yaWdpbmFsX2xvY2FsZXwkb3JpZ2luYWxfbG9jYWxlfCRvcmlnaW5hbF9pY3Vsb2NhbGUi LAogCQkiY2hlY2sgdGhhdCBsb2NhbGVzIGluIG5ldyBjbHVzdGVyIG1hdGNoIG9yaWdpbmFsIGNs dXN0ZXIiCiAJKTsKIApkaWZmIC0tZ2l0IGEvc3JjL2Jpbi9zY3JpcHRzL3QvMDIwX2NyZWF0ZWRi LnBsIGIvc3JjL2Jpbi9zY3JpcHRzL3QvMDIwX2NyZWF0ZWRiLnBsCmluZGV4IDhlYzU4Y2RkNjQu LmFmM2IxNDkyZTMgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vc2NyaXB0cy90LzAyMF9jcmVhdGVkYi5w bAorKysgYi9zcmMvYmluL3NjcmlwdHMvdC8wMjBfY3JlYXRlZGIucGwKQEAgLTQxLDcgKzQxLDcg QEAgaWYgKCRFTlZ7d2l0aF9pY3V9IGVxICd5ZXMnKQogCQlbCiAJCQknY3JlYXRlZGInLCAgICAg ICAgJy1UJywKIAkJCSd0ZW1wbGF0ZTAnLCAgICAgICAnLUUnLCAnVVRGOCcsICctLWxvY2FsZS1w cm92aWRlcj1pY3UnLAotCQkJJy0taWN1LWxvY2FsZT1lbicsICdmb29iYXI1JworCQkJJy0tbG9j YWxlPUMnLCAgICAgICctLWljdS1sb2NhbGU9ZW4nLCAnZm9vYmFyNScKIAkJXSwKIAkJcXIvc3Rh dGVtZW50OiBDUkVBVEUgREFUQUJBU0UgZm9vYmFyNSAuKiBMT0NBTEVfUFJPVklERVIgaWN1IElD VV9MT0NBTEUgJ2VuJy8sCiAJCSdjcmVhdGUgZGF0YWJhc2Ugd2l0aCBJQ1UgbG9jYWxlIHNwZWNp ZmllZCcpOwpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvaWN1L3QvMDEwX2RhdGFiYXNlLnBsIGIvc3Jj L3Rlc3QvaWN1L3QvMDEwX2RhdGFiYXNlLnBsCmluZGV4IDQ1ZDc3YzMxOWEuLjcxNWIxYmZmZDYg MTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L2ljdS90LzAxMF9kYXRhYmFzZS5wbAorKysgYi9zcmMvdGVz dC9pY3UvdC8wMTBfZGF0YWJhc2UucGwKQEAgLTU0LDcgKzU0LDcgQEAgYiksCiAjIFRlc3QgZXJy b3IgY2FzZXMgaW4gQ1JFQVRFIERBVEFCQVNFIGludm9sdmluZyBsb2NhbGUtcmVsYXRlZCBvcHRp b25zCiAKIG15ICgkcmV0LCAkc3Rkb3V0LCAkc3RkZXJyKSA9ICRub2RlMS0+cHNxbCgncG9zdGdy ZXMnLAotCXF7Q1JFQVRFIERBVEFCQVNFIGRiaWN1IExPQ0FMRV9QUk9WSURFUiBpY3UgVEVNUExB VEUgdGVtcGxhdGUwIEVOQ09ESU5HIFVURjh9KTsKKwlxe0NSRUFURSBEQVRBQkFTRSBkYmljdSBM T0NBTEVfUFJPVklERVIgaWN1IExPQ0FMRSAnQycgVEVNUExBVEUgdGVtcGxhdGUwIEVOQ09ESU5H IFVURjh9KTsKIGlzbnQoJHJldCwgMCwKIAkiSUNVIGxvY2FsZSBtdXN0IGJlIHNwZWNpZmllZCBm b3IgSUNVIHByb3ZpZGVyOiBleGl0IGNvZGUgbm90IDAiKTsKIGxpa2UoCi0tIAoyLjM0LjEKCg== --=-tITbHK7G8EMaITogLpfe--