Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmXTL-0003zU-5A for pgsql-committers@arkaria.postgresql.org; Thu, 24 Jan 2019 05:22:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gmXTJ-0000ai-H9 for pgsql-committers@arkaria.postgresql.org; Thu, 24 Jan 2019 05:22:37 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmXTJ-0000aV-89 for pgsql-committers@lists.postgresql.org; Thu, 24 Jan 2019 05:22:37 +0000 Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gmXTB-0001Eo-Ae for pgsql-committers@lists.postgresql.org; Thu, 24 Jan 2019 05:22:36 +0000 Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id x0O5MKuV014956; Thu, 24 Jan 2019 14:22:20 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 0693D638C56; Thu, 24 Jan 2019 14:22:20 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id EF53F638BA8; Thu, 24 Jan 2019 14:22:19 +0900 (JST) Received: from [127.0.0.1] (unknown [129.60.241.61]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id E9DA74003B0; Thu, 24 Jan 2019 14:22:19 +0900 (JST) Subject: Re: pgsql: Detach constraints when partitions are detached References: <21693.1548305934@sss.pgh.pa.us> From: Amit Langote Message-ID: Date: Thu, 24 Jan 2019 14:22:07 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <21693.1548305934@sss.pgh.pa.us> Content-Type: multipart/mixed; boundary="------------E9DAE51307AD9F5FA728A4DA" Content-Language: en-US X-CC-Mail-RelayStamp: 1 To: Tom Lane , Alvaro Herrera Cc: pgsql-committers@lists.postgresql.org X-TM-AS-MML: disable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------E9DAE51307AD9F5FA728A4DA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 2019/01/24 13:58, Tom Lane wrote: > Alvaro Herrera writes: >> Detach constraints when partitions are detached > > Hm ... it looks like this fails under -DRELCACHE_FORCE_RELEASE: Oops, sorry. This is why: index_close(idx, NoLock); ... + if (!idx->rd_index->indisprimary && !idx->rd_index->indisunique) + continue; Attached a fix. Thanks, Amit --------------E9DAE51307AD9F5FA728A4DA Content-Type: text/plain; charset=UTF-8; name="ae366aa577-fixup.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="ae366aa577-fixup.patch" ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3RhYmxlY21kcy5jIGIvc3JjL2Jh Y2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKaW5kZXggNzM4YzE3ODEwNy4uOTgzNjZhMmQ1 YiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKKysrIGIv c3JjL2JhY2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKQEAgLTE1MDk1LDYgKzE1MDk1LDcg QEAgQVRFeGVjRGV0YWNoUGFydGl0aW9uKFJlbGF0aW9uIHJlbCwgUmFuZ2VWYXIgKm5hbWUp CiAJewogCQlPaWQJCQlpZHhpZCA9IGxmaXJzdF9vaWQoY2VsbCk7CiAJCVJlbGF0aW9uCWlk eDsKKwkJYm9vbAkJZGV0YWNoQ29uc3RyYWludCA9IGZhbHNlOwogCQlPaWQJCQljb25zdHJP aWQ7CiAKIAkJaWYgKCFoYXNfc3VwZXJjbGFzcyhpZHhpZCkpCkBAIC0xNTEwNiwxNCArMTUx MDcsMTggQEAgQVRFeGVjRGV0YWNoUGFydGl0aW9uKFJlbGF0aW9uIHJlbCwgUmFuZ2VWYXIg Km5hbWUpCiAJCWlkeCA9IGluZGV4X29wZW4oaWR4aWQsIEFjY2Vzc0V4Y2x1c2l2ZUxvY2sp OwogCQlJbmRleFNldFBhcmVudEluZGV4KGlkeCwgSW52YWxpZE9pZCk7CiAJCXVwZGF0ZV9y ZWxpc3BhcnRpdGlvbihjbGFzc1JlbCwgaWR4aWQsIGZhbHNlKTsKLQkJaW5kZXhfY2xvc2Uo aWR4LCBOb0xvY2spOwogCiAJCS8qCiAJCSAqIERldGFjaCBhbnkgY29uc3RyYWludHMgYXNz b2NpYXRlZCB3aXRoIHRoZSBpbmRleCB0b28uICBPbmx5IFVOSVFVRQogCQkgKiBhbmQgUFJJ TUFSWSBLRVkgaW5kZXggY29uc3RyYWludHMgY2FuIGJlIGluaGVyaXRlZCwgc28gbm8gbmVl ZAogCQkgKiB0byBjaGVjayBmb3Igb3RoZXJzLgogCQkgKi8KLQkJaWYgKCFpZHgtPnJkX2lu ZGV4LT5pbmRpc3ByaW1hcnkgJiYgIWlkeC0+cmRfaW5kZXgtPmluZGlzdW5pcXVlKQorCQlp ZiAoaWR4LT5yZF9pbmRleC0+aW5kaXNwcmltYXJ5IHx8IGlkeC0+cmRfaW5kZXgtPmluZGlz dW5pcXVlKQorCQkJZGV0YWNoQ29uc3RyYWludCA9IHRydWU7CisKKwkJaW5kZXhfY2xvc2Uo aWR4LCBOb0xvY2spOworCisJCWlmICghZGV0YWNoQ29uc3RyYWludCkKIAkJCWNvbnRpbnVl OwogCiAJCWNvbnN0ck9pZCA9IGdldF9yZWxhdGlvbl9pZHhfY29uc3RyYWludF9vaWQoUmVs YXRpb25HZXRSZWxpZChwYXJ0UmVsKSwK --------------E9DAE51307AD9F5FA728A4DA--