Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jKBNc-0000ma-Tz for pgsql-committers@arkaria.postgresql.org; Fri, 03 Apr 2020 01:44:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jKBNb-0008T7-Qr for pgsql-committers@arkaria.postgresql.org; Fri, 03 Apr 2020 01:44:19 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jKBKe-0005C5-CZ for pgsql-committers@lists.postgresql.org; Fri, 03 Apr 2020 01:41:16 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jKBKb-0005su-C8 for pgsql-committers@lists.postgresql.org; Fri, 03 Apr 2020 01:41:15 +0000 Received: from hnk.local (p2421237-ipbf2725funabasi.chiba.ocn.ne.jp [122.24.33.237]) by oss.nttdata.com (Postfix) with ESMTPSA id 9A83660134; Fri, 3 Apr 2020 10:41:09 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.2 at oss.nttdata.com Subject: Re: pgsql: pg_waldump: Add a --quiet option. To: Robert Haas , pgsql-committers@lists.postgresql.org References: From: Fujii Masao Message-ID: Date: Fri, 3 Apr 2020 10:41:09 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020/04/03 10:11, Robert Haas wrote: > pg_waldump: Add a --quiet option. > > The primary motivation for this change is that it will be used by the > upcoming patch to add backup manifests, but it also seems to have some > potential more general use. I'm not sure what the actual purpose of this feature yet, but ISTM that the following change is necessary. Otherwise, "empty" stats information is output even when --quiet is specified. - if (config.stats == true) + if (config.stats == true && !config.quiet) XLogDumpDisplayStats(&config, &stats); Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION